From tony.printezis at oracle.com Tue Feb 1 07:47:32 2011 From: tony.printezis at oracle.com (tony.printezis at oracle.com) Date: Tue, 01 Feb 2011 07:47:32 +0000 Subject: hg: jdk7/hotspot-gc/hotspot: 7014679: G1: deadlock during concurrent cleanup Message-ID: <20110201074739.53241472F3@hg.openjdk.java.net> Changeset: b7a938236e43 Author: tonyp Date: 2011-01-31 16:28 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/b7a938236e43 7014679: G1: deadlock during concurrent cleanup Summary: There's a potential deadlock between the concurrent cleanup thread and the GC workers that are trying to allocate and waiting for more free regions to be made available. Reviewed-by: iveresov, jcoomes ! src/share/vm/gc_implementation/g1/concurrentMarkThread.cpp From vladimir.kozlov at oracle.com Tue Feb 1 19:03:37 2011 From: vladimir.kozlov at oracle.com (Vladimir Kozlov) Date: Tue, 01 Feb 2011 11:03:37 -0800 Subject: Request for reviews (S): 7014874: Incorrect COOPs modes on solaris-{sparcv9, amd64} with ParallelGC In-Reply-To: <4D42F9D5.6060003@oracle.com> References: <4D41EF1D.502@oracle.com> <4D41F382.8060006@oracle.com> <4D41F67E.9060006@oracle.com> <4D41F8CB.5080107@oracle.com> <4D41FB4C.2040304@oracle.com> <4D42F9D5.6060003@oracle.com> Message-ID: <4D485909.4030807@oracle.com> Serial, CMS and G1 all don't increase heap size. One thing I notice is compressed oops are still OFF by default with G1. Any plans to switch it ON? Thanks, Vladimir Y. Srinivas Ramakrishna wrote: > Hi Vladimir -- > > On 1/27/2011 3:10 PM, Vladimir Kozlov wrote: >> As Igor explained me only Parallel GC requires boundary >> page size alignment due to UseAdaptiveGCBoundary feature. > > Hmm, I do see a lot of "align_size_up()" done on max_size specs > in CollectedHeap::initialize_size_info() and friends, > as well as in GenerationSpec::align(). I didn't follow the > logic through to see if that will or will not affect the > whole heap sizing behaviour wrt the issue > reported in the CR. The bug report states the > anomalous behaviour with ParallelScavenge heaps, > Have you tested G1CollectedHeap and GenCollectedHeap > to see if they do the right thing? > > thanks. > -- ramki > >> >> Vladimir >> >> Y. S. Ramakrishna wrote: >>> May be you need a "partition_aligned()" method that >>> takes an aligned whole and produces aligned partitions >>> thereof given a desired_partitioning request. It would >>> seem as though similar logic would need to apply to >>> other kinds of heaps... or do they do the right thing >>> already? OK, i suppose i should go look, since i am >>> supposed to be reviewing, not interviewing ;-) >>> >>> -- ramki >>> >>> On 01/27/11 14:49, Vladimir Kozlov wrote: >>>> Before rounding YG+OG == total heap size. To keep the same >>>> total size I need to round one size up and the other down. >>>> I still may not preserver the same total size if it is not >>>> rounded to the same or large alignment. But it is fine. >>>> >>>> I already fixed PG rounding before in 6984368 changes: >>>> >>>> src/share/vm/memory/collectorPolicy.cpp Tue Sep 14 17:19:35 2010 -0700 >>>> @@ -32,7 +32,11 @@ >>>> MaxPermSize = PermSize; >>>> } >>>> PermSize = MAX2(min_alignment(), align_size_down_(PermSize, >>>> min_alignment())); >>>> - MaxPermSize = align_size_up(MaxPermSize, max_alignment()); >>>> + // Don't increase Perm size limit above specified. >>>> + MaxPermSize = align_size_down(MaxPermSize, max_alignment()); >>>> + if (PermSize > MaxPermSize) { >>>> + PermSize = MaxPermSize; >>>> + } >>>> >>>> Vladimir >>>> >>>> Y. S. Ramakrishna wrote: >>>>> I don't understand the logic of the patch. Or rather, i do, >>>>> but i question if it is complete: why didn't you also align >>>>> the max size of YG and PG down in like manner? I think you >>>>> should or you would be open to the same issues, no? >>>>> >>>>> In fact, it seems as though, as a matter of uniform policy, all min's >>>>> should align upwards and all max's align downwards wherever >>>>> (page-)alignment >>>>> is sought. >>>>> >>>>> -- ramki >>>>> >>>>> >>>>> On 01/27/11 14:18, Vladimir Kozlov wrote: >>>>>> http://cr.openjdk.java.net/~kvn/7014874/webrev >>>>>> >>>>>> Fixed 7014874: Incorrect COOPs modes on solaris-{sparcv9,amd64} >>>>>> with ParallelGC >>>>>> >>>>>> scale_by_NewRatio_aligned() aligns boundary between old >>>>>> and young gens to min_alignment() (64K). But code in >>>>>> ParallelScavengeHeap::initialize() aligns up both old and >>>>>> young gen sizes to large page size. >>>>>> As result total heap size could be increased by one large >>>>>> page and cross 4gb boundary preventing usage of 32-bit COOPs. >>>>>> >>>>>> Align old gen size down to keep specified heap size but >>>>>> not less than its old gen min size. > From y.s.ramakrishna at oracle.com Tue Feb 1 22:35:36 2011 From: y.s.ramakrishna at oracle.com (y.s.ramakrishna at oracle.com) Date: Tue, 01 Feb 2011 22:35:36 +0000 Subject: hg: jdk7/hotspot-gc/hotspot: 6999988: CMS: Increased fragmentation leading to promotion failure after CR#6631166 got implemented Message-ID: <20110201223540.B379047324@hg.openjdk.java.net> Changeset: e49cfa28f585 Author: ysr Date: 2011-02-01 10:02 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/e49cfa28f585 6999988: CMS: Increased fragmentation leading to promotion failure after CR#6631166 got implemented Summary: Fix calculation of _desired, in free list statistics, which was missing an intended set of parentheses. Reviewed-by: poonam, jmasa ! src/share/vm/gc_implementation/shared/allocationStats.hpp From bengt.rutisson at oracle.com Wed Feb 2 11:44:42 2011 From: bengt.rutisson at oracle.com (bengt.rutisson at oracle.com) Date: Wed, 02 Feb 2011 11:44:42 +0000 Subject: hg: jdk7/hotspot-gc/hotspot: 6789220: CMS: intermittent timeout running nsk/regression/b4796926 Message-ID: <20110202114445.DFAB44734B@hg.openjdk.java.net> Changeset: 986b2844f7a2 Author: brutisso Date: 2011-02-01 14:05 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/986b2844f7a2 6789220: CMS: intermittent timeout running nsk/regression/b4796926 Summary: The reference handler java thread and the GC could dead lock Reviewed-by: never, johnc, jcoomes ! src/share/vm/compiler/compileBroker.cpp From john.cuthbertson at oracle.com Wed Feb 2 21:51:51 2011 From: john.cuthbertson at oracle.com (john.cuthbertson at oracle.com) Date: Wed, 02 Feb 2011 21:51:51 +0000 Subject: hg: jdk7/hotspot-gc/hotspot: 6923430: G1: assert(res != 0,"This should have worked."); ... Message-ID: <20110202215155.1AB4B4736B@hg.openjdk.java.net> Changeset: c33825b68624 Author: johnc Date: 2011-02-02 10:41 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/c33825b68624 6923430: G1: assert(res != 0,"This should have worked.") 7007446: G1: expand the heap with a single step, not one region at a time Summary: Changed G1CollectedHeap::expand() to expand the committed space by calling VirtualSpace::expand_by() once rather than for every region in the expansion amount. This allows the success or failure of the expansion to be determined before creating any heap regions. Introduced a develop flag G1ExitOnExpansionFailure (false by default) that, when true, will exit the VM if the expansion of the committed space fails. Finally G1CollectedHeap::expand() returns a status back to it's caller so that the caller knows whether to attempt the allocation. Reviewed-by: brutisso, tonyp ! src/share/vm/gc_implementation/g1/concurrentG1Refine.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1RemSet.cpp ! src/share/vm/gc_implementation/g1/g1_globals.hpp From bengt.rutisson at oracle.com Thu Feb 3 07:18:09 2011 From: bengt.rutisson at oracle.com (Bengt Rutisson) Date: Thu, 03 Feb 2011 08:18:09 +0100 Subject: Review Request (s) - 7015169 GC Cause not always set In-Reply-To: <4D432B74.1010700@oracle.com> References: <4D415E57.1080902@oracle.com> <4D432055.9080608@oracle.com> <4D4327C0.4030607@oracle.com> <4D432B74.1010700@oracle.com> Message-ID: <4D4A56B1.50207@oracle.com> Ramki and Tony, thanks for your comments! Yasumasa has made the changes that you requested and I have put together an updated webrev: http://cr.openjdk.java.net/~brutisso/7015169/webrev.01/ We discussed whether or not the asserts in VM_GC_Operation::doit_prologue() are really necessary now that the cause is always set by the contructor. We decided to leave the asserts in for the webrev. If anyone thinks they are unnecessary we'll remove them. We also found that GCCause::is_for_full_collection() in gcCause.cpp was dead code and removed this method as part of this change. Thanks, Bengt On 2011-01-28 21:47, Y. Srinivas Ramakrishna wrote: > On 1/28/2011 12:32 PM, Tony Printezis wrote: >> Ramki, >> >> Instead of the c'or of the base class setting the _cause field to a >> known value and checking later >> that the value has been changed, why don't we introduce a cause field >> on the c'or of the base class, >> which is then assigned to _cause, to force all subclasses to pass a >> value to it? > > Ah, but of course :-) (or as the American expression goes: "Doh!"). > > -- ramki > >> >> Tony >> >> Y. Srinivas Ramakrishna wrote: >>> Hi Bengt -- >>> >>> This looks generally good to me, but i was wondering if we could >>> somehow make this >>> less "error-prone" in the following sense. There appears to be >>> nothing that >>> forces a gc op to actually set the _gc_cause value. We rely on each >>> gc op >>> c'tor to initialize the field, and for each doit() to use a >>> GCCauseSetter >>> to export the value into the heap when it runs. It would be nice if >>> we could verify that each op had its _gc_cause field initialized in the >>> c'tor, or at least before its doit() ran, and for one place to export >>> the field rather than each subclass remembering to do it. For the >>> former, >>> the only thing i can think of off the top of my head is a hack: have >>> the >>> base class with that field initialize _gc_cause to "_no_cause" in >>> its c'tor, >>> and to check in its d'tor that the value has been changed to something >>> different. We can't have the base class's c'tor check this >>> because the subclass c'tors would not have run by then. >>> For the latter, the only thing i could think of >>> feels somewhat awkward too: have the VMThread check if an STW op is a >>> GC op (we could introduce an attribute to check for this for any vm >>> op), >>> and do the GCCauseSetter thing in the VM thread before calling the >>> doit() >>> for each such op; may be the VMThread could at that time check that the >>> cause field was not a "not set" value. Unfortunately, this kind of >>> leaks >>> these attributes and checks out of the vm op classes and so feels >>> awkward. >>> Perhaps someone might have better ideas on how that might be achieved. >>> (Of course such a "clean-up" could happen separately rather than >>> needing >>> to be done in this changeset.) >>> >>> Other than those very high level comments, your changes look good to me >>> otherwise wrt their specifics. I did not of course check that we got >>> all the missing initializations which is one reason why i raised this >>> issue as well as to ease future changes and new gc vm ops. >>> >>> -- ramki >>> >>> On 1/27/2011 4:00 AM, Bengt Rutisson wrote: >>>> >>>> Hi Everybody, >>>> >>>> Following up on a mail discussion called "jstat LGCC column shows" >>>> on this mailing list. Yasumasa >>>> Suenaga has agreed to contribute the patch that he made to the >>>> OpenJDK project. I am helping him to >>>> get it pushed into the OpenJDK repositories. >>>> >>>> We created bug 7015169 for this issue. It is not available on >>>> http://bugs.sun.com yet, but I hope it >>>> gets published there soon. >>>> >>>> To push we need a couple of reviews. Here is the webrev: >>>> http://cr.openjdk.java.net/~brutisso/7015169/webrev.00/ >>>> >>>> The problem was that _gc_cause was not set by all VM_GC_Operation >>>> that can request a GC. This was >>>> visible through jstat and with Yasumasa's fix the LGCC columns >>>> shows the correct GC cause. >>>> >>>> Thanks, >>>> Bengt >>> > From mlists at juma.me.uk Thu Feb 3 10:45:38 2011 From: mlists at juma.me.uk (Ismael Juma) Date: Thu, 3 Feb 2011 10:45:38 +0000 (UTC) Subject: Request for reviews (S): 7014874: Incorrect COOPs modes =?utf-8?b?b24Jc29sYXJpcy17c3BhcmN2OSw=?= =?utf-8?b?YW1kNjR9?= with ParallelGC References: <4D41EF1D.502@oracle.com> <4D41F382.8060006@oracle.com> <4D41F67E.9060006@oracle.com> <4D41F8CB.5080107@oracle.com> <4D41FB4C.2040304@oracle.com> <4D42F9D5.6060003@oracle.com> <4D485909.4030807@oracle.com> Message-ID: Vladimir Kozlov writes: > Serial, CMS and G1 all don't increase heap size. > One thing I notice is compressed oops are still OFF by default > with G1. Any plans to switch it ON? I am also interested in this answer. Best, Ismael From y.s.ramakrishna at oracle.com Thu Feb 3 17:08:25 2011 From: y.s.ramakrishna at oracle.com (Y. S. Ramakrishna) Date: Thu, 03 Feb 2011 09:08:25 -0800 Subject: Review Request (s) - 7015169 GC Cause not always set In-Reply-To: <4D4A56B1.50207@oracle.com> References: <4D415E57.1080902@oracle.com> <4D432055.9080608@oracle.com> <4D4327C0.4030607@oracle.com> <4D432B74.1010700@oracle.com> <4D4A56B1.50207@oracle.com> Message-ID: <4D4AE109.9000109@oracle.com> Looks good to me. (PS: At some point in the future, we'll probably want to think about how best to consolidate the export of gc cause into the heap, rather than have each vm gc op doit() as is the case now; the second point i made in a previous email below. For instance, we could s]restructure vm gc ops so the real work is done in a virtual doit_work() method, while the doit() of the vm gc op class does the export and then calls the virtual doit_work(), but that's a possible cleanup for the future and a different debate.) -- ramki On 02/02/11 23:18, Bengt Rutisson wrote: > > Ramki and Tony, thanks for your comments! > > Yasumasa has made the changes that you requested and I have put together > an updated webrev: > > http://cr.openjdk.java.net/~brutisso/7015169/webrev.01/ > > We discussed whether or not the asserts in > VM_GC_Operation::doit_prologue() are really necessary now that the cause > is always set by the contructor. We decided to leave the asserts in for > the webrev. If anyone thinks they are unnecessary we'll remove them. > > We also found that GCCause::is_for_full_collection() in gcCause.cpp was > dead code and removed this method as part of this change. > > Thanks, > Bengt > > > On 2011-01-28 21:47, Y. Srinivas Ramakrishna wrote: >> On 1/28/2011 12:32 PM, Tony Printezis wrote: >>> Ramki, >>> >>> Instead of the c'or of the base class setting the _cause field to a >>> known value and checking later >>> that the value has been changed, why don't we introduce a cause field >>> on the c'or of the base class, >>> which is then assigned to _cause, to force all subclasses to pass a >>> value to it? >> >> Ah, but of course :-) (or as the American expression goes: "Doh!"). >> >> -- ramki >> >>> >>> Tony >>> >>> Y. Srinivas Ramakrishna wrote: >>>> Hi Bengt -- >>>> >>>> This looks generally good to me, but i was wondering if we could >>>> somehow make this >>>> less "error-prone" in the following sense. There appears to be >>>> nothing that >>>> forces a gc op to actually set the _gc_cause value. We rely on each >>>> gc op >>>> c'tor to initialize the field, and for each doit() to use a >>>> GCCauseSetter >>>> to export the value into the heap when it runs. It would be nice if >>>> we could verify that each op had its _gc_cause field initialized in the >>>> c'tor, or at least before its doit() ran, and for one place to export >>>> the field rather than each subclass remembering to do it. For the >>>> former, >>>> the only thing i can think of off the top of my head is a hack: have >>>> the >>>> base class with that field initialize _gc_cause to "_no_cause" in >>>> its c'tor, >>>> and to check in its d'tor that the value has been changed to something >>>> different. We can't have the base class's c'tor check this >>>> because the subclass c'tors would not have run by then. >>>> For the latter, the only thing i could think of >>>> feels somewhat awkward too: have the VMThread check if an STW op is a >>>> GC op (we could introduce an attribute to check for this for any vm >>>> op), >>>> and do the GCCauseSetter thing in the VM thread before calling the >>>> doit() >>>> for each such op; may be the VMThread could at that time check that the >>>> cause field was not a "not set" value. Unfortunately, this kind of >>>> leaks >>>> these attributes and checks out of the vm op classes and so feels >>>> awkward. >>>> Perhaps someone might have better ideas on how that might be achieved. >>>> (Of course such a "clean-up" could happen separately rather than >>>> needing >>>> to be done in this changeset.) >>>> >>>> Other than those very high level comments, your changes look good to me >>>> otherwise wrt their specifics. I did not of course check that we got >>>> all the missing initializations which is one reason why i raised this >>>> issue as well as to ease future changes and new gc vm ops. >>>> >>>> -- ramki >>>> >>>> On 1/27/2011 4:00 AM, Bengt Rutisson wrote: >>>>> >>>>> Hi Everybody, >>>>> >>>>> Following up on a mail discussion called "jstat LGCC column shows" >>>>> on this mailing list. Yasumasa >>>>> Suenaga has agreed to contribute the patch that he made to the >>>>> OpenJDK project. I am helping him to >>>>> get it pushed into the OpenJDK repositories. >>>>> >>>>> We created bug 7015169 for this issue. It is not available on >>>>> http://bugs.sun.com yet, but I hope it >>>>> gets published there soon. >>>>> >>>>> To push we need a couple of reviews. Here is the webrev: >>>>> http://cr.openjdk.java.net/~brutisso/7015169/webrev.00/ >>>>> >>>>> The problem was that _gc_cause was not set by all VM_GC_Operation >>>>> that can request a GC. This was >>>>> visible through jstat and with Yasumasa's fix the LGCC columns >>>>> shows the correct GC cause. >>>>> >>>>> Thanks, >>>>> Bengt >>>> >> > From y.s.ramakrishna at oracle.com Thu Feb 3 17:13:30 2011 From: y.s.ramakrishna at oracle.com (Y. S. Ramakrishna) Date: Thu, 03 Feb 2011 09:13:30 -0800 Subject: Request for reviews (S): 7014874: Incorrect COOPs modes on solaris-{sparcv9, amd64} with ParallelGC In-Reply-To: References: <4D41EF1D.502@oracle.com> <4D41F382.8060006@oracle.com> <4D41F67E.9060006@oracle.com> <4D41F8CB.5080107@oracle.com> <4D41FB4C.2040304@oracle.com> <4D42F9D5.6060003@oracle.com> <4D485909.4030807@oracle.com> Message-ID: <4D4AE23A.5000508@oracle.com> Tony or John might know the current status of this. In the past we had left it off because there was an intermittent crash on one of our platforms with one of our integration tests when we switched on compressed oops with G1. Many bugs have been fixed in G1 since then, so it's possible that the problem is gone now. We should certainly test and see if we can switch it on by default. -- ramki On 02/03/11 02:45, Ismael Juma wrote: > Vladimir Kozlov writes: >> Serial, CMS and G1 all don't increase heap size. >> One thing I notice is compressed oops are still OFF by default >> with G1. Any plans to switch it ON? > > I am also interested in this answer. > > Best, > Ismael > From john.cuthbertson at oracle.com Thu Feb 3 17:27:22 2011 From: john.cuthbertson at oracle.com (John Cuthbertson) Date: Thu, 03 Feb 2011 09:27:22 -0800 Subject: Request for reviews (S): 7014874: Incorrect COOPs modes on solaris-{sparcv9, amd64} with ParallelGC In-Reply-To: <4D4AE23A.5000508@oracle.com> References: <4D41EF1D.502@oracle.com> <4D41F382.8060006@oracle.com> <4D41F67E.9060006@oracle.com> <4D41F8CB.5080107@oracle.com> <4D41FB4C.2040304@oracle.com> <4D42F9D5.6060003@oracle.com> <4D485909.4030807@oracle.com> <4D4AE23A.5000508@oracle.com> Message-ID: <4D4AE57A.2040309@oracle.com> I think the test case was one of the 64 bit GCBasher tests in jprt. I'll submit a CR (if there isn't one already) undo the code and submit a good few jprt -stree jprt jobs on all 3 queues. JohnC On 02/03/11 09:13, Y. S. Ramakrishna wrote: > Tony or John might know the current status of this. In the past > we had left it off because there was an intermittent > crash on one of our platforms with one of our integration > tests when we switched on compressed oops with G1. Many bugs > have been fixed in G1 since then, so it's possible that the > problem is gone now. We should certainly test and see if > we can switch it on by default. > > -- ramki > > On 02/03/11 02:45, Ismael Juma wrote: >> Vladimir Kozlov writes: >>> Serial, CMS and G1 all don't increase heap size. >>> One thing I notice is compressed oops are still OFF by default >>> with G1. Any plans to switch it ON? >> >> I am also interested in this answer. >> >> Best, >> Ismael >> From paul.hohensee at oracle.com Thu Feb 3 17:36:18 2011 From: paul.hohensee at oracle.com (Paul Hohensee) Date: Thu, 03 Feb 2011 12:36:18 -0500 Subject: hotspot-gc-dev post from greggdw@westinghouse.com In-Reply-To: <4D24947A.3090005@oracle.com> References: <4D24947A.3090005@oracle.com> Message-ID: <4D4AE792.40501@oracle.com> I filed 7016998 for this. No idea how the original fix got lost. Paul On 1/5/11 10:55 AM, Jon Masamitsu wrote: > I'm forwarding this message from Gregg by hand (as moderator > I had trouble approving it in the usual way). From paul.hohensee at oracle.com Thu Feb 3 19:46:45 2011 From: paul.hohensee at oracle.com (Paul Hohensee) Date: Thu, 03 Feb 2011 14:46:45 -0500 Subject: Pls review 7016998 (XS) Message-ID: <4D4B0625.8050806@oracle.com> 7016998: gcutil class LinearLeastSquareFit doesn't initialize some of its fields Summary: Initialize _sum_x_squared, _intercept and _slope in constructor. Reviewed-by: Webrev here http://cr.openjdk.java.net/~phh/7016998/webrev.00/ Summary says it all. Thanks, Paul From tony.printezis at oracle.com Thu Feb 3 20:25:18 2011 From: tony.printezis at oracle.com (Tony Printezis) Date: Thu, 03 Feb 2011 15:25:18 -0500 Subject: Review Request (s) - 7015169 GC Cause not always set In-Reply-To: <4D4A56B1.50207@oracle.com> References: <4D415E57.1080902@oracle.com> <4D432055.9080608@oracle.com> <4D4327C0.4030607@oracle.com> <4D432B74.1010700@oracle.com> <4D4A56B1.50207@oracle.com> Message-ID: <4D4B0F2E.8000604@oracle.com> Bengt, Looks good. Tony Bengt Rutisson wrote: > > Ramki and Tony, thanks for your comments! > > Yasumasa has made the changes that you requested and I have put > together an updated webrev: > > http://cr.openjdk.java.net/~brutisso/7015169/webrev.01/ > > We discussed whether or not the asserts in > VM_GC_Operation::doit_prologue() are really necessary now that the > cause is always set by the contructor. We decided to leave the asserts > in for the webrev. If anyone thinks they are unnecessary we'll remove > them. > > We also found that GCCause::is_for_full_collection() in gcCause.cpp > was dead code and removed this method as part of this change. > > Thanks, > Bengt > > > On 2011-01-28 21:47, Y. Srinivas Ramakrishna wrote: >> On 1/28/2011 12:32 PM, Tony Printezis wrote: >>> Ramki, >>> >>> Instead of the c'or of the base class setting the _cause field to a >>> known value and checking later >>> that the value has been changed, why don't we introduce a cause >>> field on the c'or of the base class, >>> which is then assigned to _cause, to force all subclasses to pass a >>> value to it? >> >> Ah, but of course :-) (or as the American expression goes: "Doh!"). >> >> -- ramki >> >>> >>> Tony >>> >>> Y. Srinivas Ramakrishna wrote: >>>> Hi Bengt -- >>>> >>>> This looks generally good to me, but i was wondering if we could >>>> somehow make this >>>> less "error-prone" in the following sense. There appears to be >>>> nothing that >>>> forces a gc op to actually set the _gc_cause value. We rely on each >>>> gc op >>>> c'tor to initialize the field, and for each doit() to use a >>>> GCCauseSetter >>>> to export the value into the heap when it runs. It would be nice if >>>> we could verify that each op had its _gc_cause field initialized in >>>> the >>>> c'tor, or at least before its doit() ran, and for one place to export >>>> the field rather than each subclass remembering to do it. For the >>>> former, >>>> the only thing i can think of off the top of my head is a hack: >>>> have the >>>> base class with that field initialize _gc_cause to "_no_cause" in >>>> its c'tor, >>>> and to check in its d'tor that the value has been changed to something >>>> different. We can't have the base class's c'tor check this >>>> because the subclass c'tors would not have run by then. >>>> For the latter, the only thing i could think of >>>> feels somewhat awkward too: have the VMThread check if an STW op is a >>>> GC op (we could introduce an attribute to check for this for any vm >>>> op), >>>> and do the GCCauseSetter thing in the VM thread before calling the >>>> doit() >>>> for each such op; may be the VMThread could at that time check that >>>> the >>>> cause field was not a "not set" value. Unfortunately, this kind of >>>> leaks >>>> these attributes and checks out of the vm op classes and so feels >>>> awkward. >>>> Perhaps someone might have better ideas on how that might be achieved. >>>> (Of course such a "clean-up" could happen separately rather than >>>> needing >>>> to be done in this changeset.) >>>> >>>> Other than those very high level comments, your changes look good >>>> to me >>>> otherwise wrt their specifics. I did not of course check that we got >>>> all the missing initializations which is one reason why i raised this >>>> issue as well as to ease future changes and new gc vm ops. >>>> >>>> -- ramki >>>> >>>> On 1/27/2011 4:00 AM, Bengt Rutisson wrote: >>>>> >>>>> Hi Everybody, >>>>> >>>>> Following up on a mail discussion called "jstat LGCC column shows" >>>>> on this mailing list. Yasumasa >>>>> Suenaga has agreed to contribute the patch that he made to the >>>>> OpenJDK project. I am helping him to >>>>> get it pushed into the OpenJDK repositories. >>>>> >>>>> We created bug 7015169 for this issue. It is not available on >>>>> http://bugs.sun.com yet, but I hope it >>>>> gets published there soon. >>>>> >>>>> To push we need a couple of reviews. Here is the webrev: >>>>> http://cr.openjdk.java.net/~brutisso/7015169/webrev.00/ >>>>> >>>>> The problem was that _gc_cause was not set by all VM_GC_Operation >>>>> that can request a GC. This was >>>>> visible through jstat and with Yasumasa's fix the LGCC columns >>>>> shows the correct GC cause. >>>>> >>>>> Thanks, >>>>> Bengt >>>> >> > From paul.hohensee at oracle.com Thu Feb 3 23:16:00 2011 From: paul.hohensee at oracle.com (paul.hohensee at oracle.com) Date: Thu, 03 Feb 2011 23:16:00 +0000 Subject: hg: jdk7/hotspot-gc/hotspot: 7016998: gcutil class LinearLeastSquareFit doesn't initialize some of its fields Message-ID: <20110203231605.33497473BA@hg.openjdk.java.net> Changeset: 176d0be30214 Author: phh Date: 2011-02-03 16:06 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/176d0be30214 7016998: gcutil class LinearLeastSquareFit doesn't initialize some of its fields Summary: Initialize _sum_x_squared, _intercept and _slope in constructor. Reviewed-by: bobv, coleenp ! src/share/vm/gc_implementation/shared/gcUtil.cpp From john.coomes at oracle.com Fri Feb 4 04:52:04 2011 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 04 Feb 2011 04:52:04 +0000 Subject: hg: jdk7/hotspot-gc: 11 new changesets Message-ID: <20110204045204.3F8A5473E0@hg.openjdk.java.net> Changeset: f722c246ce71 Author: mchung Date: 2011-01-20 22:16 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/rev/f722c246ce71 7013739: jdk_rmi target is missing in the top repo's test/Makefile Reviewed-by: ohair, igor ! test/Makefile Changeset: 65e6601596e2 Author: lana Date: 2011-01-24 13:21 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/rev/65e6601596e2 Merge Changeset: 61f181d43d9a Author: lana Date: 2011-01-28 10:00 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/rev/61f181d43d9a Merge Changeset: 6db0e6f221bd Author: ohair Date: 2011-01-05 17:24 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/rev/6db0e6f221bd 7009969: Remove SKIP_OPENJDK_BUILD from top Makefile Reviewed-by: robilad ! Makefile ! make/Defs-internal.gmk Changeset: 49c463695059 Author: ohair Date: 2011-01-10 10:00 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/rev/49c463695059 Merge Changeset: 6d9bbcc0a8cb Author: ohair Date: 2011-01-13 17:55 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/rev/6d9bbcc0a8cb Merge Changeset: 24900a58ab9f Author: ohair Date: 2011-01-14 14:04 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/rev/24900a58ab9f 6950375: Remove msvcrt.dll from the Windows JRE bundles Reviewed-by: prr ! Makefile ! README-builds.html Changeset: 3a9f19cbf7f1 Author: ohair Date: 2011-01-26 16:05 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/rev/3a9f19cbf7f1 Merge Changeset: a7a4f6db294d Author: ohair Date: 2011-01-27 18:43 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/rev/a7a4f6db294d Merge Changeset: 57d702105b23 Author: ohair Date: 2011-02-02 09:38 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/rev/57d702105b23 Merge Changeset: 904d7c7c44d9 Author: cl Date: 2011-02-03 17:22 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/rev/904d7c7c44d9 Added tag jdk7-b128 for changeset 57d702105b23 ! .hgtags From john.coomes at oracle.com Fri Feb 4 04:52:10 2011 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 04 Feb 2011 04:52:10 +0000 Subject: hg: jdk7/hotspot-gc/corba: Added tag jdk7-b128 for changeset 9baa8f94a11d Message-ID: <20110204045214.A7767473E1@hg.openjdk.java.net> Changeset: 3ff9acc7cc06 Author: cl Date: 2011-02-03 17:22 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/corba/rev/3ff9acc7cc06 Added tag jdk7-b128 for changeset 9baa8f94a11d ! .hgtags From john.coomes at oracle.com Fri Feb 4 04:52:21 2011 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 04 Feb 2011 04:52:21 +0000 Subject: hg: jdk7/hotspot-gc/jaxp: Added tag jdk7-b128 for changeset a42c6132c746 Message-ID: <20110204045221.B6303473E2@hg.openjdk.java.net> Changeset: f5b60c5a310f Author: cl Date: 2011-02-03 17:22 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jaxp/rev/f5b60c5a310f Added tag jdk7-b128 for changeset a42c6132c746 ! .hgtags From john.coomes at oracle.com Fri Feb 4 04:52:28 2011 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 04 Feb 2011 04:52:28 +0000 Subject: hg: jdk7/hotspot-gc/jaxws: Added tag jdk7-b128 for changeset 88d74afc5593 Message-ID: <20110204045228.67641473E3@hg.openjdk.java.net> Changeset: 0f7b39ad9024 Author: cl Date: 2011-02-03 17:22 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jaxws/rev/0f7b39ad9024 Added tag jdk7-b128 for changeset 88d74afc5593 ! .hgtags From john.coomes at oracle.com Fri Feb 4 04:54:55 2011 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 04 Feb 2011 04:54:55 +0000 Subject: hg: jdk7/hotspot-gc/jdk: 92 new changesets Message-ID: <20110204051126.0FF15473EB@hg.openjdk.java.net> Changeset: 63f5c7704faa Author: prr Date: 2011-01-12 15:58 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/63f5c7704faa 6958221: java.awt.Font.getFamily() leads to JVM crash on Linux on JDK7 for "custom" fonts Reviewed-by: igor, jgodinez ! make/sun/awt/mapfile-mawt-vers ! make/sun/awt/mapfile-vers-linux ! make/sun/headless/mapfile-vers ! make/sun/xawt/mapfile-vers ! src/solaris/classes/sun/awt/X11FontManager.java ! src/solaris/classes/sun/awt/motif/MToolkit.java ! src/solaris/native/sun/awt/fontpath.c + test/java/awt/FontClass/X11FontPathCrashTest.java Changeset: 5aae8b3162d0 Author: prr Date: 2011-01-13 10:36 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/5aae8b3162d0 7001056: JDK 7 fails on to build on Solaris 10 update 9 - updated Xrender header files Reviewed-by: igor, jgodinez ! make/sun/xawt/Makefile ! src/solaris/native/sun/java2d/x11/XRBackendNative.c Changeset: 76b8fa7fd229 Author: prr Date: 2011-01-13 12:08 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/76b8fa7fd229 7012269: mapfile for headless awt needs getFontPathNative defined Reviewed-by: igor ! make/sun/headless/mapfile-vers Changeset: 9f3f38c150b5 Author: prr Date: 2011-01-13 14:11 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/9f3f38c150b5 6917884: NPE in sun.font.FcFontConfiguration.getPlatformFontNames Reviewed-by: igor, jgodinez ! src/solaris/classes/sun/font/FontConfigManager.java Changeset: 987aeabbfda3 Author: prr Date: 2011-01-14 11:05 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/987aeabbfda3 6951086: Excessive Local References in sun.font.SunLayoutEngine.nativeLayout Reviewed-by: igor, jgodinez ! src/share/native/sun/font/FontInstanceAdapter.cpp Changeset: 646c3cf1ba37 Author: prr Date: 2011-01-14 11:43 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/646c3cf1ba37 6989370: Windows platform fonts may be incorrectly marked as ineligible for the native rasteriser Reviewed-by: igor, jgodinez ! src/share/classes/sun/font/SunFontManager.java ! src/windows/classes/sun/awt/Win32FontManager.java Changeset: 5cb6bb816a34 Author: prr Date: 2011-01-14 12:10 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/5cb6bb816a34 6925760: Scaled graphics can cause overlapped LCD mode strings on Windows for pixel size > 48 Reviewed-by: igor, jgodinez ! src/share/classes/sun/font/FileFontStrike.java + test/java/awt/FontClass/LCDScale.java Changeset: 8b33567d68b0 Author: jgodinez Date: 2011-01-14 14:25 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/8b33567d68b0 6939417: ArrayIndexOutOfBoundsException in Win 7 on selected printers Reviewed-by: igor, prr ! src/windows/classes/sun/print/Win32PrintService.java ! test/javax/print/DialogMargins.java Changeset: c2fcb5530ba5 Author: prr Date: 2011-01-14 15:07 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/c2fcb5530ba5 6930980: Disable TrueType hinting for fonts known not to hint well Reviewed-by: igor, jgodinez ! src/share/classes/sun/font/FileFontStrike.java ! src/share/classes/sun/font/FontScaler.java ! src/share/classes/sun/font/FreetypeFontScaler.java ! src/share/classes/sun/font/NullFontScaler.java Changeset: 0bec5d506120 Author: dlila Date: 2011-01-19 09:44 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/0bec5d506120 4724552: CubicCurve2D.contains(Rectangle2D) returns true when only partially contained. Summary: Now using subdivision code in sun.awt.geom.Curve. Reviewed-by: flar ! src/share/classes/java/awt/geom/CubicCurve2D.java Changeset: c8a10bfd2fcb Author: dlila Date: 2011-01-19 11:31 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/c8a10bfd2fcb 4493128: CubicCurve2D intersects method fails Summary: Now using subdivision code in sun.awt.geom.Curve. Reviewed-by: flar ! src/share/classes/java/awt/geom/CubicCurve2D.java Changeset: 00cc1c09c6dd Author: prr Date: 2011-01-19 09:22 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/00cc1c09c6dd 6951501: EUDC character is not displayed on Swing Reviewed-by: igor, jgodinez ! src/windows/classes/sun/awt/Win32FontManager.java ! src/windows/native/sun/windows/awt_Win32GraphicsEnv.cpp Changeset: e58e9e32399a Author: prr Date: 2011-01-19 17:02 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/e58e9e32399a 6983037: closed/java/awt/font/FontNames/Type1Fonts.java failed due to missed font Reviewed-by: igor ! src/share/classes/sun/font/SunFontManager.java ! src/solaris/classes/sun/awt/X11FontManager.java Changeset: fe1b5c15afab Author: prr Date: 2011-01-19 17:07 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/fe1b5c15afab 7013109: windows application manifest problems 6820955: Update application manifests with new Windows 7 dpiAware section Reviewed-by: ohair, art ! make/common/Defs-windows.gmk ! make/common/Library.gmk ! make/common/Program.gmk ! src/windows/resource/java.manifest Changeset: aa1825b1b69d Author: lana Date: 2011-01-19 19:35 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/aa1825b1b69d Merge - test/java/awt/Insets/WindowWithWarningTest/WindowWithWarningTest.html - test/java/awt/Insets/WindowWithWarningTest/WindowWithWarningTest.java - test/javax/script/E4XErrorTest.java - test/javax/swing/SwingWorker/6480289/bug6480289.java - test/sun/security/krb5/auto/basic.sh Changeset: 0044e8e16a30 Author: prr Date: 2011-01-20 10:45 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/0044e8e16a30 6980204: closed/java/awt/font/LogicalFonts/MappingTest.java fails Reviewed-by: jgodinez ! src/share/classes/sun/java2d/SunGraphicsEnvironment.java Changeset: b1c41e0321a2 Author: prr Date: 2011-01-20 13:56 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/b1c41e0321a2 7013646: remove obsolete fontconfig files for linux and solaris Reviewed-by: igor, jgodinez ! make/sun/awt/Makefile - src/solaris/classes/sun/awt/fontconfigs/solaris.fontconfig.5.8.properties - src/solaris/classes/sun/awt/fontconfigs/solaris.fontconfig.5.9.properties ! src/solaris/classes/sun/awt/motif/MFontConfiguration.java ! src/solaris/classes/sun/font/FcFontConfiguration.java Changeset: b8f08482aca1 Author: prr Date: 2011-01-21 07:59 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/b8f08482aca1 6892493: potential memory leaks in 2D font code indentified by parfait. Reviewed-by: bae, igor ! src/solaris/native/sun/awt/fontpath.c Changeset: c17e5a95aba7 Author: prr Date: 2011-01-21 08:04 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/c17e5a95aba7 6892138: Windows GDI platform font lookup apis affect start-up for small UI apps Reviewed-by: igor, jgodinez ! src/share/classes/sun/font/SunFontManager.java ! src/windows/classes/sun/awt/Win32FontManager.java + test/java/awt/font/FontNames/LocaleFamilyNames.java Changeset: ade796b84e71 Author: bae Date: 2011-01-24 15:14 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/ade796b84e71 7002766: Java2d: Changes to correct c/c++ language issues for use of parfait Reviewed-by: jgodinez, prr ! src/share/native/sun/awt/image/jpeg/jmorecfg.h ! src/share/native/sun/java2d/cmm/lcms/LCMS.c Changeset: 63a2e8e00a7b Author: bae Date: 2011-01-24 15:37 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/63a2e8e00a7b 6999620: [parfait] potential buffer overruns in 2d and awt Reviewed-by: jgodinez, prr ! src/windows/native/sun/java2d/d3d/D3DGraphicsDevice.cpp ! src/windows/native/sun/windows/awt_Toolkit.cpp Changeset: 74d020ed7f5b Author: lana Date: 2011-01-24 13:18 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/74d020ed7f5b Merge - src/solaris/classes/sun/awt/fontconfigs/solaris.fontconfig.5.8.properties - src/solaris/classes/sun/awt/fontconfigs/solaris.fontconfig.5.9.properties Changeset: 5d4723944cbd Author: dcherepanov Date: 2011-01-20 14:27 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/5d4723944cbd 7011446: ./windows/classes/sun/awt/windows/WToolkit.java needs to avoid spurious wakeup Reviewed-by: anthony ! src/windows/classes/sun/awt/windows/WToolkit.java Changeset: 1bb32dc775c8 Author: dcherepanov Date: 2011-01-20 14:28 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/1bb32dc775c8 7011443: ./share/classes/sun/awt/SunToolkit.java needs to avoid spurious wakeup Reviewed-by: anthony ! src/share/classes/sun/awt/SunToolkit.java Changeset: 4cd8718d4548 Author: dcherepanov Date: 2011-01-20 14:29 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/4cd8718d4548 7011442: AppletClassLoader.java needs to avoid spurious wakeup Reviewed-by: anthony ! src/share/classes/sun/applet/AppletClassLoader.java Changeset: 4c9a9871830f Author: lana Date: 2011-01-20 10:49 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/4c9a9871830f Merge - test/javax/script/E4XErrorTest.java - test/sun/security/krb5/auto/basic.sh Changeset: f6b73a9b3895 Author: lana Date: 2011-01-24 13:20 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/f6b73a9b3895 Merge Changeset: 63972a313ca4 Author: rupashka Date: 2011-01-11 12:51 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/63972a313ca4 6589952: Swing: dead links in API documentation Reviewed-by: alexp ! src/share/classes/javax/swing/AbstractButton.java ! src/share/classes/javax/swing/JEditorPane.java ! src/share/classes/javax/swing/SizeSequence.java ! src/share/classes/javax/swing/TransferHandler.java ! src/share/classes/javax/swing/event/InternalFrameAdapter.java ! src/share/classes/javax/swing/event/InternalFrameListener.java ! src/share/classes/javax/swing/plaf/multi/doc-files/multi_tsc.html ! src/share/classes/javax/swing/plaf/synth/doc-files/synthFileFormat.html ! src/share/classes/javax/swing/text/AsyncBoxView.java ! src/share/classes/javax/swing/text/DefaultCaret.java ! src/share/classes/javax/swing/text/TableView.java ! src/share/classes/javax/swing/text/View.java ! src/share/classes/javax/swing/text/html/HTMLEditorKit.java ! src/share/classes/javax/swing/text/html/ParagraphView.java ! src/share/classes/javax/swing/text/html/StyleSheet.java Changeset: 2a966dd275fc Author: rupashka Date: 2011-01-13 20:12 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/2a966dd275fc 6990651: Regression: NPE when refreshing applet since 6u22-b01 Reviewed-by: peterz ! src/share/classes/javax/swing/text/html/parser/ParserDelegator.java + test/javax/swing/JLabel/7004134/bug7004134.java + test/javax/swing/text/html/parser/Parser/6990651/bug6990651.java Changeset: 5787add5b679 Author: rupashka Date: 2011-01-17 19:14 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/5787add5b679 6342301: Bad interaction between setting the ui and file filters in JFileChooser Reviewed-by: alexp ! src/share/classes/javax/swing/JFileChooser.java + test/javax/swing/JFileChooser/6342301/bug6342301.java Changeset: ca3bafeffd3b Author: rupashka Date: 2011-01-19 17:01 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/ca3bafeffd3b 6246816: SwingSet2 should be rewritten Reviewed-by: peterz ! make/common/Demo.gmk ! make/mkdemo/jfc/Makefile + make/mkdemo/jfc/SwingSet3/Makefile Changeset: e93106dc798b Author: lana Date: 2011-01-19 21:51 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/e93106dc798b Merge - test/java/awt/Insets/WindowWithWarningTest/WindowWithWarningTest.html - test/java/awt/Insets/WindowWithWarningTest/WindowWithWarningTest.java - test/javax/script/E4XErrorTest.java - test/javax/swing/SwingWorker/6480289/bug6480289.java - test/sun/security/krb5/auto/basic.sh Changeset: b45ea2c3bd6d Author: rupashka Date: 2011-01-24 18:04 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/b45ea2c3bd6d 6735293: javax.swing.text.NavigationFilter.getNextVisualPositionFrom() not always throws BadLocationException Reviewed-by: peterz ! src/share/classes/javax/swing/text/View.java + test/javax/swing/text/NavigationFilter/6735293/bug6735293.java Changeset: 1f3ecbfa0c29 Author: lana Date: 2011-01-24 13:21 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/1f3ecbfa0c29 Merge Changeset: b8663921f5d7 Author: chegar Date: 2011-01-07 13:08 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/b8663921f5d7 7000511: PrintStream, PrintWriter, Formatter, Scanner leave files open when exception thrown Reviewed-by: alanb, mduigou ! src/share/classes/java/io/PrintStream.java ! src/share/classes/java/io/PrintWriter.java ! src/share/classes/java/util/Formatter.java ! src/share/classes/java/util/Scanner.java ! test/ProblemList.txt + test/java/io/PrintStream/FailingConstructors.java + test/java/io/PrintWriter/FailingConstructors.java ! test/java/util/Formatter/Constructors.java + test/java/util/Formatter/FailingConstructors.java + test/java/util/Scanner/FailingConstructors.java Changeset: 5124c2a50539 Author: alanb Date: 2011-01-07 15:49 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/5124c2a50539 6993732: Remove the HPI Reviewed-by: ohair, lancea, chegar, mduigou, mchung, mr ! make/common/Defs-linux.gmk ! make/common/Defs-solaris.gmk ! make/common/Defs-windows.gmk ! make/common/Defs.gmk ! make/common/Modules.gmk ! make/common/Release.gmk ! make/java/Makefile ! make/java/fdlibm/Makefile - make/java/hpi/Makefile - make/java/hpi/hpi_common.gmk - make/java/hpi/native/Makefile - make/java/hpi/native/mapfile-vers - make/java/hpi/native/reorder-i586 - make/java/hpi/native/reorder-sparc - make/java/hpi/native/reorder-sparcv9 - make/java/hpi/windows/Makefile ! make/tools/reorder/Makefile - src/share/hpi/export/bool.h - src/share/hpi/export/dll.h - src/share/hpi/export/hpi.h - src/share/hpi/include/hpi_impl.h - src/share/hpi/include/vm_calls.h - src/share/hpi/src/hpi.c - src/solaris/hpi/export/byteorder_md.h - src/solaris/hpi/export/hpi_md.h - src/solaris/hpi/export/io_md.h - src/solaris/hpi/export/path_md.h - src/solaris/hpi/export/timeval_md.h - src/solaris/hpi/include/hpi_init.h - src/solaris/hpi/include/interrupt.h - src/solaris/hpi/include/largefile.h - src/solaris/hpi/include/largefile_linux.h - src/solaris/hpi/include/largefile_solaris.h - src/solaris/hpi/native_threads/include/condvar_md.h - src/solaris/hpi/native_threads/include/monitor_md.h - src/solaris/hpi/native_threads/include/mutex_md.h - src/solaris/hpi/native_threads/include/np.h - src/solaris/hpi/native_threads/include/porting.h - src/solaris/hpi/native_threads/include/threads_md.h - src/solaris/hpi/native_threads/src/condvar_md.c - src/solaris/hpi/native_threads/src/interrupt_md.c - src/solaris/hpi/native_threads/src/monitor_md.c - src/solaris/hpi/native_threads/src/mutex_md.c - src/solaris/hpi/native_threads/src/sys_api_td.c - src/solaris/hpi/native_threads/src/threads_linux.c - src/solaris/hpi/native_threads/src/threads_md.c - src/solaris/hpi/native_threads/src/threads_solaris.c - src/solaris/hpi/src/interrupt.c - src/solaris/hpi/src/linker_md.c - src/solaris/hpi/src/memory_md.c - src/solaris/hpi/src/system_md.c - src/windows/hpi/export/byteorder_md.h - src/windows/hpi/export/hpi_md.h - src/windows/hpi/export/io_md.h - src/windows/hpi/export/path_md.h - src/windows/hpi/export/timeval_md.h - src/windows/hpi/include/monitor_md.h - src/windows/hpi/include/mutex_md.h - src/windows/hpi/include/threads_md.h - src/windows/hpi/src/linker_md.c - src/windows/hpi/src/memory_md.c - src/windows/hpi/src/monitor_md.c - src/windows/hpi/src/path_md.c - src/windows/hpi/src/socket_md.c - src/windows/hpi/src/sys_api_md.c - src/windows/hpi/src/system_md.c - src/windows/hpi/src/threads_md.c Changeset: ddaffd64796c Author: alanb Date: 2011-01-07 15:51 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/ddaffd64796c Merge Changeset: 6bf1c5958c22 Author: chegar Date: 2011-01-07 21:02 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/6bf1c5958c22 7009760: Possible stack corruption in Java_java_net_TwoStacksPlainSocketImpl_socketGetOption Summary: SOCKET_ADDRESS -> SOCKETADDRESS Reviewed-by: alanb ! src/windows/native/java/net/TwoStacksPlainSocketImpl.c Changeset: 3dbc783a8073 Author: smarks Date: 2011-01-07 15:39 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/3dbc783a8073 7008728: diamond conversion of basic security, permissions, authentication Reviewed-by: mullan ! src/share/classes/com/sun/security/auth/PolicyFile.java ! src/share/classes/com/sun/security/auth/callback/DialogCallbackHandler.java ! src/share/classes/com/sun/security/auth/login/ConfigFile.java ! src/share/classes/com/sun/security/auth/module/JndiLoginModule.java ! src/share/classes/com/sun/security/auth/module/KeyStoreLoginModule.java ! src/share/classes/com/sun/security/auth/module/SolarisLoginModule.java ! src/share/classes/com/sun/security/auth/module/UnixLoginModule.java ! src/share/classes/java/security/AccessControlContext.java ! src/share/classes/java/security/BasicPermission.java ! src/share/classes/java/security/CodeSource.java ! src/share/classes/java/security/Permissions.java ! src/share/classes/java/security/ProtectionDomain.java ! src/share/classes/java/security/Provider.java ! src/share/classes/java/security/SecureClassLoader.java ! src/share/classes/java/security/Security.java ! src/share/classes/java/security/UnresolvedPermission.java ! src/share/classes/java/security/UnresolvedPermissionCollection.java ! src/share/classes/javax/security/auth/PrivateCredentialPermission.java ! src/share/classes/javax/security/auth/SubjectDomainCombiner.java ! src/share/classes/javax/security/auth/kerberos/DelegationPermission.java ! src/share/classes/javax/security/auth/kerberos/ServicePermission.java ! src/share/classes/sun/security/acl/AclEntryImpl.java ! src/share/classes/sun/security/acl/AclImpl.java ! src/share/classes/sun/security/acl/GroupImpl.java ! test/com/sun/security/auth/module/LdapLoginModule/CheckConfigs.java ! test/com/sun/security/auth/module/LdapLoginModule/CheckOptions.java Changeset: ee5bf287d0c4 Author: alanb Date: 2011-01-10 09:32 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/ee5bf287d0c4 7002957: (fc) FileChannel.transferTo fails to load libsendfile on Solaris 64-bit Reviewed-by: chegar ! make/java/nio/Makefile ! src/solaris/native/sun/nio/ch/FileChannelImpl.c Changeset: f4d755bbdabe Author: lancea Date: 2011-01-10 14:43 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/f4d755bbdabe 6544224: Remove the need of sun.reflect.misc Reviewed-by: alanb ! src/share/classes/javax/sql/rowset/serial/SerialJavaObject.java Changeset: 2a0ff59928de Author: smarks Date: 2011-01-10 17:06 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/2a0ff59928de 7005608: diamond conversion of JCA and crypto providers Reviewed-by: wetmore ! src/share/classes/java/security/Security.java ! src/share/classes/sun/security/jca/ProviderList.java ! src/share/classes/sun/security/jca/Providers.java ! src/share/classes/sun/security/provider/PolicyFile.java ! src/share/classes/sun/security/provider/Sun.java ! src/share/classes/sun/security/provider/VerificationProvider.java ! src/share/classes/sun/security/provider/X509Factory.java ! src/share/classes/sun/security/rsa/RSACore.java ! src/share/classes/sun/security/rsa/SunRsaSign.java Changeset: befe813e24d2 Author: lancea Date: 2011-01-11 12:36 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/befe813e24d2 7000693: java.sql.Timestamp compareTo() issues using low values Reviewed-by: okutsu ! src/share/classes/java/sql/Timestamp.java Changeset: 6d0217114886 Author: smarks Date: 2011-01-11 13:42 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/6d0217114886 7011095: revert diamond changes from 6880112 that occur in method args Reviewed-by: darcy, alanb ! src/share/classes/com/sun/java/util/jar/pack/BandStructure.java ! src/share/classes/java/io/ObjectStreamClass.java ! src/share/classes/java/lang/StringCoding.java ! src/share/classes/java/util/logging/Logger.java Changeset: cb3ecb5e4ce5 Author: dl Date: 2011-01-12 14:40 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/cb3ecb5e4ce5 7005424: Resync java.util.concurrent classes with Dougs CVS - Jan 2011 Reviewed-by: dholmes, chegar, mduigou ! src/share/classes/java/util/Collections.java ! src/share/classes/java/util/LinkedList.java ! src/share/classes/java/util/concurrent/ArrayBlockingQueue.java ! src/share/classes/java/util/concurrent/ConcurrentLinkedDeque.java ! src/share/classes/java/util/concurrent/ConcurrentLinkedQueue.java ! src/share/classes/java/util/concurrent/ConcurrentSkipListMap.java ! src/share/classes/java/util/concurrent/CopyOnWriteArrayList.java ! src/share/classes/java/util/concurrent/ForkJoinPool.java ! src/share/classes/java/util/concurrent/ForkJoinTask.java ! src/share/classes/java/util/concurrent/ForkJoinWorkerThread.java ! src/share/classes/java/util/concurrent/LinkedBlockingDeque.java ! src/share/classes/java/util/concurrent/LinkedBlockingQueue.java ! src/share/classes/java/util/concurrent/LinkedTransferQueue.java ! src/share/classes/java/util/concurrent/Phaser.java ! src/share/classes/java/util/concurrent/PriorityBlockingQueue.java ! src/share/classes/java/util/concurrent/ScheduledThreadPoolExecutor.java ! src/share/classes/java/util/concurrent/SynchronousQueue.java ! src/share/classes/java/util/concurrent/ThreadPoolExecutor.java ! src/share/classes/java/util/concurrent/atomic/AtomicIntegerArray.java ! src/share/classes/java/util/concurrent/atomic/AtomicLongArray.java ! src/share/classes/java/util/concurrent/atomic/AtomicMarkableReference.java ! src/share/classes/java/util/concurrent/atomic/AtomicReferenceArray.java ! src/share/classes/java/util/concurrent/atomic/AtomicStampedReference.java ! src/share/classes/java/util/concurrent/locks/Condition.java ! test/ProblemList.txt ! test/java/util/WeakHashMap/GCDuringIteration.java ! test/java/util/concurrent/BlockingQueue/CancelledProducerConsumerLoops.java ! test/java/util/concurrent/BlockingQueue/MultipleProducersSingleConsumerLoops.java ! test/java/util/concurrent/BlockingQueue/ProducerConsumerLoops.java ! test/java/util/concurrent/BlockingQueue/SingleProducerMultipleConsumerLoops.java ! test/java/util/concurrent/ConcurrentQueues/IteratorWeakConsistency.java ! test/java/util/concurrent/Executors/AutoShutdown.java ! test/java/util/concurrent/Phaser/Basic.java + test/java/util/concurrent/Phaser/FickleRegister.java + test/java/util/concurrent/Phaser/PhaseOverflow.java + test/java/util/concurrent/Phaser/TieredArriveLoops.java ! test/java/util/concurrent/ThreadPoolExecutor/CoreThreadTimeOut.java Changeset: a5a22f93e4c5 Author: smarks Date: 2011-01-12 13:52 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/a5a22f93e4c5 7008713: diamond conversion of kerberos5 and security tools Reviewed-by: weijun ! src/share/classes/sun/security/krb5/Config.java ! src/share/classes/sun/security/krb5/KdcComm.java ! src/share/classes/sun/security/krb5/PrincipalName.java ! src/share/classes/sun/security/krb5/Realm.java ! src/share/classes/sun/security/krb5/internal/Authenticator.java ! src/share/classes/sun/security/krb5/internal/AuthorizationData.java ! src/share/classes/sun/security/krb5/internal/EncAPRepPart.java ! src/share/classes/sun/security/krb5/internal/HostAddresses.java ! src/share/classes/sun/security/krb5/internal/KDCReq.java ! src/share/classes/sun/security/krb5/internal/KDCReqBody.java ! src/share/classes/sun/security/krb5/internal/KRBCred.java ! src/share/classes/sun/security/krb5/internal/KRBError.java ! src/share/classes/sun/security/krb5/internal/KrbCredInfo.java ! src/share/classes/sun/security/krb5/internal/LastReq.java ! src/share/classes/sun/security/krb5/internal/ccache/FileCredentialsCache.java ! src/share/classes/sun/security/krb5/internal/crypto/EType.java ! src/share/classes/sun/security/krb5/internal/ktab/KeyTab.java ! src/share/classes/sun/security/tools/JarSigner.java ! src/share/classes/sun/security/tools/KeyTool.java ! src/share/classes/sun/security/tools/policytool/PolicyTool.java ! test/sun/security/krb5/IPv6.java ! test/sun/security/krb5/auto/CleanState.java ! test/sun/security/krb5/auto/Context.java ! test/sun/security/krb5/auto/HttpNegotiateServer.java ! test/sun/security/krb5/auto/KDC.java ! test/sun/security/krb5/auto/LoginModuleOptions.java ! test/sun/security/krb5/tools/KtabCheck.java Changeset: f5c0b3cbee2f Author: kamg Date: 2011-01-12 11:47 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/f5c0b3cbee2f 6436034: Instance filter doesn't filter event if it occurs in native method Summary: Use 'GetLocalInstance' JVMTI extension if it exists Reviewed-by: coleenp, dcubed ! src/share/back/debugInit.c ! src/share/back/eventFilter.c ! src/share/instrument/JPLISAgent.c ! src/share/javavm/export/jvmti.h + test/com/sun/jdi/NativeInstanceFilter.java + test/com/sun/jdi/NativeInstanceFilterTarg.java Changeset: 295f6b861c12 Author: kamg Date: 2011-01-12 15:27 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/295f6b861c12 Merge Changeset: 538f913777cf Author: michaelm Date: 2011-01-13 11:01 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/538f913777cf 6896088: URLClassLoader.close() apparently not working for JAR URLs on Windows Reviewed-by: chegar ! src/share/classes/sun/misc/URLClassPath.java + test/java/net/URLClassLoader/B6896088.java Changeset: 9f265d55c1c4 Author: michaelm Date: 2011-01-13 11:02 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/9f265d55c1c4 Merge Changeset: 694951adefec Author: chegar Date: 2011-01-13 13:24 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/694951adefec 6964547: Impossible to set useV4 in SocksSocketImpl Summary: Add socksProxyVersion property Reviewed-by: alanb, michaelm ! make/sun/net/FILES_java.gmk ! src/share/classes/java/io/PrintStream.java ! src/share/classes/java/net/SocksSocketImpl.java ! src/share/classes/java/net/doc-files/net-properties.html + src/share/classes/sun/net/SocksProxy.java ! src/share/classes/sun/net/spi/DefaultProxySelector.java + test/java/net/Socks/SocksProxyVersion.java Changeset: 38729ba6eb4f Author: michaelm Date: 2011-01-12 15:05 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/38729ba6eb4f 6829919: URLClassLoader.close() doesn't close resource file if getResourceAsStream(...) was called before Reviewed-by: chegar ! src/share/classes/java/net/URLClassLoader.java ! test/java/net/URLClassLoader/closetest/CloseTest.java + test/java/net/URLClassLoader/closetest/Common.java + test/java/net/URLClassLoader/closetest/GetResourceAsStream.java + test/java/net/URLClassLoader/closetest/build2.sh Changeset: ed390b2e5ca4 Author: michaelm Date: 2011-01-13 11:10 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/ed390b2e5ca4 Merge Changeset: 067b5f603fc8 Author: michaelm Date: 2011-01-13 14:41 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/067b5f603fc8 Merge Changeset: 3215b22cd90e Author: michaelm Date: 2011-01-13 16:33 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/3215b22cd90e 7003398: NetworkInterface equals() and hashCode() behaviors depend on permissions granted Reviewed-by: chegar, alanb ! src/share/classes/java/net/NetworkInterface.java + test/java/net/NetworkInterface/Equals.java Changeset: 29f2e311cce7 Author: mduigou Date: 2011-01-13 20:32 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/29f2e311cce7 6728865: Provide a better heuristics for Collections.disjoint method Reviewed-by: alanb, dholmes, chegar, forax ! src/share/classes/java/util/Collections.java Changeset: 59e352561146 Author: darcy Date: 2011-01-13 22:21 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/59e352561146 7012279: Project Coin: Clarify AutoCloseable and Throwable javadoc Reviewed-by: jjb ! src/share/classes/java/lang/AutoCloseable.java ! src/share/classes/java/lang/Throwable.java Changeset: 983364897f72 Author: chegar Date: 2011-01-14 22:34 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/983364897f72 7010903: impl. of http.maxConnections is different from the description in JavaSE document Reviewed-by: alanb, michaelm ! src/share/classes/sun/net/www/http/KeepAliveCache.java Changeset: d61d9bf190f5 Author: smarks Date: 2011-01-14 15:31 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/d61d9bf190f5 7012003: diamond conversion for ssl Reviewed-by: wetmore ! src/share/classes/sun/security/ssl/CipherSuite.java ! src/share/classes/sun/security/ssl/CipherSuiteList.java ! src/share/classes/sun/security/ssl/ClientHandshaker.java ! src/share/classes/sun/security/ssl/DefaultSSLContextImpl.java ! src/share/classes/sun/security/ssl/HandshakeMessage.java ! src/share/classes/sun/security/ssl/Handshaker.java ! src/share/classes/sun/security/ssl/HelloExtensions.java ! src/share/classes/sun/security/ssl/ProtocolList.java ! src/share/classes/sun/security/ssl/SSLAlgorithmConstraints.java ! src/share/classes/sun/security/ssl/SSLSessionImpl.java ! src/share/classes/sun/security/ssl/SignatureAndHashAlgorithm.java ! src/share/classes/sun/security/ssl/SunX509KeyManagerImpl.java ! src/share/classes/sun/security/ssl/TrustManagerFactoryImpl.java ! src/share/classes/sun/security/ssl/X509KeyManagerImpl.java ! test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/CookieHandlerTest.java Changeset: 507627325c81 Author: sundar Date: 2011-01-17 13:29 +0530 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/507627325c81 6508943: small typo in the documentation 6759414: javascript engine can not write to StringWriter 6869617: RhinoScriptEngine bug : ScriptException cause not set (with fix) 7012701: Add a test to check that Rhino's RegExp parser accepts unescaped '[' Reviewed-by: alanb, jjh ! src/share/classes/com/sun/script/javascript/RhinoScriptEngine.java ! src/share/classes/javax/script/CompiledScript.java + test/javax/script/CauseExceptionTest.java + test/javax/script/StringWriterPrintTest.java + test/javax/script/UnescapedBracketRegExTest.java Changeset: 9596a600758c Author: lana Date: 2011-01-19 19:00 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/9596a600758c Merge - test/java/awt/Insets/WindowWithWarningTest/WindowWithWarningTest.html - test/java/awt/Insets/WindowWithWarningTest/WindowWithWarningTest.java - test/javax/swing/SwingWorker/6480289/bug6480289.java Changeset: e64b1f11cd0b Author: chegar Date: 2011-01-20 15:23 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/e64b1f11cd0b 7011857: java/util/concurrent/Phaser/FickleRegister.java fails on solaris-sparc Summary: Remove from ProblemList, failure resolved by 7009231 Reviewed-by: alanb ! test/ProblemList.txt Changeset: cc195c981ae2 Author: mchung Date: 2011-01-20 22:17 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/cc195c981ae2 7013739: jdk_rmi target is missing in the top repo's test/Makefile Reviewed-by: ohair, igor ! test/ProblemList.txt Changeset: 2a8d1a0a2418 Author: chegar Date: 2011-01-21 17:02 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/2a8d1a0a2418 7012768: InetAddress lookupTable leaks/deadlocks when using unsupported name service spi Reviewed-by: alanb, michaelm ! src/share/classes/java/net/InetAddress.java - test/java/net/InetAddress/B4762344.java - test/java/net/InetAddress/META-INF/services/sun.net.spi.nameservice.NameServiceDescriptor - test/java/net/InetAddress/Simple1NameServiceDescriptor.java - test/java/net/InetAddress/Simple2NameServiceDescriptor.java - test/java/net/InetAddress/SimpleNameService.java - test/sun/net/InetAddress/nameservice/B6442088.java - test/sun/net/InetAddress/nameservice/CacheTest.java - test/sun/net/InetAddress/nameservice/META-INF/services/sun.net.spi.nameservice.NameServiceDescriptor - test/sun/net/InetAddress/nameservice/SimpleNameService.java - test/sun/net/InetAddress/nameservice/SimpleNameServiceDescriptor.java + test/sun/net/InetAddress/nameservice/chaining/META-INF/services/sun.net.spi.nameservice.NameServiceDescriptor + test/sun/net/InetAddress/nameservice/chaining/Providers.java + test/sun/net/InetAddress/nameservice/chaining/Simple1NameServiceDescriptor.java + test/sun/net/InetAddress/nameservice/chaining/Simple2NameServiceDescriptor.java + test/sun/net/InetAddress/nameservice/chaining/SimpleNameService.java + test/sun/net/InetAddress/nameservice/deadlock/Hang.java + test/sun/net/InetAddress/nameservice/deadlock/META-INF/services/sun.net.spi.nameservice.NameServiceDescriptor + test/sun/net/InetAddress/nameservice/deadlock/ThrowingNameService.java + test/sun/net/InetAddress/nameservice/deadlock/ThrowingNameServiceDescriptor.java + test/sun/net/InetAddress/nameservice/simple/CacheTest.java + test/sun/net/InetAddress/nameservice/simple/DefaultCaching.java + test/sun/net/InetAddress/nameservice/simple/META-INF/services/sun.net.spi.nameservice.NameServiceDescriptor + test/sun/net/InetAddress/nameservice/simple/SimpleNameService.java + test/sun/net/InetAddress/nameservice/simple/SimpleNameServiceDescriptor.java Changeset: 6a7b8406a1b9 Author: chegar Date: 2011-01-21 17:04 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/6a7b8406a1b9 Merge Changeset: f26d1a7fe4d2 Author: mchung Date: 2011-01-21 09:43 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/f26d1a7fe4d2 6912013: Remove the temporary launcher fix to add modules in the bootclasspath Reviewed-by: ksrini ! src/share/bin/java.c ! src/share/bin/java.h ! src/share/classes/sun/launcher/LauncherHelper.java Changeset: 9c18818e7a5f Author: mchung Date: 2011-01-21 09:45 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/9c18818e7a5f Merge - test/java/net/InetAddress/B4762344.java - test/java/net/InetAddress/META-INF/services/sun.net.spi.nameservice.NameServiceDescriptor - test/java/net/InetAddress/Simple1NameServiceDescriptor.java - test/java/net/InetAddress/Simple2NameServiceDescriptor.java - test/java/net/InetAddress/SimpleNameService.java - test/sun/net/InetAddress/nameservice/B6442088.java - test/sun/net/InetAddress/nameservice/CacheTest.java - test/sun/net/InetAddress/nameservice/META-INF/services/sun.net.spi.nameservice.NameServiceDescriptor - test/sun/net/InetAddress/nameservice/SimpleNameService.java - test/sun/net/InetAddress/nameservice/SimpleNameServiceDescriptor.java Changeset: 2381e810330b Author: zgu Date: 2011-01-20 10:45 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/2381e810330b 6983248: net/net001 and net/net003 fail on WinXP with JDK7-B108 Summary: Using closesocket to close socket handler to avoid invalid C runtime parameter exception. Reviewed-by: alanb, phh, dcubed, dsamersoff, coleenp, acorn ! src/windows/demo/jvmti/hprof/hprof_md.c Changeset: d03e47de3a89 Author: zgu Date: 2011-01-21 11:38 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/d03e47de3a89 Merge Changeset: c73c178159d8 Author: phh Date: 2011-01-20 19:34 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/c73c178159d8 6173675: M&M: approximate memory allocation rate/amount per thread Summary: Subclass com.sun.management.ThreadMXBean from java.lang.management.ThreadMXBean, add getAllocatedBytes() and friends to c.s.m.ThreadMXBean and have sun.management.ThreadImpl implement c.s.m.ThreadMXBean rather than j.l.m.ThreadMXBean. Reviewed-by: mchung, alanb, dholmes, emcmanus ! make/java/management/mapfile-vers + src/share/classes/com/sun/management/ThreadMXBean.java ! src/share/classes/sun/management/ThreadImpl.java ! src/share/classes/sun/management/VMManagement.java ! src/share/classes/sun/management/VMManagementImpl.java ! src/share/javavm/export/jmm.h ! src/share/native/sun/management/ThreadImpl.c ! src/share/native/sun/management/VMManagementImpl.c + test/com/sun/management/ThreadMXBean/ThreadAllocatedMemory.java + test/com/sun/management/ThreadMXBean/ThreadAllocatedMemoryArray.java + test/com/sun/management/ThreadMXBean/ThreadCpuTimeArray.java Changeset: 64ef2f52d781 Author: phh Date: 2011-01-21 07:29 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/64ef2f52d781 7013682: two test checking cpuTime filed java/lang/management/ThreadMXBean Summary: Typo in 6173675 fix dropped getThreadCpuTime(long) result on the floor. Reviewed-by: mchung, dholmes ! src/share/classes/sun/management/ThreadImpl.java Changeset: cd13b2114f2e Author: phh Date: 2011-01-22 08:42 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/cd13b2114f2e Merge ! src/share/classes/sun/management/ThreadImpl.java Changeset: d1365fdfb3ea Author: phh Date: 2011-01-22 08:43 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/d1365fdfb3ea Merge - test/java/net/InetAddress/B4762344.java - test/java/net/InetAddress/META-INF/services/sun.net.spi.nameservice.NameServiceDescriptor - test/java/net/InetAddress/Simple1NameServiceDescriptor.java - test/java/net/InetAddress/Simple2NameServiceDescriptor.java - test/java/net/InetAddress/SimpleNameService.java - test/sun/net/InetAddress/nameservice/B6442088.java - test/sun/net/InetAddress/nameservice/CacheTest.java - test/sun/net/InetAddress/nameservice/META-INF/services/sun.net.spi.nameservice.NameServiceDescriptor - test/sun/net/InetAddress/nameservice/SimpleNameService.java - test/sun/net/InetAddress/nameservice/SimpleNameServiceDescriptor.java Changeset: 4cc447291326 Author: sherman Date: 2011-01-24 11:47 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/4cc447291326 7006576: (zipfs) Path.exists() always returns false on dirs when zip/JAR file built without dirs 7009092: (zipfs) ZipPath.isSameFile() should always return true if this Path and the given Path are equal. 7009085: (zipfs) ZipPath.normalize("/./.") returns null. 7009102: (zipfs) ZipPath.toRealPath() should always return absolute path. Summary: zip filesystem provider update Reviewed-by: alanb ! src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipFileSystem.java ! src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipPath.java ! test/demo/zipfs/PathOps.java ! test/demo/zipfs/ZipFSTester.java ! test/demo/zipfs/basic.sh Changeset: 1f977c82b733 Author: lana Date: 2011-01-24 13:24 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/1f977c82b733 Merge ! make/common/Defs-windows.gmk - make/java/hpi/Makefile - make/java/hpi/hpi_common.gmk - make/java/hpi/native/Makefile - make/java/hpi/native/mapfile-vers - make/java/hpi/native/reorder-i586 - make/java/hpi/native/reorder-sparc - make/java/hpi/native/reorder-sparcv9 - make/java/hpi/windows/Makefile - src/share/hpi/export/bool.h - src/share/hpi/export/dll.h - src/share/hpi/export/hpi.h - src/share/hpi/include/hpi_impl.h - src/share/hpi/include/vm_calls.h - src/share/hpi/src/hpi.c - src/solaris/hpi/export/byteorder_md.h - src/solaris/hpi/export/hpi_md.h - src/solaris/hpi/export/io_md.h - src/solaris/hpi/export/path_md.h - src/solaris/hpi/export/timeval_md.h - src/solaris/hpi/include/hpi_init.h - src/solaris/hpi/include/interrupt.h - src/solaris/hpi/include/largefile.h - src/solaris/hpi/include/largefile_linux.h - src/solaris/hpi/include/largefile_solaris.h - src/solaris/hpi/native_threads/include/condvar_md.h - src/solaris/hpi/native_threads/include/monitor_md.h - src/solaris/hpi/native_threads/include/mutex_md.h - src/solaris/hpi/native_threads/include/np.h - src/solaris/hpi/native_threads/include/porting.h - src/solaris/hpi/native_threads/include/threads_md.h - src/solaris/hpi/native_threads/src/condvar_md.c - src/solaris/hpi/native_threads/src/interrupt_md.c - src/solaris/hpi/native_threads/src/monitor_md.c - src/solaris/hpi/native_threads/src/mutex_md.c - src/solaris/hpi/native_threads/src/sys_api_td.c - src/solaris/hpi/native_threads/src/threads_linux.c - src/solaris/hpi/native_threads/src/threads_md.c - src/solaris/hpi/native_threads/src/threads_solaris.c - src/solaris/hpi/src/interrupt.c - src/solaris/hpi/src/linker_md.c - src/solaris/hpi/src/memory_md.c - src/solaris/hpi/src/system_md.c - src/windows/hpi/export/byteorder_md.h - src/windows/hpi/export/hpi_md.h - src/windows/hpi/export/io_md.h - src/windows/hpi/export/path_md.h - src/windows/hpi/export/timeval_md.h - src/windows/hpi/include/monitor_md.h - src/windows/hpi/include/mutex_md.h - src/windows/hpi/include/threads_md.h - src/windows/hpi/src/linker_md.c - src/windows/hpi/src/memory_md.c - src/windows/hpi/src/monitor_md.c - src/windows/hpi/src/path_md.c - src/windows/hpi/src/socket_md.c - src/windows/hpi/src/sys_api_md.c - src/windows/hpi/src/system_md.c - src/windows/hpi/src/threads_md.c - test/java/net/InetAddress/B4762344.java - test/java/net/InetAddress/META-INF/services/sun.net.spi.nameservice.NameServiceDescriptor - test/java/net/InetAddress/Simple1NameServiceDescriptor.java - test/java/net/InetAddress/Simple2NameServiceDescriptor.java - test/java/net/InetAddress/SimpleNameService.java - test/sun/net/InetAddress/nameservice/B6442088.java - test/sun/net/InetAddress/nameservice/CacheTest.java - test/sun/net/InetAddress/nameservice/META-INF/services/sun.net.spi.nameservice.NameServiceDescriptor - test/sun/net/InetAddress/nameservice/SimpleNameService.java - test/sun/net/InetAddress/nameservice/SimpleNameServiceDescriptor.java Changeset: 47cfd89c3227 Author: lana Date: 2011-01-28 10:04 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/47cfd89c3227 Merge - make/java/hpi/Makefile - make/java/hpi/hpi_common.gmk - make/java/hpi/native/Makefile - make/java/hpi/native/mapfile-vers - make/java/hpi/native/reorder-i586 - make/java/hpi/native/reorder-sparc - make/java/hpi/native/reorder-sparcv9 - make/java/hpi/windows/Makefile - src/share/hpi/export/bool.h - src/share/hpi/export/dll.h - src/share/hpi/export/hpi.h - src/share/hpi/include/hpi_impl.h - src/share/hpi/include/vm_calls.h - src/share/hpi/src/hpi.c - src/solaris/classes/sun/awt/fontconfigs/solaris.fontconfig.5.8.properties - src/solaris/classes/sun/awt/fontconfigs/solaris.fontconfig.5.9.properties - src/solaris/hpi/export/byteorder_md.h - src/solaris/hpi/export/hpi_md.h - src/solaris/hpi/export/io_md.h - src/solaris/hpi/export/path_md.h - src/solaris/hpi/export/timeval_md.h - src/solaris/hpi/include/hpi_init.h - src/solaris/hpi/include/interrupt.h - src/solaris/hpi/include/largefile.h - src/solaris/hpi/include/largefile_linux.h - src/solaris/hpi/include/largefile_solaris.h - src/solaris/hpi/native_threads/include/condvar_md.h - src/solaris/hpi/native_threads/include/monitor_md.h - src/solaris/hpi/native_threads/include/mutex_md.h - src/solaris/hpi/native_threads/include/np.h - src/solaris/hpi/native_threads/include/porting.h - src/solaris/hpi/native_threads/include/threads_md.h - src/solaris/hpi/native_threads/src/condvar_md.c - src/solaris/hpi/native_threads/src/interrupt_md.c - src/solaris/hpi/native_threads/src/monitor_md.c - src/solaris/hpi/native_threads/src/mutex_md.c - src/solaris/hpi/native_threads/src/sys_api_td.c - src/solaris/hpi/native_threads/src/threads_linux.c - src/solaris/hpi/native_threads/src/threads_md.c - src/solaris/hpi/native_threads/src/threads_solaris.c - src/solaris/hpi/src/interrupt.c - src/solaris/hpi/src/linker_md.c - src/solaris/hpi/src/memory_md.c - src/solaris/hpi/src/system_md.c - src/windows/hpi/export/byteorder_md.h - src/windows/hpi/export/hpi_md.h - src/windows/hpi/export/io_md.h - src/windows/hpi/export/path_md.h - src/windows/hpi/export/timeval_md.h - src/windows/hpi/include/monitor_md.h - src/windows/hpi/include/mutex_md.h - src/windows/hpi/include/threads_md.h - src/windows/hpi/src/linker_md.c - src/windows/hpi/src/memory_md.c - src/windows/hpi/src/monitor_md.c - src/windows/hpi/src/path_md.c - src/windows/hpi/src/socket_md.c - src/windows/hpi/src/sys_api_md.c - src/windows/hpi/src/system_md.c - src/windows/hpi/src/threads_md.c - test/java/net/InetAddress/B4762344.java - test/java/net/InetAddress/META-INF/services/sun.net.spi.nameservice.NameServiceDescriptor - test/java/net/InetAddress/Simple1NameServiceDescriptor.java - test/java/net/InetAddress/Simple2NameServiceDescriptor.java - test/java/net/InetAddress/SimpleNameService.java - test/sun/net/InetAddress/nameservice/B6442088.java - test/sun/net/InetAddress/nameservice/CacheTest.java - test/sun/net/InetAddress/nameservice/META-INF/services/sun.net.spi.nameservice.NameServiceDescriptor - test/sun/net/InetAddress/nameservice/SimpleNameService.java - test/sun/net/InetAddress/nameservice/SimpleNameServiceDescriptor.java Changeset: 006c683ead1a Author: ohair Date: 2011-01-05 14:28 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/006c683ead1a 6975326: Problem in install/make/rebase/Makefile, grep on empty pattern 6413588: Add 'ldd -r' and 'dump -Lv' checks to all .so files delivered in the JDK 7000995: Add check in makefiles to verify that msvcp100.dll is NOT used Reviewed-by: mduigou ! make/com/sun/java/pack/Makefile ! make/common/Demo.gmk ! make/common/Library.gmk ! make/common/Program.gmk ! make/common/Release.gmk ! make/common/shared/Compiler-msvc.gmk ! make/common/shared/Defs-linux.gmk ! make/common/shared/Defs-solaris.gmk ! make/common/shared/Defs-utils.gmk ! make/common/shared/Defs-windows.gmk ! make/common/shared/Sanity-Settings.gmk ! make/common/shared/Sanity.gmk ! make/java/redist/Makefile Changeset: 9576644931b2 Author: ohair Date: 2011-01-07 21:52 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/9576644931b2 6980024: Rebranding jre7/jdk7 License, Copyright, Readme 6912291: Third party license agreement should be present in all bundles Reviewed-by: katleman ! make/common/Modules.gmk ! make/common/Release.gmk ! make/common/shared/Defs-control.gmk Changeset: 8c3c6ac6fcdb Author: ohair Date: 2011-01-10 09:59 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/8c3c6ac6fcdb Merge Changeset: 658559ca4526 Author: ohair Date: 2011-01-10 17:00 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/658559ca4526 7011382: Fix use of VS100COMNTOOLS when installed in non-default or non-space path Reviewed-by: prr ! make/common/shared/Defs-windows.gmk Changeset: fd6319676bd3 Author: ohair Date: 2011-01-10 17:53 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/fd6319676bd3 Merge Changeset: 713d20f796c0 Author: ohair Date: 2011-01-10 18:07 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/713d20f796c0 6989472: Provide simple jdk identification information in the install image Reviewed-by: alanb ! make/common/Release.gmk ! make/common/shared/Defs-versions.gmk Changeset: 523386cfb731 Author: ohair Date: 2011-01-10 22:26 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/523386cfb731 Merge Changeset: 83cef4633684 Author: ohair Date: 2011-01-13 17:51 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/83cef4633684 Merge Changeset: 4241588a12c3 Author: ohair Date: 2011-01-13 13:49 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/4241588a12c3 7008047: remove sanity check of msival tool from JDK tree Reviewed-by: billyh ! make/common/shared/Defs-windows.gmk ! make/common/shared/Sanity-Settings.gmk ! make/common/shared/Sanity.gmk Changeset: 81e66ce6f501 Author: ohair Date: 2011-01-13 23:58 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/81e66ce6f501 Merge Changeset: 0c29bbd10e19 Author: ohair Date: 2011-01-14 14:04 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/0c29bbd10e19 6950375: Remove msvcrt.dll from the Windows JRE bundles Reviewed-by: prr ! make/Makefile ! make/common/Defs-windows.gmk ! make/common/shared/Defs-windows.gmk ! make/common/shared/Sanity-Settings.gmk ! make/common/shared/Sanity.gmk ! make/java/redist/Makefile ! make/jdk_generic_profile.sh ! src/share/demo/jvmti/index.html Changeset: 329f49ab5c4c Author: ohair Date: 2011-01-16 12:10 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/329f49ab5c4c Merge Changeset: 688f415db098 Author: ohair Date: 2011-01-26 16:05 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/688f415db098 Merge Changeset: aecb8f0eb83b Author: ohair Date: 2011-01-27 18:43 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/aecb8f0eb83b Merge Changeset: f08682e23279 Author: ohair Date: 2011-02-02 09:39 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/f08682e23279 Merge ! make/common/Defs-windows.gmk ! make/common/Demo.gmk ! make/common/Library.gmk ! make/common/Modules.gmk ! make/common/Program.gmk ! make/common/Release.gmk Changeset: 07c68a15ec79 Author: cl Date: 2011-02-03 17:22 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/07c68a15ec79 Added tag jdk7-b128 for changeset f08682e23279 ! .hgtags From bengt.rutisson at oracle.com Fri Feb 4 08:28:07 2011 From: bengt.rutisson at oracle.com (bengt.rutisson at oracle.com) Date: Fri, 04 Feb 2011 08:28:07 +0000 Subject: hg: jdk7/hotspot-gc/hotspot: 7015169: GC Cause not always set Message-ID: <20110204082811.1DB56473F5@hg.openjdk.java.net> Changeset: c798c277ddd1 Author: brutisso Date: 2011-02-03 20:49 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/c798c277ddd1 7015169: GC Cause not always set Summary: Sometimes the gc cause was not always set. This caused JStat to print the wrong information. Reviewed-by: tonyp, ysr Contributed-by: suenaga.yasumasa at oss.ntt.co.jp ! src/share/vm/gc_implementation/concurrentMarkSweep/vmCMSOperations.hpp ! src/share/vm/gc_implementation/g1/vm_operations_g1.hpp ! src/share/vm/gc_implementation/parallelScavenge/vmPSOperations.cpp ! src/share/vm/gc_implementation/shared/vmGCOperations.cpp ! src/share/vm/gc_implementation/shared/vmGCOperations.hpp ! src/share/vm/gc_interface/gcCause.cpp ! src/share/vm/gc_interface/gcCause.hpp ! src/share/vm/services/heapDumper.cpp From vladimir.kozlov at oracle.com Mon Feb 7 20:08:33 2011 From: vladimir.kozlov at oracle.com (Vladimir Kozlov) Date: Mon, 07 Feb 2011 12:08:33 -0800 Subject: Request for reviews (S): 7014874: Incorrect COOPs modes on solaris-{sparcv9, amd64} with ParallelGC In-Reply-To: <4D42F9D5.6060003@oracle.com> References: <4D41EF1D.502@oracle.com> <4D41F382.8060006@oracle.com> <4D41F67E.9060006@oracle.com> <4D41F8CB.5080107@oracle.com> <4D41FB4C.2040304@oracle.com> <4D42F9D5.6060003@oracle.com> Message-ID: <4D505141.1000304@oracle.com> Ramki, I looked more on this. Gen collectors align Young and Old gens sizes down. Look in collectorPolicy.cpp on methods initialize_flags(). They align up MaxHeapSize but if it is already specified with good rounding (as in my case) then it stays the same: set_max_heap_byte_size(align_size_up(MaxHeapSize, max_alignment())); G1 uses this size without any adjustment (G1CollectedHeap::initialize()): size_t max_byte_size = collector_policy()->max_heap_byte_size(); It seems, only Parallel GC modifies it. Thanks, Vladimir Y. Srinivas Ramakrishna wrote: > Hi Vladimir -- > > On 1/27/2011 3:10 PM, Vladimir Kozlov wrote: >> As Igor explained me only Parallel GC requires boundary >> page size alignment due to UseAdaptiveGCBoundary feature. > > Hmm, I do see a lot of "align_size_up()" done on max_size specs > in CollectedHeap::initialize_size_info() and friends, > as well as in GenerationSpec::align(). I didn't follow the > logic through to see if that will or will not affect the > whole heap sizing behaviour wrt the issue > reported in the CR. The bug report states the > anomalous behaviour with ParallelScavenge heaps, > Have you tested G1CollectedHeap and GenCollectedHeap > to see if they do the right thing? > > thanks. > -- ramki > >> >> Vladimir >> >> Y. S. Ramakrishna wrote: >>> May be you need a "partition_aligned()" method that >>> takes an aligned whole and produces aligned partitions >>> thereof given a desired_partitioning request. It would >>> seem as though similar logic would need to apply to >>> other kinds of heaps... or do they do the right thing >>> already? OK, i suppose i should go look, since i am >>> supposed to be reviewing, not interviewing ;-) >>> >>> -- ramki >>> >>> On 01/27/11 14:49, Vladimir Kozlov wrote: >>>> Before rounding YG+OG == total heap size. To keep the same >>>> total size I need to round one size up and the other down. >>>> I still may not preserver the same total size if it is not >>>> rounded to the same or large alignment. But it is fine. >>>> >>>> I already fixed PG rounding before in 6984368 changes: >>>> >>>> src/share/vm/memory/collectorPolicy.cpp Tue Sep 14 17:19:35 2010 -0700 >>>> @@ -32,7 +32,11 @@ >>>> MaxPermSize = PermSize; >>>> } >>>> PermSize = MAX2(min_alignment(), align_size_down_(PermSize, >>>> min_alignment())); >>>> - MaxPermSize = align_size_up(MaxPermSize, max_alignment()); >>>> + // Don't increase Perm size limit above specified. >>>> + MaxPermSize = align_size_down(MaxPermSize, max_alignment()); >>>> + if (PermSize > MaxPermSize) { >>>> + PermSize = MaxPermSize; >>>> + } >>>> >>>> Vladimir >>>> >>>> Y. S. Ramakrishna wrote: >>>>> I don't understand the logic of the patch. Or rather, i do, >>>>> but i question if it is complete: why didn't you also align >>>>> the max size of YG and PG down in like manner? I think you >>>>> should or you would be open to the same issues, no? >>>>> >>>>> In fact, it seems as though, as a matter of uniform policy, all min's >>>>> should align upwards and all max's align downwards wherever >>>>> (page-)alignment >>>>> is sought. >>>>> >>>>> -- ramki >>>>> >>>>> >>>>> On 01/27/11 14:18, Vladimir Kozlov wrote: >>>>>> http://cr.openjdk.java.net/~kvn/7014874/webrev >>>>>> >>>>>> Fixed 7014874: Incorrect COOPs modes on solaris-{sparcv9,amd64} >>>>>> with ParallelGC >>>>>> >>>>>> scale_by_NewRatio_aligned() aligns boundary between old >>>>>> and young gens to min_alignment() (64K). But code in >>>>>> ParallelScavengeHeap::initialize() aligns up both old and >>>>>> young gen sizes to large page size. >>>>>> As result total heap size could be increased by one large >>>>>> page and cross 4gb boundary preventing usage of 32-bit COOPs. >>>>>> >>>>>> Align old gen size down to keep specified heap size but >>>>>> not less than its old gen min size. > From y.s.ramakrishna at oracle.com Mon Feb 7 22:05:42 2011 From: y.s.ramakrishna at oracle.com (Y. Srinivas Ramakrishna) Date: Mon, 07 Feb 2011 14:05:42 -0800 Subject: gc logs [Full GC (System) In-Reply-To: References: Message-ID: <4D506CB6.8060203@oracle.com> Bheem -- On 2/7/2011 1:47 PM, bhm wrote: > please help me understand in following 2 line if > Full GC (System) > means this is caused due to System.gc() call ? Yes, the first "16.620: [Full GC" seems to be a full gc because the perm gen became full. The second "22.286: [Full GC (System)" seems to be one caused by an explicit System.gc() call. -- (rama)krishna > > 16.620: [Full GC 16.620: [CMS: 8849K->11102K(245760K), 0.9170804 secs] > 34309K->11102K(277440K), [CMS Perm : 27162K->26963K(27208K)], > 0.9180653 secs] [Times: user=0.91 sys=0.00, real=0.92 secs] > 22.286: [Full GC (System) 22.286: [CMS: 12805K->14033K(245760K), > 1.1113881 secs] 24546K->14033K(277440K), [CMS Perm : > 36005K->35855K(44944K)], 1.1217119 secs] [Times: user=1.12 sys=0.01, > real=1.12 secs] > > I couldnt find any explaination in following 2 links > http://www.sun.com/bigadmin/content/submitted/cms_gc_logs.jsp > http://www.oracle.com/technetwork/java/example-141412.html > > Thanks. > _______________________________________________ > hotspot-gc-use mailing list > hotspot-gc-use at openjdk.java.net > http://mail.openjdk.java.net/mailman/listinfo/hotspot-gc-use _______________________________________________ hotspot-gc-use mailing list hotspot-gc-use at openjdk.java.net http://mail.openjdk.java.net/mailman/listinfo/hotspot-gc-use From y.s.ramakrishna at oracle.com Mon Feb 7 22:23:00 2011 From: y.s.ramakrishna at oracle.com (Y. Srinivas Ramakrishna) Date: Mon, 07 Feb 2011 14:23:00 -0800 Subject: Request for reviews (S): 7014874: Incorrect COOPs modes on solaris-{sparcv9, amd64} with ParallelGC In-Reply-To: <4D505141.1000304@oracle.com> References: <4D41EF1D.502@oracle.com> <4D41F382.8060006@oracle.com> <4D41F67E.9060006@oracle.com> <4D41F8CB.5080107@oracle.com> <4D41FB4C.2040304@oracle.com> <4D42F9D5.6060003@oracle.com> <4D505141.1000304@oracle.com> Message-ID: <4D5070C4.2090803@oracle.com> Hi Vladimir, thanks for checking! On 2/7/2011 12:08 PM, Vladimir Kozlov wrote: > Ramki, > > I looked more on this. Gen collectors align Young and > Old gens sizes down. Look in collectorPolicy.cpp on methods > initialize_flags(). They align up MaxHeapSize but if it > is already specified with good rounding (as in my case) > then it stays the same: > > set_max_heap_byte_size(align_size_up(MaxHeapSize, max_alignment())); It would seem to me that this should be align_size_down() above for the case when it's not aligned and we want to stay within the band specified by [Min, Max]. But I understand that in yr case with an already aligned heap size spec this would not cause an issue. [The concern i was getting at comes up from time to time, but we have ended up patching over it in piecemeal fashion in the past; we should probably just consolidate this into one place and fix it, but that's a bigger, separate issue deserving its own CR, so should not block your fix here.] > > G1 uses this size without any adjustment (G1CollectedHeap::initialize()): > > size_t max_byte_size = collector_policy()->max_heap_byte_size(); That's good. > > It seems, only Parallel GC modifies it. Thanks for checking, and your change looks fine to me for addressing the immediate problem. Thumbs up from my side, and sorry for my nit-picking! :-) -- ramki > > Thanks, > Vladimir > > Y. Srinivas Ramakrishna wrote: >> Hi Vladimir -- >> >> On 1/27/2011 3:10 PM, Vladimir Kozlov wrote: >>> As Igor explained me only Parallel GC requires boundary >>> page size alignment due to UseAdaptiveGCBoundary feature. >> >> Hmm, I do see a lot of "align_size_up()" done on max_size specs >> in CollectedHeap::initialize_size_info() and friends, >> as well as in GenerationSpec::align(). I didn't follow the >> logic through to see if that will or will not affect the >> whole heap sizing behaviour wrt the issue >> reported in the CR. The bug report states the >> anomalous behaviour with ParallelScavenge heaps, >> Have you tested G1CollectedHeap and GenCollectedHeap >> to see if they do the right thing? >> >> thanks. >> -- ramki >> >>> >>> Vladimir >>> >>> Y. S. Ramakrishna wrote: >>>> May be you need a "partition_aligned()" method that >>>> takes an aligned whole and produces aligned partitions >>>> thereof given a desired_partitioning request. It would >>>> seem as though similar logic would need to apply to >>>> other kinds of heaps... or do they do the right thing >>>> already? OK, i suppose i should go look, since i am >>>> supposed to be reviewing, not interviewing ;-) >>>> >>>> -- ramki >>>> >>>> On 01/27/11 14:49, Vladimir Kozlov wrote: >>>>> Before rounding YG+OG == total heap size. To keep the same >>>>> total size I need to round one size up and the other down. >>>>> I still may not preserver the same total size if it is not >>>>> rounded to the same or large alignment. But it is fine. >>>>> >>>>> I already fixed PG rounding before in 6984368 changes: >>>>> >>>>> src/share/vm/memory/collectorPolicy.cpp Tue Sep 14 17:19:35 2010 -0700 >>>>> @@ -32,7 +32,11 @@ >>>>> MaxPermSize = PermSize; >>>>> } >>>>> PermSize = MAX2(min_alignment(), align_size_down_(PermSize, min_alignment())); >>>>> - MaxPermSize = align_size_up(MaxPermSize, max_alignment()); >>>>> + // Don't increase Perm size limit above specified. >>>>> + MaxPermSize = align_size_down(MaxPermSize, max_alignment()); >>>>> + if (PermSize > MaxPermSize) { >>>>> + PermSize = MaxPermSize; >>>>> + } >>>>> >>>>> Vladimir >>>>> >>>>> Y. S. Ramakrishna wrote: >>>>>> I don't understand the logic of the patch. Or rather, i do, >>>>>> but i question if it is complete: why didn't you also align >>>>>> the max size of YG and PG down in like manner? I think you >>>>>> should or you would be open to the same issues, no? >>>>>> >>>>>> In fact, it seems as though, as a matter of uniform policy, all min's >>>>>> should align upwards and all max's align downwards wherever (page-)alignment >>>>>> is sought. >>>>>> >>>>>> -- ramki >>>>>> >>>>>> >>>>>> On 01/27/11 14:18, Vladimir Kozlov wrote: >>>>>>> http://cr.openjdk.java.net/~kvn/7014874/webrev >>>>>>> >>>>>>> Fixed 7014874: Incorrect COOPs modes on solaris-{sparcv9,amd64} with ParallelGC >>>>>>> >>>>>>> scale_by_NewRatio_aligned() aligns boundary between old >>>>>>> and young gens to min_alignment() (64K). But code in >>>>>>> ParallelScavengeHeap::initialize() aligns up both old and >>>>>>> young gen sizes to large page size. >>>>>>> As result total heap size could be increased by one large >>>>>>> page and cross 4gb boundary preventing usage of 32-bit COOPs. >>>>>>> >>>>>>> Align old gen size down to keep specified heap size but >>>>>>> not less than its old gen min size. >> From y.s.ramakrishna at oracle.com Tue Feb 8 11:43:14 2011 From: y.s.ramakrishna at oracle.com (y.s.ramakrishna at oracle.com) Date: Tue, 08 Feb 2011 11:43:14 +0000 Subject: hg: jdk7/hotspot-gc/hotspot: 6912621: iCMS: Error: assert(_markBitMap.isMarked(addr + 1), "Missing Printezis bit?") Message-ID: <20110208114316.41E70474F2@hg.openjdk.java.net> Changeset: c5a923563727 Author: ysr Date: 2011-02-07 22:19 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/c5a923563727 6912621: iCMS: Error: assert(_markBitMap.isMarked(addr + 1),"Missing Printezis bit?") Summary: Fix block_size_if_printezis_bits() so it does not expect the bits, only uses them when available. Fix block_size_no_stall() so it does not stall when the bits are missing such cases, letting the caller deal with zero size returns. Constant pool cache oops do not need to be unparsable or conc_unsafe after their klass pointer is installed. Some cosmetic clean-ups and some assertion checking for conc-usafety which, in the presence of class file redefinition, has no a-priori time boundedness, so all GCs must be able to safely deal with putatively conc-unsafe objects in a stop-world pause. Reviewed-by: jmasa, johnc ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_interface/collectedHeap.cpp ! src/share/vm/interpreter/rewriter.cpp ! src/share/vm/memory/oopFactory.cpp ! src/share/vm/memory/oopFactory.hpp ! src/share/vm/oops/constantPoolKlass.cpp ! src/share/vm/oops/cpCacheKlass.cpp ! src/share/vm/oops/cpCacheKlass.hpp ! src/share/vm/oops/cpCacheOop.hpp ! src/share/vm/oops/methodOop.cpp ! src/share/vm/oops/methodOop.hpp ! src/share/vm/oops/oop.hpp ! src/share/vm/prims/jvmtiRedefineClasses.cpp ! src/share/vm/prims/methodHandleWalk.cpp From stefan.karlsson at oracle.com Tue Feb 8 13:46:35 2011 From: stefan.karlsson at oracle.com (stefan.karlsson at oracle.com) Date: Tue, 08 Feb 2011 13:46:35 +0000 Subject: hg: jdk7/hotspot-gc/hotspot: 7014851: Remove unused parallel compaction code Message-ID: <20110208134637.58891474F7@hg.openjdk.java.net> Changeset: e5383553fd4e Author: stefank Date: 2011-02-08 12:33 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/e5383553fd4e 7014851: Remove unused parallel compaction code Summary: Removed. Reviewed-by: jcoomes, brutisso ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.hpp ! src/share/vm/oops/arrayKlassKlass.cpp ! src/share/vm/oops/compiledICHolderKlass.cpp ! src/share/vm/oops/constMethodKlass.cpp ! src/share/vm/oops/constantPoolKlass.cpp ! src/share/vm/oops/cpCacheKlass.cpp ! src/share/vm/oops/cpCacheOop.cpp ! src/share/vm/oops/cpCacheOop.hpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/oops/instanceKlassKlass.cpp ! src/share/vm/oops/instanceRefKlass.cpp ! src/share/vm/oops/klassKlass.cpp ! src/share/vm/oops/klassPS.hpp ! src/share/vm/oops/klassVtable.cpp ! src/share/vm/oops/klassVtable.hpp ! src/share/vm/oops/methodDataKlass.cpp ! src/share/vm/oops/methodDataOop.cpp ! src/share/vm/oops/methodDataOop.hpp ! src/share/vm/oops/methodKlass.cpp ! src/share/vm/oops/objArrayKlass.cpp ! src/share/vm/oops/objArrayKlassKlass.cpp ! src/share/vm/oops/oop.hpp ! src/share/vm/oops/oop.pcgc.inline.hpp ! src/share/vm/oops/typeArrayKlass.cpp From john.cuthbertson at oracle.com Wed Feb 9 21:44:15 2011 From: john.cuthbertson at oracle.com (john.cuthbertson at oracle.com) Date: Wed, 09 Feb 2011 21:44:15 +0000 Subject: hg: jdk7/hotspot-gc/hotspot: 7017008: G1: Turn on compressed oops by default. Message-ID: <20110209214416.E12F247568@hg.openjdk.java.net> Changeset: 59e20a452a2a Author: johnc Date: 2011-02-09 09:43 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/59e20a452a2a 7017008: G1: Turn on compressed oops by default. Summary: Normally compressed oops is enabled when the maximum heap size is under a certain limit, except when G1 is also enabled. Remove this limitation. Also re-enable GCBasher testing with G1 on 64 bit windows in jprt. Reviewed-by: jcoomes, brutisso, tonyp ! make/jprt.properties ! src/share/vm/runtime/arguments.cpp From peter.schuller at infidyne.com Thu Feb 10 18:25:04 2011 From: peter.schuller at infidyne.com (Peter Schuller) Date: Thu, 10 Feb 2011 19:25:04 +0100 Subject: gc logs [Full GC (System) In-Reply-To: References: Message-ID: > please help me understand in following 2 line if > Full GC (System) > means this is caused due to System.gc() call ? If you're having trouble with code calling System.gc(), -XX:+DisableExplicitGC may be an option. But that will also disable e.g. jconsole triggered GC:s (I think). -- / Peter Schuller _______________________________________________ hotspot-gc-use mailing list hotspot-gc-use at openjdk.java.net http://mail.openjdk.java.net/mailman/listinfo/hotspot-gc-use From kirk.pepperdine at gmail.com Thu Feb 10 18:46:01 2011 From: kirk.pepperdine at gmail.com (Kirk) Date: Thu, 10 Feb 2011 19:46:01 +0100 Subject: gc logs [Full GC (System) In-Reply-To: References: Message-ID: sed also works well in getting rid of calls to System.gc()... and it guarantees that it won't accidentally show up again. Regards, Kirk On Feb 10, 2011, at 7:25 PM, Peter Schuller wrote: >> please help me understand in following 2 line if >> Full GC (System) >> means this is caused due to System.gc() call ? > > If you're having trouble with code calling System.gc(), > -XX:+DisableExplicitGC may be an option. But that will also disable > e.g. jconsole triggered GC:s (I think). > > -- > / Peter Schuller > _______________________________________________ > hotspot-gc-use mailing list > hotspot-gc-use at openjdk.java.net > http://mail.openjdk.java.net/mailman/listinfo/hotspot-gc-use _______________________________________________ hotspot-gc-use mailing list hotspot-gc-use at openjdk.java.net http://mail.openjdk.java.net/mailman/listinfo/hotspot-gc-use From y.s.ramakrishna at oracle.com Thu Feb 10 19:18:25 2011 From: y.s.ramakrishna at oracle.com (Y. S. Ramakrishna) Date: Thu, 10 Feb 2011 11:18:25 -0800 Subject: gc logs [Full GC (System) In-Reply-To: <4D54395B.5000507@oracle.com> References: <4D54395B.5000507@oracle.com> Message-ID: <4D543A01.4090706@oracle.com> Of course that also circumvents -XX:+ExplicitGCInvokesConcurrent. -- ramki On 02/10/11 11:15, Y. S. Ramakrishna wrote: > > > On 02/10/11 10:46, Kirk wrote: >> sed also works well in getting rid of calls to System.gc()... and it >> guarantees that it won't accidentally show up again. >> >> Regards, >> Kirk >> >> On Feb 10, 2011, at 7:25 PM, Peter Schuller wrote: >> >>>> please help me understand in following 2 line if >>>> Full GC (System) >>>> means this is caused due to System.gc() call ? >>> If you're having trouble with code calling System.gc(), >>> -XX:+DisableExplicitGC may be an option. But that will also disable >>> e.g. jconsole triggered GC:s (I think). > > a hack ;-) to cause an explicit gc even when it's disabled > via the above flag is to use jmap -histo:live on the JVM. > > -- ramki > _______________________________________________ hotspot-gc-use mailing list hotspot-gc-use at openjdk.java.net http://mail.openjdk.java.net/mailman/listinfo/hotspot-gc-use From y.s.ramakrishna at oracle.com Thu Feb 10 19:15:39 2011 From: y.s.ramakrishna at oracle.com (Y. S. Ramakrishna) Date: Thu, 10 Feb 2011 11:15:39 -0800 Subject: gc logs [Full GC (System) In-Reply-To: References: Message-ID: <4D54395B.5000507@oracle.com> On 02/10/11 10:46, Kirk wrote: > sed also works well in getting rid of calls to System.gc()... and it guarantees that it won't accidentally show up again. > > Regards, > Kirk > > On Feb 10, 2011, at 7:25 PM, Peter Schuller wrote: > >>> please help me understand in following 2 line if >>> Full GC (System) >>> means this is caused due to System.gc() call ? >> If you're having trouble with code calling System.gc(), >> -XX:+DisableExplicitGC may be an option. But that will also disable >> e.g. jconsole triggered GC:s (I think). a hack ;-) to cause an explicit gc even when it's disabled via the above flag is to use jmap -histo:live on the JVM. -- ramki _______________________________________________ hotspot-gc-use mailing list hotspot-gc-use at openjdk.java.net http://mail.openjdk.java.net/mailman/listinfo/hotspot-gc-use From y.s.ramakrishna at oracle.com Fri Feb 11 02:39:54 2011 From: y.s.ramakrishna at oracle.com (y.s.ramakrishna at oracle.com) Date: Fri, 11 Feb 2011 02:39:54 +0000 Subject: hg: jdk7/hotspot-gc/hotspot: 7018302: newly added assert related to size of constantPoolOop causes secondary assertions or crashes Message-ID: <20110211023955.DE75A4762B@hg.openjdk.java.net> Changeset: 183658a2d0b3 Author: ysr Date: 2011-02-10 14:48 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/183658a2d0b3 7018302: newly added assert related to size of constantPoolOop causes secondary assertions or crashes Summary: 6912621 used a raw oop in the newly added assert following an allocation attempt that could result in a GC. Reviewed-by: jmasa ! src/share/vm/oops/constantPoolKlass.cpp From john.coomes at oracle.com Fri Feb 11 04:57:23 2011 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 11 Feb 2011 04:57:23 +0000 Subject: hg: jdk7/hotspot-gc: 4 new changesets Message-ID: <20110211045724.1BE424763E@hg.openjdk.java.net> Changeset: ce02c0d73d6a Author: ohair Date: 2011-02-03 15:10 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/rev/ce02c0d73d6a 7014634: By default, only build the product bits with a closed jdk build (like openjdk does) Reviewed-by: katleman, cl, igor, trims ! make/Defs-internal.gmk Changeset: e2a214ec8ebc Author: ohair Date: 2011-02-04 07:47 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/rev/e2a214ec8ebc Merge Changeset: a6b015b59fbc Author: ohair Date: 2011-02-08 16:28 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/rev/a6b015b59fbc 7016976: Documentation for required ant version on JDK7 builds on Solaris 10 and Solaris 11 Reviewed-by: rinaldo ! README-builds.html Changeset: cc58c11af154 Author: cl Date: 2011-02-10 16:24 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/rev/cc58c11af154 Added tag jdk7-b129 for changeset a6b015b59fbc ! .hgtags From john.coomes at oracle.com Fri Feb 11 04:57:31 2011 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 11 Feb 2011 04:57:31 +0000 Subject: hg: jdk7/hotspot-gc/corba: 3 new changesets Message-ID: <20110211045737.3ABE94763F@hg.openjdk.java.net> Changeset: 6a3903e5b6cc Author: ohair Date: 2011-02-03 15:05 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/corba/rev/6a3903e5b6cc 6944304: Potential rebranding issues in the openjdk7/corba sources Reviewed-by: alanb, mchung, darcy ! src/share/classes/com/sun/corba/se/spi/logging/data/Activation.mc ! src/share/classes/com/sun/corba/se/spi/logging/data/IOR.mc ! src/share/classes/com/sun/corba/se/spi/logging/data/Interceptors.mc ! src/share/classes/com/sun/corba/se/spi/logging/data/Naming.mc ! src/share/classes/com/sun/corba/se/spi/logging/data/OMG.mc ! src/share/classes/com/sun/corba/se/spi/logging/data/ORBUtil.mc ! src/share/classes/com/sun/corba/se/spi/logging/data/POA.mc ! src/share/classes/com/sun/corba/se/spi/logging/data/Util.mc Changeset: 66fa0fcc7792 Author: ohair Date: 2011-02-04 07:47 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/corba/rev/66fa0fcc7792 Merge Changeset: 4cdf9b86f550 Author: cl Date: 2011-02-10 16:24 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/corba/rev/4cdf9b86f550 Added tag jdk7-b129 for changeset 66fa0fcc7792 ! .hgtags From john.coomes at oracle.com Fri Feb 11 04:57:46 2011 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 11 Feb 2011 04:57:46 +0000 Subject: hg: jdk7/hotspot-gc/jaxp: Added tag jdk7-b129 for changeset f5b60c5a310f Message-ID: <20110211045746.74AB747640@hg.openjdk.java.net> Changeset: ab107c1bc4b9 Author: cl Date: 2011-02-10 16:24 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jaxp/rev/ab107c1bc4b9 Added tag jdk7-b129 for changeset f5b60c5a310f ! .hgtags From john.coomes at oracle.com Fri Feb 11 04:57:53 2011 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 11 Feb 2011 04:57:53 +0000 Subject: hg: jdk7/hotspot-gc/jaxws: Added tag jdk7-b129 for changeset 0f7b39ad9024 Message-ID: <20110211045753.F2CE147641@hg.openjdk.java.net> Changeset: ba1fac1c2083 Author: cl Date: 2011-02-10 16:24 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jaxws/rev/ba1fac1c2083 Added tag jdk7-b129 for changeset 0f7b39ad9024 ! .hgtags From john.coomes at oracle.com Fri Feb 11 04:58:06 2011 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 11 Feb 2011 04:58:06 +0000 Subject: hg: jdk7/hotspot-gc/jdk: 5 new changesets Message-ID: <20110211045929.8F80747642@hg.openjdk.java.net> Changeset: 001dcfd0be4b Author: ohair Date: 2011-02-08 16:30 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/001dcfd0be4b 7016976: Documentation for required ant version on JDK7 builds on Solaris 10 and Solaris 11 Reviewed-by: rinaldo ! make/common/shared/Defs-versions.gmk ! make/common/shared/Sanity.gmk Changeset: 1f056ddda771 Author: ohair Date: 2011-01-28 14:32 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/1f056ddda771 7014301: Change make 3.81 sanity check to a fatal, 3.81 is needed now Reviewed-by: alanb ! make/common/shared/Sanity.gmk Changeset: 3f77dae85c85 Author: ohair Date: 2011-02-08 13:06 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/3f77dae85c85 Merge Changeset: 14cd5d54a8d0 Author: ohair Date: 2011-02-08 20:00 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/14cd5d54a8d0 Merge ! make/common/shared/Sanity.gmk Changeset: 326aac19a89f Author: cl Date: 2011-02-10 16:24 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/326aac19a89f Added tag jdk7-b129 for changeset 14cd5d54a8d0 ! .hgtags From john.coomes at oracle.com Fri Feb 11 04:59:46 2011 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 11 Feb 2011 04:59:46 +0000 Subject: hg: jdk7/hotspot-gc/langtools: 22 new changesets Message-ID: <20110211050032.C117547643@hg.openjdk.java.net> Changeset: d17f37522154 Author: jjg Date: 2011-01-10 14:57 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/d17f37522154 6992999: fully remove JSR 308 from langtools Reviewed-by: mcimadamore ! src/share/classes/com/sun/source/tree/MethodTree.java ! src/share/classes/com/sun/source/tree/Tree.java ! src/share/classes/com/sun/source/tree/TreeVisitor.java ! src/share/classes/com/sun/source/tree/TypeParameterTree.java ! src/share/classes/com/sun/source/util/SimpleTreeVisitor.java ! src/share/classes/com/sun/source/util/TreeScanner.java ! src/share/classes/com/sun/tools/classfile/Attribute.java ! src/share/classes/com/sun/tools/classfile/ClassWriter.java - src/share/classes/com/sun/tools/classfile/ExtendedAnnotation.java - src/share/classes/com/sun/tools/classfile/RuntimeInvisibleTypeAnnotations_attribute.java - src/share/classes/com/sun/tools/classfile/RuntimeTypeAnnotations_attribute.java - src/share/classes/com/sun/tools/classfile/RuntimeVisibleTypeAnnotations_attribute.java ! src/share/classes/com/sun/tools/javac/code/Attribute.java ! src/share/classes/com/sun/tools/javac/code/Symbol.java - src/share/classes/com/sun/tools/javac/code/TypeAnnotations.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/Flow.java ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/comp/TransTypes.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/share/classes/com/sun/tools/javac/jvm/Code.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/tree/JCTree.java ! src/share/classes/com/sun/tools/javac/tree/Pretty.java ! src/share/classes/com/sun/tools/javac/tree/TreeCopier.java ! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java ! src/share/classes/com/sun/tools/javac/tree/TreeMaker.java ! src/share/classes/com/sun/tools/javac/tree/TreeScanner.java ! src/share/classes/com/sun/tools/javac/tree/TreeTranslator.java ! src/share/classes/com/sun/tools/javap/AnnotationWriter.java ! src/share/classes/com/sun/tools/javap/AttributeWriter.java ! src/share/classes/com/sun/tools/javap/CodeWriter.java ! src/share/classes/com/sun/tools/javap/InstructionDetailWriter.java - src/share/classes/com/sun/tools/javap/TypeAnnotationWriter.java ! test/tools/javac/diags/examples.not-yet.txt Changeset: 7c537f4298fb Author: jjg Date: 2011-01-10 15:08 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/7c537f4298fb 6396503: javac should not require assertions enabled Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/Main.java ! src/share/classes/com/sun/tools/javac/code/Attribute.java ! src/share/classes/com/sun/tools/javac/code/Scope.java ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/Flow.java ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/comp/TransTypes.java ! src/share/classes/com/sun/tools/javac/file/ZipFileIndexArchive.java ! src/share/classes/com/sun/tools/javac/jvm/CRTable.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/share/classes/com/sun/tools/javac/jvm/Code.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java ! src/share/classes/com/sun/tools/javac/jvm/Items.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/parser/Scanner.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! src/share/classes/com/sun/tools/javac/tree/JCTree.java ! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java ! src/share/classes/com/sun/tools/javac/tree/TreeMaker.java ! src/share/classes/com/sun/tools/javac/tree/TreeScanner.java ! src/share/classes/com/sun/tools/javac/util/AbstractDiagnosticFormatter.java + src/share/classes/com/sun/tools/javac/util/Assert.java ! src/share/classes/com/sun/tools/javac/util/Bits.java ! src/share/classes/com/sun/tools/javac/util/Context.java ! src/share/classes/com/sun/tools/javac/util/List.java ! src/share/classes/com/sun/tools/javac/util/UnsharedNameTable.java ! src/share/classes/javax/tools/ToolProvider.java Changeset: 17b271281525 Author: jjg Date: 2011-01-11 08:05 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/17b271281525 6993305: starting position of a method without modifiers and with type parameters is incorrect Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java + test/tools/javac/tree/T6993305.java Changeset: d33d8c381aa1 Author: jjg Date: 2011-01-13 11:48 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/d33d8c381aa1 6430241: Hard to disable symbol file feature through API Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/file/JavacFileManager.java ! src/share/classes/com/sun/tools/javac/file/Paths.java + test/tools/javac/api/T6430241.java Changeset: a466f00c5cd2 Author: bpatel Date: 2011-01-13 21:28 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/a466f00c5cd2 7010528: javadoc performance regression Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlTree.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/Content.java Changeset: 2d5aff89aaa3 Author: mcimadamore Date: 2011-01-14 09:45 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/2d5aff89aaa3 6992698: JSR 292: remove support for transient syntax in polymorphic signature calls Summary: special syntax to denote indy return type through type parameters should be removed (and cast shall be used instead) Reviewed-by: jjg, jrose ! src/share/classes/com/sun/tools/javac/code/Symtab.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Flow.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java ! src/share/classes/com/sun/tools/javac/jvm/Items.java ! src/share/classes/com/sun/tools/javac/main/Main.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/util/Names.java - test/tools/javac/diags/examples/TypeParameterOnPolymorphicSignature.java - test/tools/javac/meth/InvokeDynTrans.out - test/tools/javac/meth/InvokeMHTrans.java - test/tools/javac/meth/InvokeMHTrans.out ! test/tools/javac/meth/TestCP.java ! test/tools/javac/meth/XlintWarn.java Changeset: c8d312dd17bc Author: mcimadamore Date: 2011-01-14 09:45 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/c8d312dd17bc 7007432: Test generic types well-formedness Summary: add a new kind of check (well-formedness of generic type w.r.t. declared bounds) in the type-harness Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Check.java + test/tools/javac/types/GenericTypeWellFormednessTest.java ! test/tools/javac/types/TypeHarness.java Changeset: 712be35e40b5 Author: mcimadamore Date: 2011-01-14 09:46 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/712be35e40b5 6949040: java.dyn package must be compiled with -target 7 or better Summary: issue error (rather than warning) when @PolymorphicSignature is found and target < 7 Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! test/tools/javac/diags/examples.not-yet.txt Changeset: 7c7c1787fbbe Author: jjg Date: 2011-01-14 11:45 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/7c7c1787fbbe 6419926: JSR 199: FileObject.toUri() generates URI without schema (Solaris) Reviewed-by: mcimadamore + test/tools/javac/api/T6419926.java Changeset: 0a509c765657 Author: jjg Date: 2011-01-14 11:55 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/0a509c765657 6571165: Minor doc bugs in JavaCompiler.java Reviewed-by: mcimadamore ! src/share/classes/javax/tools/JavaCompiler.java Changeset: 19f9b6548c70 Author: ksrini Date: 2011-01-14 13:59 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/19f9b6548c70 7011272: langtools build.xml should provide a patch target Reviewed-by: jonathan, jjh ! make/build.xml Changeset: 5cf6c432ef2f Author: ksrini Date: 2011-01-18 08:37 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/5cf6c432ef2f 6982999: tools must support -target 7 bytecodes Reviewed-by: jjg, jrose ! src/share/classes/com/sun/tools/classfile/Attribute.java + src/share/classes/com/sun/tools/classfile/BootstrapMethods_attribute.java ! src/share/classes/com/sun/tools/classfile/ClassTranslator.java ! src/share/classes/com/sun/tools/classfile/ClassWriter.java ! src/share/classes/com/sun/tools/classfile/ConstantPool.java ! src/share/classes/com/sun/tools/classfile/Dependencies.java ! src/share/classes/com/sun/tools/javac/jvm/ClassFile.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javap/AttributeWriter.java ! src/share/classes/com/sun/tools/javap/ConstantWriter.java Changeset: b6f95173e769 Author: lana Date: 2011-01-19 19:01 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/b6f95173e769 Merge Changeset: 19c900c703c6 Author: mcimadamore Date: 2011-01-24 15:44 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/19c900c703c6 6943278: spurious error message for inference and type-variable with erroneous bound Summary: type-inference should ignore erroneous bounds Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java + test/tools/javac/generics/inference/6943278/T6943278.java + test/tools/javac/generics/inference/6943278/T6943278.out Changeset: ce6175cfe11e Author: mcimadamore Date: 2011-01-24 15:44 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/ce6175cfe11e 6968793: issues with diagnostics Summary: several diagnostic improvements Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! test/tools/javac/6304921/T6304921.out ! test/tools/javac/6330920/T6330920.out ! test/tools/javac/6717241/T6717241a.out ! test/tools/javac/6717241/T6717241b.out ! test/tools/javac/6857948/T6857948.out ! test/tools/javac/6863465/T6863465c.out ! test/tools/javac/6863465/T6863465d.out ! test/tools/javac/T6247324.out ! test/tools/javac/TryWithResources/ResourceOutsideTry.out ! test/tools/javac/diags/examples.not-yet.txt ! test/tools/javac/diags/examples/CantResolve.java ! test/tools/javac/diags/examples/CantResolveArgsParams.java ! test/tools/javac/diags/examples/CantResolveLocation.java ! test/tools/javac/diags/examples/CantResolveLocationArgs.java ! test/tools/javac/diags/examples/CantResolveLocationArgsParams.java - test/tools/javac/diags/examples/EnumConstRequired.java ! test/tools/javac/diags/examples/ForeachNotApplicable.java ! test/tools/javac/diags/examples/KindnameClass.java ! test/tools/javac/diags/examples/KindnameMethod.java ! test/tools/javac/diags/examples/KindnameVariable.java + test/tools/javac/diags/examples/Location.java + test/tools/javac/diags/examples/Location1.java ! test/tools/javac/diags/examples/OperatorCantBeApplied.java + test/tools/javac/diags/examples/OperatorCantBeApplied1.java ! test/tools/javac/diags/examples/StaticImportOnlyClassesAndInterfaces/StaticImportOnlyClassesAndInterfaces.java ! test/tools/javac/failover/FailOver01.out ! test/tools/javac/failover/FailOver02.out ! test/tools/javac/failover/FailOver04.out ! test/tools/javac/generics/6711619/T6711619a.out ! test/tools/javac/generics/diamond/neg/Neg01.out ! test/tools/javac/generics/diamond/neg/Neg02.out ! test/tools/javac/generics/diamond/neg/Neg03.out ! test/tools/javac/generics/diamond/neg/Neg04.out ! test/tools/javac/generics/diamond/neg/Neg11.out ! test/tools/javac/generics/inference/6943278/T6943278.out ! test/tools/javac/generics/typevars/5060485/Compatibility.out ! test/tools/javac/generics/typevars/5060485/Compatibility02.out + test/tools/javac/generics/typevars/6968793/T6968793.java + test/tools/javac/generics/typevars/6968793/T6968793.out ! test/tools/javac/policy/test1/byfile.ABD.out ! test/tools/javac/policy/test1/bytodo.ABD.out ! test/tools/javac/policy/test1/simple.ABD.out Changeset: 02e6e7dd1a64 Author: mcimadamore Date: 2011-01-24 15:45 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/02e6e7dd1a64 6510286: Wording of javac error for inner classes Summary: 'inner classes cannot have static declarations' message needs to be reworked Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! test/tools/javac/InnerNamedConstant_2.out Changeset: 812c6251ea78 Author: mcimadamore Date: 2011-01-24 15:45 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/812c6251ea78 6569633: Varargs: parser error when varargs element type is an array Summary: explicit error message when old-style array syntax is mixed with varargs Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties + test/tools/javac/diags/examples/VarargsAndOldArraySyntax.java + test/tools/javac/varargs/6569633/T6569633.java + test/tools/javac/varargs/6569633/T6569633.out Changeset: 57e3b9bc7fb8 Author: mcimadamore Date: 2011-01-24 15:45 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/57e3b9bc7fb8 7013865: varargs: javac crashes during overload resolution with generic varargs Summary: fixed regression with varargs overload resolution that leads javac to crash Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Infer.java + test/tools/javac/varargs/T7013865.java Changeset: 2314f2b07ae7 Author: lana Date: 2011-01-24 13:25 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/2314f2b07ae7 Merge - src/share/classes/com/sun/tools/classfile/ExtendedAnnotation.java - src/share/classes/com/sun/tools/classfile/RuntimeInvisibleTypeAnnotations_attribute.java - src/share/classes/com/sun/tools/classfile/RuntimeTypeAnnotations_attribute.java - src/share/classes/com/sun/tools/classfile/RuntimeVisibleTypeAnnotations_attribute.java - src/share/classes/com/sun/tools/javac/code/TypeAnnotations.java - src/share/classes/com/sun/tools/javap/TypeAnnotationWriter.java - test/tools/javac/diags/examples/EnumConstRequired.java - test/tools/javac/diags/examples/TypeParameterOnPolymorphicSignature.java - test/tools/javac/meth/InvokeDynTrans.out - test/tools/javac/meth/InvokeMHTrans.java - test/tools/javac/meth/InvokeMHTrans.out Changeset: d7225b476a5d Author: lana Date: 2011-01-28 10:06 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/d7225b476a5d Merge - src/share/classes/com/sun/tools/classfile/ExtendedAnnotation.java - src/share/classes/com/sun/tools/classfile/RuntimeInvisibleTypeAnnotations_attribute.java - src/share/classes/com/sun/tools/classfile/RuntimeTypeAnnotations_attribute.java - src/share/classes/com/sun/tools/classfile/RuntimeVisibleTypeAnnotations_attribute.java - src/share/classes/com/sun/tools/javac/code/TypeAnnotations.java - src/share/classes/com/sun/tools/javap/TypeAnnotationWriter.java - test/tools/javac/diags/examples/EnumConstRequired.java - test/tools/javac/diags/examples/TypeParameterOnPolymorphicSignature.java - test/tools/javac/meth/InvokeDynTrans.out - test/tools/javac/meth/InvokeMHTrans.java - test/tools/javac/meth/InvokeMHTrans.out Changeset: 1383d1ee8b5d Author: cl Date: 2011-02-03 17:22 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/1383d1ee8b5d Added tag jdk7-b128 for changeset d7225b476a5d ! .hgtags Changeset: 03e7fc380090 Author: cl Date: 2011-02-10 16:24 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/03e7fc380090 Added tag jdk7-b129 for changeset 1383d1ee8b5d ! .hgtags From stefan.karlsson at oracle.com Fri Feb 11 15:21:38 2011 From: stefan.karlsson at oracle.com (stefan.karlsson at oracle.com) Date: Fri, 11 Feb 2011 15:21:38 +0000 Subject: hg: jdk7/hotspot-gc/hotspot: 7018257: jmm_DumpThreads allocates into permgen Message-ID: <20110211152142.D7AFA4766F@hg.openjdk.java.net> Changeset: 55cc33cf55bc Author: stefank Date: 2011-02-11 14:15 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/55cc33cf55bc 7018257: jmm_DumpThreads allocates into permgen Summary: Don't allocate in permgen Reviewed-by: ysr, sla ! src/share/vm/memory/oopFactory.cpp ! src/share/vm/memory/oopFactory.hpp ! src/share/vm/services/management.cpp From tony.printezis at oracle.com Tue Feb 15 10:17:21 2011 From: tony.printezis at oracle.com (tony.printezis at oracle.com) Date: Tue, 15 Feb 2011 10:17:21 +0000 Subject: hg: jdk7/hotspot-gc/hotspot: 26 new changesets Message-ID: <20110215101817.1663247763@hg.openjdk.java.net> Changeset: 907c1aed0f8c Author: cl Date: 2011-01-27 17:28 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/907c1aed0f8c Added tag jdk7-b127 for changeset 102466e70deb ! .hgtags Changeset: 9a5762f44859 Author: trims Date: 2011-02-01 18:57 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/9a5762f44859 Merge ! .hgtags - src/share/vm/gc_implementation/g1/concurrentZFThread.cpp - src/share/vm/gc_implementation/g1/concurrentZFThread.hpp Changeset: 6ecdca5709df Author: cl Date: 2011-02-03 17:22 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/6ecdca5709df Added tag jdk7-b128 for changeset 9a5762f44859 ! .hgtags Changeset: ae4b185f2ed1 Author: trims Date: 2011-02-03 23:26 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/ae4b185f2ed1 Merge ! .hgtags - agent/src/share/classes/sun/jvm/hotspot/oops/SymbolKlass.java - src/share/vm/ci/ciSymbolKlass.cpp - src/share/vm/ci/ciSymbolKlass.hpp - src/share/vm/oops/symbolKlass.cpp - src/share/vm/oops/symbolKlass.hpp - src/share/vm/oops/symbolOop.cpp - src/share/vm/oops/symbolOop.hpp Changeset: c6bf3ca2bb31 Author: trims Date: 2011-02-04 16:29 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/c6bf3ca2bb31 Merge Changeset: d70fe6ab4436 Author: coleenp Date: 2011-02-01 11:23 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/d70fe6ab4436 6588413: Use -fvisibility=hidden for gcc compiles Summary: Add option for gcc 4 and above, define JNIEXPORT and JNIIMPORT to visibility=default, add for jio_snprintf and others since -fvisibility=hidden overrides --version-script definitions. Reviewed-by: kamg, never ! make/linux/makefiles/gcc.make ! make/linux/makefiles/mapfile-vers-debug ! make/linux/makefiles/mapfile-vers-product ! src/cpu/sparc/vm/jni_sparc.h ! src/cpu/x86/vm/jni_x86.h ! src/cpu/zero/vm/jni_zero.h ! src/os/linux/vm/jvm_linux.cpp ! src/os/linux/vm/os_linux.cpp ! src/os/solaris/vm/os_solaris.cpp ! src/os_cpu/linux_sparc/vm/os_linux_sparc.cpp ! src/os_cpu/linux_x86/vm/os_linux_x86.cpp ! src/os_cpu/linux_zero/vm/os_linux_zero.cpp ! src/os_cpu/solaris_sparc/vm/os_solaris_sparc.cpp ! src/os_cpu/solaris_x86/vm/os_solaris_x86.cpp ! src/share/vm/prims/forte.cpp ! src/share/vm/prims/jvm.cpp ! src/share/vm/prims/jvm.h Changeset: b92c45f2bc75 Author: bobv Date: 2011-02-02 11:35 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/b92c45f2bc75 7016023: Enable building ARM and PPC from src/closed repository Reviewed-by: dholmes, bdelsart ! make/Makefile + make/closed.make ! make/jprt.properties ! make/linux/Makefile ! make/linux/makefiles/adlc.make + make/linux/makefiles/arm.make ! make/linux/makefiles/buildtree.make + make/linux/makefiles/ppc.make ! make/linux/makefiles/rules.make ! make/linux/makefiles/top.make ! make/linux/makefiles/vm.make + make/linux/platform_arm + make/linux/platform_ppc ! src/os/linux/vm/osThread_linux.cpp ! src/os/linux/vm/os_linux.cpp ! src/os/linux/vm/os_linux.inline.hpp ! src/os/linux/vm/thread_linux.inline.hpp ! src/share/vm/asm/assembler.cpp ! src/share/vm/asm/assembler.hpp ! src/share/vm/asm/codeBuffer.hpp ! src/share/vm/c1/c1_Defs.hpp ! src/share/vm/c1/c1_FpuStackSim.hpp ! src/share/vm/c1/c1_FrameMap.cpp ! src/share/vm/c1/c1_FrameMap.hpp ! src/share/vm/c1/c1_Instruction.hpp ! src/share/vm/c1/c1_LIRAssembler.cpp ! src/share/vm/c1/c1_LIRAssembler.hpp ! src/share/vm/c1/c1_LinearScan.cpp ! src/share/vm/c1/c1_LinearScan.hpp ! src/share/vm/c1/c1_MacroAssembler.hpp ! src/share/vm/c1/c1_globals.hpp ! src/share/vm/classfile/classFileStream.hpp ! src/share/vm/classfile/stackMapTable.hpp ! src/share/vm/classfile/verifier.cpp ! src/share/vm/code/codeBlob.cpp ! src/share/vm/code/compiledIC.hpp ! src/share/vm/code/icBuffer.cpp ! src/share/vm/code/relocInfo.cpp ! src/share/vm/code/relocInfo.hpp ! src/share/vm/code/vmreg.hpp ! src/share/vm/compiler/disassembler.cpp ! src/share/vm/compiler/disassembler.hpp ! src/share/vm/interpreter/abstractInterpreter.hpp ! src/share/vm/interpreter/bytecode.hpp ! src/share/vm/interpreter/bytecodeInterpreter.cpp ! src/share/vm/interpreter/bytecodeInterpreter.hpp ! src/share/vm/interpreter/bytecodeInterpreter.inline.hpp ! src/share/vm/interpreter/bytecodeStream.hpp ! src/share/vm/interpreter/bytecodes.cpp ! src/share/vm/interpreter/bytecodes.hpp ! src/share/vm/interpreter/cppInterpreter.hpp ! src/share/vm/interpreter/cppInterpreterGenerator.hpp ! src/share/vm/interpreter/interpreter.hpp ! src/share/vm/interpreter/interpreterGenerator.hpp ! src/share/vm/interpreter/interpreterRuntime.cpp ! src/share/vm/interpreter/interpreterRuntime.hpp ! src/share/vm/interpreter/templateInterpreter.hpp ! src/share/vm/interpreter/templateInterpreterGenerator.hpp ! src/share/vm/interpreter/templateTable.hpp ! src/share/vm/oops/constantPoolOop.hpp ! src/share/vm/oops/oop.inline.hpp ! src/share/vm/oops/typeArrayOop.hpp ! src/share/vm/opto/buildOopMap.cpp ! src/share/vm/opto/c2_globals.hpp ! src/share/vm/opto/c2compiler.cpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/gcm.cpp ! src/share/vm/opto/locknode.hpp ! src/share/vm/opto/output.hpp ! src/share/vm/opto/regmask.cpp ! src/share/vm/opto/regmask.hpp ! src/share/vm/opto/runtime.cpp ! src/share/vm/prims/jniCheck.cpp ! src/share/vm/prims/jni_md.h ! src/share/vm/prims/jvmtiClassFileReconstituter.cpp ! src/share/vm/runtime/deoptimization.cpp ! src/share/vm/runtime/dtraceJSDT.hpp ! src/share/vm/runtime/frame.cpp ! src/share/vm/runtime/frame.hpp ! src/share/vm/runtime/frame.inline.hpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/icache.hpp ! src/share/vm/runtime/java.cpp ! src/share/vm/runtime/javaCalls.hpp ! src/share/vm/runtime/javaFrameAnchor.hpp ! src/share/vm/runtime/os.hpp ! src/share/vm/runtime/registerMap.hpp ! src/share/vm/runtime/relocator.hpp ! src/share/vm/runtime/safepoint.cpp ! src/share/vm/runtime/sharedRuntime.cpp ! src/share/vm/runtime/stackValueCollection.cpp ! src/share/vm/runtime/statSampler.cpp ! src/share/vm/runtime/stubCodeGenerator.cpp ! src/share/vm/runtime/stubRoutines.hpp ! src/share/vm/runtime/thread.hpp ! src/share/vm/runtime/threadLocalStorage.hpp ! src/share/vm/runtime/vmStructs.cpp ! src/share/vm/runtime/vm_version.cpp ! src/share/vm/utilities/copy.hpp ! src/share/vm/utilities/globalDefinitions.hpp ! src/share/vm/utilities/taskqueue.hpp Changeset: 9cd8a2c2d584 Author: bobv Date: 2011-02-02 11:54 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/9cd8a2c2d584 Merge ! src/os/linux/vm/os_linux.cpp Changeset: face83fc8882 Author: coleenp Date: 2011-02-02 18:38 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/face83fc8882 7012088: jump to 0 address because of lack of memory ordering in SignatureHandlerLibrary::add Summary: Write method signature handler under lock to prevent race with growable array resizing Reviewed-by: dsamersoff, dholmes ! src/share/vm/interpreter/interpreterRuntime.cpp Changeset: bf8517f4e4d0 Author: kamg Date: 2011-02-02 14:38 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/bf8517f4e4d0 6766644: Redefinition of compiled method fails with assertion "Can not load classes with the Compiler thread" Summary: Defer posting events from the compiler thread: use service thread Reviewed-by: coleenp, dholmes, never, dcubed - agent/src/share/classes/sun/jvm/hotspot/runtime/LowMemoryDetectorThread.java + agent/src/share/classes/sun/jvm/hotspot/runtime/ServiceThread.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/Thread.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/Threads.java ! src/share/vm/code/nmethod.cpp ! src/share/vm/code/nmethod.hpp ! src/share/vm/prims/jvmtiExport.cpp ! src/share/vm/prims/jvmtiExport.hpp ! src/share/vm/prims/jvmtiImpl.cpp ! src/share/vm/prims/jvmtiImpl.hpp ! src/share/vm/runtime/fprofiler.hpp ! src/share/vm/runtime/mutexLocker.cpp ! src/share/vm/runtime/mutexLocker.hpp + src/share/vm/runtime/serviceThread.cpp + src/share/vm/runtime/serviceThread.hpp ! src/share/vm/runtime/thread.hpp ! src/share/vm/runtime/vmStructs.cpp ! src/share/vm/services/attachListener.hpp ! src/share/vm/services/lowMemoryDetector.cpp ! src/share/vm/services/lowMemoryDetector.hpp ! src/share/vm/services/management.cpp ! src/share/vm/utilities/macros.hpp Changeset: d28def44457d Author: coleenp Date: 2011-02-03 21:30 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/d28def44457d 7017009: Secondary out of c-heap memory error reporting out of memory Summary: Use os::malloc() to allocate buffer to read elf symbols and check for null Reviewed-by: zgu, phh, dsamersoff, dholmes, dcubed ! src/share/vm/utilities/elfSymbolTable.cpp Changeset: 5e139f767ddb Author: coleenp Date: 2011-02-03 20:30 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/5e139f767ddb Merge - agent/src/share/classes/sun/jvm/hotspot/runtime/LowMemoryDetectorThread.java Changeset: e9f24eebafd4 Author: rottenha Date: 2011-02-07 08:40 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/e9f24eebafd4 Merge - agent/src/share/classes/sun/jvm/hotspot/runtime/LowMemoryDetectorThread.java Changeset: d8a72fbc4be7 Author: kamg Date: 2011-02-08 17:20 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/d8a72fbc4be7 7003401: Implement VM error-reporting functionality on erroneous termination Summary: Add support for distribution-specific error reporting Reviewed-by: coleenp, phh, jcoomes, ohair ! make/Makefile + make/altsrc.make - make/closed.make ! make/linux/makefiles/adlc.make ! make/linux/makefiles/buildtree.make ! make/linux/makefiles/rules.make ! make/linux/makefiles/top.make ! make/linux/makefiles/vm.make ! make/solaris/makefiles/adlc.make ! make/solaris/makefiles/buildtree.make ! make/solaris/makefiles/rules.make ! make/solaris/makefiles/top.make ! make/solaris/makefiles/vm.make ! make/windows/create_obj_files.sh ! make/windows/makefiles/vm.make ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/vm_version.cpp ! src/share/vm/runtime/vm_version.hpp + src/share/vm/utilities/errorReporter.cpp + src/share/vm/utilities/errorReporter.hpp ! src/share/vm/utilities/ostream.cpp ! src/share/vm/utilities/ostream.hpp ! src/share/vm/utilities/vmError.cpp Changeset: fb539912d338 Author: coleenp Date: 2011-02-07 14:36 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/fb539912d338 6472925: OutOfMemoryError fails to generate stack trace as it now ought Summary: Print an additional message for OOM during stack trace printing Reviewed-by: dholmes, phh, acorn, kamg, dcubed ! src/share/vm/runtime/thread.cpp Changeset: 5fb3ee258e76 Author: coleenp Date: 2011-02-08 19:50 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/5fb3ee258e76 Merge - make/closed.make Changeset: f36c9fe788b8 Author: mchung Date: 2011-02-08 09:11 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/f36c9fe788b8 7017673: Remove setting of the sun.jkernel.DownloadManager as a boot classloader hook Reviewed-by: alanb, dcubed, coleenp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/runtime/thread.cpp Changeset: 5197f3d713a1 Author: mchung Date: 2011-02-08 22:27 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/5197f3d713a1 Merge - make/closed.make ! src/share/vm/runtime/thread.cpp Changeset: 63d374c54045 Author: ctornqvi Date: 2011-02-09 11:08 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/63d374c54045 7014918: Improve core/minidump handling in Hotspot Summary: Added Minidump support on Windows, enabled large page core dumps when coredump_filter is present and writing out path/rlimit for core dumps. Reviewed-by: poonam, dsamersoff, sla, coleenp ! src/os/linux/vm/os_linux.cpp + src/os/posix/vm/os_posix.cpp ! src/os/windows/vm/os_windows.cpp ! src/os/windows/vm/os_windows.hpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/os.hpp ! src/share/vm/utilities/vmError.cpp ! src/share/vm/utilities/vmError.hpp Changeset: b83527d0482d Author: ctornqvi Date: 2011-02-10 12:55 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/b83527d0482d 7018366: hotspot/runtime_erro Fix for 7014918 does not build using MVC 2003 Summary: Looking at API_VERSION_NUMBER define to see what version of dbghelp.h/imagehlp.h is included to determine what MINIDUMP_TYPEs are defined in the header file Reviewed-by: acorn, brutisso, sla ! src/os/windows/vm/os_windows.cpp Changeset: e1523f7fd848 Author: rottenha Date: 2011-02-11 05:40 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/e1523f7fd848 Merge - make/closed.make Changeset: 55b9f498dbce Author: cl Date: 2011-02-10 16:24 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/55b9f498dbce Added tag jdk7-b129 for changeset ae4b185f2ed1 ! .hgtags Changeset: 14c2f31280dd Author: trims Date: 2011-02-11 14:30 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/14c2f31280dd Added tag hs21-b01 for changeset ae4b185f2ed1 ! .hgtags Changeset: 2a9f9f2200fa Author: trims Date: 2011-02-11 15:31 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/2a9f9f2200fa Merge - agent/src/share/classes/sun/jvm/hotspot/runtime/LowMemoryDetectorThread.java Changeset: 762bc029de50 Author: trims Date: 2011-02-11 15:32 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/762bc029de50 7019104: Bump the HS21 build number to 02 Summary: Update the HS21 build number to 02 Reviewed-by: jcoomes ! make/hotspot_version Changeset: f7702f8c0e25 Author: tonyp Date: 2011-02-14 22:21 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/f7702f8c0e25 Merge ! make/jprt.properties ! src/share/vm/services/management.cpp From John.Coomes at oracle.com Wed Feb 16 18:06:11 2011 From: John.Coomes at oracle.com (John Coomes) Date: Wed, 16 Feb 2011 10:06:11 -0800 Subject: review request (S): 6962930 make the string table size configurable Message-ID: <19804.4627.94089.715688@oracle.com> I'd appreciate reviews of a small change to allow the string table size to be set on the command line: http://cr.openjdk.java.net/~jcoomes/6962930-str-tbl-sz/ -John From keith.mcguigan at oracle.com Wed Feb 16 18:15:57 2011 From: keith.mcguigan at oracle.com (Keith McGuigan) Date: Wed, 16 Feb 2011 13:15:57 -0500 Subject: review request (S): 6962930 make the string table size configurable In-Reply-To: <19804.4627.94089.715688@oracle.com> References: <19804.4627.94089.715688@oracle.com> Message-ID: <477077D3-343C-4B6B-9993-196E3FCB98AD@oracle.com> Looks good. Nothing in the SA agent was calling getStringTableSize()? On Feb 16, 2011, at 1:06 PM, John Coomes wrote: > I'd appreciate reviews of a small change to allow the string table > size to be set on the command line: > > http://cr.openjdk.java.net/~jcoomes/6962930-str-tbl-sz/ > > -John > From paul.hohensee at oracle.com Wed Feb 16 18:29:51 2011 From: paul.hohensee at oracle.com (Paul Hohensee) Date: Wed, 16 Feb 2011 13:29:51 -0500 Subject: review request (S): 6962930 make the string table size configurable In-Reply-To: <477077D3-343C-4B6B-9993-196E3FCB98AD@oracle.com> References: <19804.4627.94089.715688@oracle.com> <477077D3-343C-4B6B-9993-196E3FCB98AD@oracle.com> Message-ID: <4D5C179F.2080300@oracle.com> It does. See agent/src/share/classes/sun/jvm/hotspot/memory/StringTable.java. stringTableSize = db.lookupIntConstant("StringTable::string_table_size").intValue(); Paul On 2/16/11 1:15 PM, Keith McGuigan wrote: > > Looks good. Nothing in the SA agent was calling getStringTableSize()? > > On Feb 16, 2011, at 1:06 PM, John Coomes wrote: > >> I'd appreciate reviews of a small change to allow the string table >> size to be set on the command line: >> >> http://cr.openjdk.java.net/~jcoomes/6962930-str-tbl-sz/ >> >> -John >> > From David.Holmes at oracle.com Thu Feb 17 01:07:29 2011 From: David.Holmes at oracle.com (David Holmes) Date: Thu, 17 Feb 2011 11:07:29 +1000 Subject: review request (S): 6962930 make the string table size configurable In-Reply-To: <19804.4627.94089.715688@oracle.com> References: <19804.4627.94089.715688@oracle.com> Message-ID: <4D5C74D1.1040902@oracle.com> Can clarify in globals.hpp whether the size is in bytes, KB, MB. Thanks, David John Coomes said the following on 02/17/11 04:06: > I'd appreciate reviews of a small change to allow the string table > size to be set on the command line: > > http://cr.openjdk.java.net/~jcoomes/6962930-str-tbl-sz/ > > -John > From tom.rodriguez at oracle.com Wed Feb 16 18:33:01 2011 From: tom.rodriguez at oracle.com (Tom Rodriguez) Date: Wed, 16 Feb 2011 10:33:01 -0800 Subject: review request (S): 6962930 make the string table size configurable In-Reply-To: <477077D3-343C-4B6B-9993-196E3FCB98AD@oracle.com> References: <19804.4627.94089.715688@oracle.com> <477077D3-343C-4B6B-9993-196E3FCB98AD@oracle.com> Message-ID: <1D428418-464F-4F49-A6FC-846D61493EA7@oracle.com> On Feb 16, 2011, at 10:15 AM, Keith McGuigan wrote: > > Looks good. Nothing in the SA agent was calling getStringTableSize()? No. Remember that's the default string table size. If you really want to ask the StringTable what size it is, you'd call BasicHashtable.tableSize() on the instance. tom > > On Feb 16, 2011, at 1:06 PM, John Coomes wrote: > >> I'd appreciate reviews of a small change to allow the string table >> size to be set on the command line: >> >> http://cr.openjdk.java.net/~jcoomes/6962930-str-tbl-sz/ >> >> -John >> > From tom.rodriguez at oracle.com Wed Feb 16 18:38:32 2011 From: tom.rodriguez at oracle.com (Tom Rodriguez) Date: Wed, 16 Feb 2011 10:38:32 -0800 Subject: review request (S): 6962930 make the string table size configurable In-Reply-To: <4D5C179F.2080300@oracle.com> References: <19804.4627.94089.715688@oracle.com> <477077D3-343C-4B6B-9993-196E3FCB98AD@oracle.com> <4D5C179F.2080300@oracle.com> Message-ID: Oops. That line should be deleted too, along with the declaration of stringTableSize in StringTable.java. tom On Feb 16, 2011, at 10:29 AM, Paul Hohensee wrote: > It does. See agent/src/share/classes/sun/jvm/hotspot/memory/StringTable.java. > > stringTableSize = db.lookupIntConstant("StringTable::string_table_size").intValue(); > > Paul > > On 2/16/11 1:15 PM, Keith McGuigan wrote: >> >> Looks good. Nothing in the SA agent was calling getStringTableSize()? >> >> On Feb 16, 2011, at 1:06 PM, John Coomes wrote: >> >>> I'd appreciate reviews of a small change to allow the string table >>> size to be set on the command line: >>> >>> http://cr.openjdk.java.net/~jcoomes/6962930-str-tbl-sz/ >>> >>> -John >>> >> From stefan.karlsson at oracle.com Tue Feb 22 21:10:59 2011 From: stefan.karlsson at oracle.com (stefan.karlsson at oracle.com) Date: Tue, 22 Feb 2011 21:10:59 +0000 Subject: hg: jdk7/hotspot-gc/hotspot: 7020992: jmm_DumpThreads should not allocate system object arrays outside the perm gen Message-ID: <20110222211104.B430247979@hg.openjdk.java.net> Changeset: 02f78cfa4656 Author: stefank Date: 2011-02-21 11:26 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/02f78cfa4656 7020992: jmm_DumpThreads should not allocate system object arrays outside the perm gen Summary: Allocate ordinary object arrays Reviewed-by: ysr, never, mchung ! src/share/vm/memory/oopFactory.cpp ! src/share/vm/memory/oopFactory.hpp ! src/share/vm/services/management.cpp From nhann at chalmers.se Wed Feb 23 09:29:54 2011 From: nhann at chalmers.se (Dang Nhan Nguyen) Date: Wed, 23 Feb 2011 10:29:54 +0100 Subject: Allocating memory off the heap and stack, Message-ID: <416B678CFDED2C43ADFFAC692465DAC12B25534058@MAPI01.ita.chalmers.se> Hi everyone, I am perform some testing coding in JCM GC and want to allocate some dynamic memory which is not in the heap (so that GC won't reclaim it during GC collection) nor stack. My program need to allocation memory for an object of class A. Can I create class A that can use memory for its object off the heap and stack? Which allocation class should I derive for my class? By the way, could you please explain what is Arena memory area and ResourceObj? (in memory allocation memory/allocation.hpp) Thank you, /Nhan Nguyen From tom.rodriguez at oracle.com Wed Feb 23 21:27:02 2011 From: tom.rodriguez at oracle.com (Tom Rodriguez) Date: Wed, 23 Feb 2011 13:27:02 -0800 Subject: optimized build broken Message-ID: <08903C5F-276B-45BD-8077-643D82BFA06E@oracle.com> I don't know how long this has been the case but g1CollectedHeap.hpp breaks the optimized build because the declaration of is_in_closed_subset is NOT_PRODUCT but the definition is DEBUG only and is_in_closed_subset is a virtual. Is this a known issue? By the way, it seems broken for a product virtual method to have non-product overrides. Shouldn't it be defined in product too? tom From tom.rodriguez at oracle.com Thu Feb 24 18:31:52 2011 From: tom.rodriguez at oracle.com (Tom Rodriguez) Date: Thu, 24 Feb 2011 10:31:52 -0800 Subject: optimized build broken In-Reply-To: <08903C5F-276B-45BD-8077-643D82BFA06E@oracle.com> References: <08903C5F-276B-45BD-8077-643D82BFA06E@oracle.com> Message-ID: I filed 7022200 for this. tom On Feb 23, 2011, at 1:27 PM, Tom Rodriguez wrote: > I don't know how long this has been the case but g1CollectedHeap.hpp breaks the optimized build because the declaration of is_in_closed_subset is NOT_PRODUCT but the definition is DEBUG only and is_in_closed_subset is a virtual. Is this a known issue? By the way, it seems broken for a product virtual method to have non-product overrides. Shouldn't it be defined in product too? > > tom From john.cuthbertson at oracle.com Fri Feb 25 20:57:01 2011 From: john.cuthbertson at oracle.com (John Cuthbertson) Date: Fri, 25 Feb 2011 12:57:01 -0800 Subject: RFR(XXS): 7022200 G1: optimized build broken Message-ID: <4D68179D.8090404@oracle.com> Hi Everyone, Can I have a couple of volunteers to review this small change? The webrev can be found at http://cr.openjdk.java.net/~johnc/7022200/webrev.0/ The function G1CollectedHeap::is_in_closed_subset was inadvertently placed in #ifdef ASSERT conditional compilation resulting in a link failure in the optimized build. Thanks, JohnC From jon.masamitsu at oracle.com Fri Feb 25 21:58:28 2011 From: jon.masamitsu at oracle.com (Jon Masamitsu) Date: Fri, 25 Feb 2011 13:58:28 -0800 Subject: Help needed to analyze why Full GC occured In-Reply-To: <800270.79659.qm@web111111.mail.gq1.yahoo.com> References: <800270.79659.qm@web111111.mail.gq1.yahoo.com> Message-ID: <4D682604.5080505@oracle.com> There was a bug in CMS where stale data was being used to decide whether a minor collection (ParNew) would succeed. I think one of the symptoms was that CMS decided it had to do a full collection. Which version of the JDK are you using? If not the latest, try reproducing this with the latest build. On 2/25/2011 8:18 AM, Erwin wrote: > Hello, > > Full GC (which took 9 seconds)occured during off hours for all our 6 JVM, seemingly around the same time frame and I'm wondering what triggered it. I'm new with analyzing GC so your help is appreciated. Did the perm gen get full? We're on 32bit WAS NDE 6.1.0.23 on Unix\Solaris 10. Our max heap is set to 1536mb. Our JVM args are: > -XX:+PrintGCDetails > -XX:+PrintGCTimeStamps > -XX:+PrintHeapAtGC > -Dsun.rmi.dgc.client.gcInterval=3600000 > -Dsun.rmi.dgc.server.gcInterval=3600000 > -XX:+DisableExplicitGC > -XX:+UseConcMarkSweepGC > -XX:+CMSParallelRemarkEnabled > -XX:+CMSPermGenSweepingEnabled > -XX:+CMSClassUnloadingEnabled > -agentlib:am_sun_15=/opt/IBM/itcam/WebSphere/DC/runtime/was61.d5-node61-pt01-01.d5-web_a101-pt01-01/ > -verbosegc > -XX:MaxPermSize=256m > -XX:PermSize=256m > > 70314.666: [GC {Heap before gc invocations=1105: > par new generation total 72512K, used 72448K [0x85800000, 0x89ee0000, 0x8b800000) > eden space 72448K, 100% used [0x85800000, 0x89ec0000, 0x89ec0000) > from space 64K, 0% used [0x89ec0000, 0x89ec0000, 0x89ed0000) > to space 64K, 0% used [0x89ed0000, 0x89ed0000, 0x89ee0000) > concurrent mark-sweep generation total 1085184K, used 740804K [0x8b800000, 0xcdbc0000, 0xe5800000) > concurrent-mark-sweep perm gen total 262144K, used 138639K [0xe5800000, 0xf5800000, 0xf5800000) > 70314.668: [ParNew: 72448K->0K(72512K), 0.0537868 secs] 813252K->756978K(1174720K)Heap after gc invocations=1106: > par new generation total 73664K, used 0K [0x85800000, 0x8a000000, 0x8b800000) > eden space 73600K, 0% used [0x85800000, 0x85800000, 0x89fe0000) > from space 64K, 0% used [0x89fe0000, 0x89fe0000, 0x89ff0000) > to space 64K, 0% used [0x89ff0000, 0x89ff0000, 0x8a000000) > concurrent mark-sweep generation total 1102208K, used 756978K [0x8b800000, 0xcec60000, 0xe5800000) > concurrent-mark-sweep perm gen total 262144K, used 138639K [0xe5800000, 0xf5800000, 0xf5800000) > } > , 0.0570178 secs] > 70340.365: [Full GC {Heap before gc invocations=1106: > par new generation total 73664K, used 72414K [0x85800000, 0x8a000000, 0x8b800000) > eden space 73600K, 98% used [0x85800000, 0x89eb7a60, 0x89fe0000) > from space 64K, 0% used [0x89fe0000, 0x89fe0000, 0x89ff0000) > to space 64K, 0% used [0x89ff0000, 0x89ff0000, 0x8a000000) > concurrent mark-sweep generation total 1102208K, used 756978K [0x8b800000, 0xcec60000, 0xe5800000) > concurrent-mark-sweep perm gen total 262144K, used 139266K [0xe5800000, 0xf5800000, 0xf5800000) > 70340.366: [CMS[Unloading class com.ibm.ws.webmsg.channel.component.WebMsgChannelInit] > [Unloading class sun.reflect.GeneratedConstructorAccessor171] > [Unloading class com.ibm.tivoli.itcam.toolkit.ai.callbacks.apptrace.AppTraceCallback] > [Unloading class com.ibm.ws.webmsg.client.splitprocess.exception.SplitProcessInitException] > [Unloading class com.ibm.ws.webmsg.timer.TimerManager] > [Unloading class com.ibm.ws.webmsg.component.WebMsgChannelCompImpl] > [Unloading class com.ibm.tivoli.itcam.toolkit.ai.callbacks.apptrace.LockCallback$1] > [Unloading class com.ibm.ws.webmsg.container.cfw.ServiceRequester] > [Unloading class sun.reflect.GeneratedMethodAccessor311] > [Unloading class sun.reflect.GeneratedConstructorAccessor172] > [Unloading class com.ibm.ws.webmsg.container.WebMsgContainer] > [Unloading class com.ibm.tivoli.itcam.toolkit.ai.callbacks.captureServlet.ServletCallback$1] > [Unloading class org.apache.geronimo.samples.daytrader.web.TradeWebContextListener] > [Unloading class sun.reflect.GeneratedMethodAccessor307] > [Unloading class sun.reflect.GeneratedConstructorAccessor175] > [Unloading class _ibmjsp._agent_5F_home] > [Unloading class com.ibm.tivoli.itcam.toolkit.ai.callbacks.apptrace.LockCallback] > [Unloading class sun.reflect.GeneratedMethodAccessor305] > [Unloading class _ibmjsp.services.manage_5F_customer_5F_relationships._AlertMasterListing] > [Unloading class _ibmjsp._catastrophic_5F_news_5F_load] > [Unloading class _ibmjsp._logout] > [Unloading class sun.reflect.GeneratedSerializationConstructorAccessor296] > [Unloading class sun.reflect.GeneratedMethodAccessor306] > [Unloading class sun.reflect.GeneratedMethodAccessor314] > [Unloading class com.ibm.defaultapplication.Increment] > [Unloading class com.ibm.tivoli.itcam.toolkit.ai.callbacks.apptrace.LockCallback$LockAspectImpl] > [Unloading class com.ibm.ws.webmsg.utils.map.SyncMapCreator] > [Unloading class SnoopServlet] > [Unloading class sun.reflect.GeneratedMethodAccessor310] > [Unloading class sun.reflect.GeneratedMethodAccessor321] > [Unloading class com.ibm.tivoli.itcam.toolkit.ai.callbacks.apptrace.AppTraceCallback$EntryExitAspectImpl] > [Unloading class com.ibm.tivoli.itcam.toolkit.ai.callbacks.captureServlet.ServletCallback$2] > [Unloading class sun.reflect.GeneratedMethodAccessor319] > [Unloading class com.ibm.mq.MQEnvironment] > [Unloading class com.ibm.mq.MQEnvironment] > [Unloading class sun.reflect.GeneratedMethodAccessor315] > [Unloading class org.apache.geronimo.samples.daytrader.web.TradeAppServlet] > [Unloading class _ibmjsp.services.administration._UpdateYourProfile] > [Unloading class _ibmjsp.services.administration._administration] > [Unloading class sun.reflect.GeneratedMethodAccessor320] > [Unloading class com.ibm.ws.webmsg.container.cfw.WebMsgCFWExt] > [Unloading class _ibmjsp._customer_5F_inquiry_5F_XMIM] > [Unloading class sun.reflect.GeneratedMethodAccessor308] > [Unloading class sun.reflect.GeneratedConstructorAccessor174] > [Unloading class HitCount] > [Unloading class sun.reflect.GeneratedConstructorAccessor173] > [Unloading class sun.reflect.GeneratedSerializationConstructorAccessor295] > [Unloading class sun.reflect.GeneratedConstructorAccessor170] > [Unloading class sun.reflect.GeneratedMethodAccessor312] > [Unloading class sun.reflect.GeneratedMethodAccessor309] > [Unloading class com.ibm.ws.webmsg.container.cfw.session.TableCreator] > [Unloading class _ibmjsp.services.encompass_5F_news._encompass_5F_news] > [Unloading class org.apache.geronimo.samples.daytrader.web.TradeScenarioServlet] > [Unloading class com.ibm.tivoli.itcam.toolkit.ai.callbacks.captureServlet.ServletCallback$1] > [Unloading class sun.reflect.GeneratedMethodAccessor318] > [Unloading class sun.reflect.GeneratedSerializationConstructorAccessor298] > [Unloading class com.ibm.tivoli.itcam.toolkit.ai.callbacks.captureServlet.ServletCallback$2] > [Unloading class com.ibm.tivoli.itcam.toolkit.ai.callbacks.apptrace.AppTraceCallback$1] > [Unloading class sun.reflect.GeneratedSerializationConstructorAccessor297] > [Unloading class com.ibm.ws.webmsg.channel.passthrough.PassThroughChannelFactory] > [Unloading class com.ibm.ws.webmsg.component.WebMsgService] > [Unloading class sun.reflect.GeneratedMethodAccessor313] > [Unloading class _ibmjsp._agent_5F_home_5F_active_5F_quotes_5F_display] > [Unloading class com.ibm.tivoli.itcam.toolkit.ai.callbacks.captureServlet.ServletCallback] > [Unloading class _ibmjsp._urgent_5F_news_5F_load] > [Unloading class com.ibm.ws.webmsg.osgi.WebMsgBundleActivator] > [Unloading class com.ibm.ws.webmsg.channel.acceptor.WMSGAcceptorChannelFactory] > [Unloading class com.ibm.tivoli.itcam.toolkit.ai.callbacks.captureServlet.ServletCallback] > [Unloading class _ibmjsp._account_5F_alerts_5F_home_5F_load] > [Unloading class _ibmjsp._callwrapper] > [Unloading class HelloPervasiveServlet] > [Unloading class sun.reflect.GeneratedMethodAccessor304] > : 756978K->586452K(1102208K), 9.0385238 secs] 829392K->586452K(1175872K), [CMS Perm : 139266K->137180K(262144K)]Heap after gc invocations=1107: > par new generation total 73600K, used 0K [0x85800000, 0x89ff0000, 0x8b800000) > eden space 73536K, 0% used [0x85800000, 0x85800000, 0x89fd0000) > from space 64K, 0% used [0x89fd0000, 0x89fd0000, 0x89fe0000) > to space 64K, 0% used [0x89fe0000, 0x89fe0000, 0x89ff0000) > concurrent mark-sweep generation total 1102208K, used 586452K [0x8b800000, 0xcec60000, 0xe5800000) > concurrent-mark-sweep perm gen total 262144K, used 137180K [0xe5800000, 0xf5800000, 0xf5800000) > } > , 9.0417245 secs] > > > > _______________________________________________ > hotspot-gc-use mailing list > hotspot-gc-use at openjdk.java.net > http://mail.openjdk.java.net/mailman/listinfo/hotspot-gc-use _______________________________________________ hotspot-gc-use mailing list hotspot-gc-use at openjdk.java.net http://mail.openjdk.java.net/mailman/listinfo/hotspot-gc-use From John.Coomes at oracle.com Fri Feb 25 22:25:27 2011 From: John.Coomes at oracle.com (John Coomes) Date: Fri, 25 Feb 2011 14:25:27 -0800 Subject: RFR(XXS): 7022200 G1: optimized build broken In-Reply-To: <4D68179D.8090404@oracle.com> References: <4D68179D.8090404@oracle.com> Message-ID: <19816.11351.168274.988471@oracle.com> John Cuthbertson (john.cuthbertson at oracle.com) wrote: > Hi Everyone, > > Can I have a couple of volunteers to review this small change? The > webrev can be found at > http://cr.openjdk.java.net/~johnc/7022200/webrev.0/ The function > G1CollectedHeap::is_in_closed_subset was inadvertently placed in #ifdef > ASSERT conditional compilation resulting in a link failure in the > optimized build. Looks good. -John From tony.printezis at oracle.com Fri Feb 25 22:37:57 2011 From: tony.printezis at oracle.com (tony.printezis at oracle.com) Date: Fri, 25 Feb 2011 22:37:57 +0000 Subject: hg: jdk7/hotspot-gc/hotspot: 35 new changesets Message-ID: <20110225223857.162B947A72@hg.openjdk.java.net> Changeset: e9aa2ca89ad6 Author: kamg Date: 2011-02-16 16:58 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/e9aa2ca89ad6 7019718: make error reporting flags product instead of diagnostic Summary: see synopsis Reviewed-by: acorn, coleenp ! src/share/vm/runtime/globals.hpp Changeset: 02368ad6c63f Author: trims Date: 2011-02-16 17:26 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/02368ad6c63f Merge Changeset: 15d6977f04b0 Author: sla Date: 2011-02-10 13:03 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/15d6977f04b0 7017824: Add support for creating 64-bit Visual Studio projects Summary: Updated create.bat and ProjectCreator Reviewed-by: brutisso, stefank, ohair ! make/windows/create.bat ! make/windows/makefiles/compile.make ! make/windows/makefiles/projectcreator.make ! make/windows/makefiles/rules.make - make/windows/platform_amd64 - make/windows/platform_i486 - make/windows/platform_ia64 ! make/windows/projectfiles/common/Makefile ! src/os_cpu/windows_x86/vm/unwind_windows_x86.hpp ! src/share/tools/ProjectCreator/BuildConfig.java ! src/share/tools/ProjectCreator/DirectoryTree.java ! src/share/tools/ProjectCreator/FileFormatException.java - src/share/tools/ProjectCreator/Macro.java - src/share/tools/ProjectCreator/MacroDefinitions.java ! src/share/tools/ProjectCreator/Util.java ! src/share/tools/ProjectCreator/WinGammaPlatform.java ! src/share/tools/ProjectCreator/WinGammaPlatformVC6.java ! src/share/tools/ProjectCreator/WinGammaPlatformVC7.java ! src/share/vm/adlc/adlc.hpp ! src/share/vm/oops/methodOop.cpp ! src/share/vm/oops/methodOop.hpp Changeset: 7aa1f99ca301 Author: coleenp Date: 2011-02-12 10:28 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/7aa1f99ca301 7019157: errorHandler doesn't compile with super old gcc without precompiled headers Summary: old gccs don't support precompiled headers so have to supply includes Reviewed-by: phh, kamg ! src/share/vm/utilities/errorReporter.hpp Changeset: 54df4702df97 Author: rottenha Date: 2011-02-14 03:19 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/54df4702df97 Merge - make/windows/platform_amd64 - make/windows/platform_i486 - make/windows/platform_ia64 - src/share/tools/ProjectCreator/Macro.java - src/share/tools/ProjectCreator/MacroDefinitions.java Changeset: de14f1eee390 Author: dcubed Date: 2011-02-15 19:00 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/de14f1eee390 6954420: 2/4 jps shows "process information unavailable" sometimes Summary: Make sure the backing store file is flushed in create_sharedmem_resources() and get_user_name_slow() no longer checks the size of the backing store file. Reviewed-by: briand, swamyv, acorn, poonam ! src/os/windows/vm/perfMemory_windows.cpp Changeset: b76d12f4ab2d Author: dholmes Date: 2011-02-14 19:27 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/b76d12f4ab2d 7018429: JPRT: Update Makefile to use ALT_JDK_TARGET_IMPORT_PATH for copying JDK Summary: Set JDK_IMPORT_PATH to ALT_JDK_TARGET_IMPORT_PATH if it is defined Reviewed-by: phh, ohair ! make/Makefile ! make/defs.make Changeset: 5415131bc5ab Author: dholmes Date: 2011-02-16 01:42 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/5415131bc5ab Merge Changeset: c08677f98289 Author: coleenp Date: 2011-02-16 11:34 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/c08677f98289 6840152: JVM crashes when heavyweight monitors are used Summary: Turn off biased locking if !UseFastLocking or UseHeavyMonitors options are requested. Reviewed-by: phh, never, dcubed, dholmes ! src/share/vm/runtime/arguments.cpp Changeset: 3adec115d40d Author: coleenp Date: 2011-02-16 17:12 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/3adec115d40d 7019689: Non-dependent name is found in dependent base class although it should be rejected Summary: fix hashtable.hpp to qualify non-dependant name with "this" Reviewed-by: phh, never, poonam Contributed-by: volker.simonis at gmail.com ! src/share/vm/utilities/hashtable.hpp Changeset: a959935a5732 Author: coleenp Date: 2011-02-16 16:25 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/a959935a5732 Merge Changeset: 6e70f1bb7f6f Author: coleenp Date: 2011-02-18 18:26 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/6e70f1bb7f6f 7019557: SharedMiscDataSize too small for 64-bit fastdebug JVM Summary: Increase default SharedMiscDataSize Reviewed-by: dcubed, kamg ! src/share/vm/runtime/globals.hpp Changeset: f77b3ec064b0 Author: rottenha Date: 2011-02-21 04:49 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/f77b3ec064b0 Merge - make/windows/platform_amd64 - make/windows/platform_i486 - make/windows/platform_ia64 - src/share/tools/ProjectCreator/Macro.java - src/share/tools/ProjectCreator/MacroDefinitions.java ! src/share/vm/oops/methodOop.cpp ! src/share/vm/oops/methodOop.hpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp Changeset: 4f26f535a225 Author: never Date: 2011-01-31 17:48 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/4f26f535a225 6354181: nsk.logging.stress.threads.scmhml001 fails assertion in "src/share/vm/oops/instanceKlass.cpp, 111" Reviewed-by: jrose, acorn ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/ci/ciInstanceKlass.cpp ! src/share/vm/classfile/loaderConstraints.cpp ! src/share/vm/classfile/systemDictionary.cpp Changeset: 638119ce7cfd Author: twisti Date: 2011-02-01 03:38 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/638119ce7cfd 7009309: JSR 292: compiler/6991596/Test6991596.java crashes on fastdebug JDK7/b122 Reviewed-by: kvn, never ! agent/src/share/classes/sun/jvm/hotspot/runtime/StubRoutines.java ! src/cpu/x86/vm/cppInterpreter_x86.cpp ! src/cpu/x86/vm/interpreter_x86.hpp ! src/cpu/x86/vm/interpreter_x86_32.cpp ! src/cpu/x86/vm/sharedRuntime_x86_32.cpp ! src/cpu/x86/vm/sharedRuntime_x86_64.cpp ! src/cpu/x86/vm/stubGenerator_x86_32.cpp ! src/cpu/x86/vm/stubRoutines_x86_32.cpp ! src/cpu/x86/vm/stubRoutines_x86_32.hpp ! src/cpu/x86/vm/templateInterpreter_x86_32.cpp ! src/cpu/x86/vm/templateInterpreter_x86_64.cpp ! src/cpu/x86/vm/templateTable_x86_32.cpp ! src/cpu/zero/vm/stubRoutines_zero.cpp ! src/cpu/zero/vm/stubRoutines_zero.hpp ! src/share/vm/runtime/vmStructs.cpp Changeset: fbf3184da15d Author: twisti Date: 2011-02-01 05:51 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/fbf3184da15d 7012339: JSR 292 crash in G1SATBCardTableModRefBS::write_ref_field_pre_work() Reviewed-by: jrose, never ! src/share/vm/oops/cpCacheOop.cpp Changeset: c52cba2a3359 Author: kvn Date: 2011-02-01 10:27 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/c52cba2a3359 7014998: assert(is_T_family(features) == is_niagara(features)) failed: Niagara should be T series Summary: Use substring search instead of compare and convert string to upper case before search. Reviewed-by: never, phh, iveresov ! src/os_cpu/solaris_sparc/vm/vm_version_solaris_sparc.cpp Changeset: 194c9fdee631 Author: kvn Date: 2011-02-07 09:46 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/194c9fdee631 7017240: C2: native memory leak in nsk/regression/b4675027 on windows-x86 in comp mode with G1 Summary: Add ResourceMark into PhaseIdealLoop::build_and_optimize(). Reviewed-by: never ! src/share/vm/opto/loopnode.cpp ! src/share/vm/opto/loopnode.hpp Changeset: 3763ca6579b7 Author: kvn Date: 2011-02-07 10:25 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/3763ca6579b7 7013538: Java memory leak with escape analysis Summary: Don't allocate VectorSet iterator on C heap. Reuse resource storage in EA. Reviewed-by: never ! src/share/vm/libadt/vectset.cpp ! src/share/vm/libadt/vectset.hpp ! src/share/vm/opto/escape.cpp ! src/share/vm/opto/escape.hpp ! src/share/vm/opto/phase.cpp Changeset: f7de3327c683 Author: kvn Date: 2011-02-07 10:34 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/f7de3327c683 7017124: Fix some VM stats to avoid 32-bit overflow Summary: Added new method inc_stat_counter() to increment long statistic values and use atomic long load and store. Reviewed-by: dholmes, jrose, phh, never ! src/os_cpu/solaris_sparc/vm/atomic_solaris_sparc.inline.hpp ! src/share/vm/memory/allocation.cpp ! src/share/vm/memory/allocation.hpp ! src/share/vm/memory/allocation.inline.hpp ! src/share/vm/opto/indexSet.cpp ! src/share/vm/opto/indexSet.hpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/java.cpp ! src/share/vm/runtime/os.cpp ! src/share/vm/runtime/os.hpp Changeset: 336d17dff7cc Author: kvn Date: 2011-02-08 16:12 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/336d17dff7cc 7014874: Incorrect COOPs modes on solaris-{sparcv9,amd64} with ParallelGC Summary: Align old gen size down to keep specified heap size. Reviewed-by: ysr ! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.cpp Changeset: 72d6c57d0658 Author: iveresov Date: 2011-02-09 16:34 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/72d6c57d0658 7017434: Tiered needs to support reprofiling Summary: Tiered needs to support proper method reprofiling after deopts. Reviewed-by: kvn ! src/share/vm/c1/c1_Compilation.cpp ! src/share/vm/oops/methodDataOop.cpp ! src/share/vm/oops/methodDataOop.hpp ! src/share/vm/runtime/simpleThresholdPolicy.cpp ! src/share/vm/runtime/simpleThresholdPolicy.hpp Changeset: 62a8557e8f36 Author: twisti Date: 2011-02-10 00:47 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/62a8557e8f36 7018277: JSR 292 change test/compiler/6987555/Test6987555.java to new MH syntax Summary: test/compiler/6987555/Test6987555.java currently does not compile because the MH return-type syntax has changed. Reviewed-by: never ! test/compiler/6987555/Test6987555.java Changeset: ab42c7e1cf83 Author: kvn Date: 2011-02-10 14:25 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/ab42c7e1cf83 7017746: Regression : C2 compiler crash due to SIGSEGV in PhaseCFG::schedule_early() Summary: Add TEMP edges (and KILL projections) before duplicated operands are removed in Expand() methods. Reviewed-by: never ! src/cpu/sparc/vm/sparc.ad ! src/share/vm/adlc/output_c.cpp ! src/share/vm/opto/node.cpp + test/compiler/7017746/Test.java Changeset: bf29934d2f4f Author: kvn Date: 2011-02-10 19:34 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/bf29934d2f4f 7018849: 7017124 fix broke VM build on some platforms Summary: Use atomic load and store in inc_stat_counter() only on SPARC and X86. Reviewed-by: iveresov ! src/share/vm/memory/allocation.inline.hpp Changeset: 173926398291 Author: twisti Date: 2011-02-11 03:17 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/173926398291 7018673: Zero: 6953144, 6990754 and 7009756 made some changes which broke Zero Reviewed-by: kvn, chrisphi, twisti ! src/os_cpu/linux_zero/vm/atomic_linux_zero.inline.hpp ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/interpreter/bytecodeInterpreter.cpp ! src/share/vm/oops/methodOop.cpp Changeset: 34457f6ac818 Author: never Date: 2011-02-11 12:05 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/34457f6ac818 7018506: CTW swallowing OOMs after symbol changes Reviewed-by: kvn, iveresov, coleenp ! src/share/vm/classfile/classLoader.cpp Changeset: 28bf941f445e Author: twisti Date: 2011-02-14 03:21 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/28bf941f445e 7018378: JSR 292: _bound_int_mh produces wrong result on 64-bit SPARC Reviewed-by: kvn ! src/cpu/sparc/vm/assembler_sparc.cpp ! src/cpu/sparc/vm/assembler_sparc.hpp ! src/cpu/sparc/vm/methodHandles_sparc.cpp ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/assembler_x86.hpp ! src/cpu/x86/vm/methodHandles_x86.cpp Changeset: 2a57c59eb548 Author: never Date: 2011-02-14 11:46 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/2a57c59eb548 7018101: os::dll_address_to_function_name returning wrong answers in 64 bit Reviewed-by: acorn, kvn, dsamersoff ! src/os/solaris/vm/os_solaris.cpp Changeset: 850b2295a494 Author: kvn Date: 2011-02-14 14:36 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/850b2295a494 Merge ! src/os/solaris/vm/os_solaris.cpp ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/interpreter/bytecodeInterpreter.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/java.cpp ! src/share/vm/runtime/os.hpp ! src/share/vm/runtime/vmStructs.cpp Changeset: 1957c1478794 Author: never Date: 2011-02-15 22:18 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/1957c1478794 7019819: bare oop in ciField Reviewed-by: kvn, iveresov ! src/share/vm/ci/ciField.cpp Changeset: 6bbaedb03534 Author: never Date: 2011-02-09 15:02 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/6bbaedb03534 7016474: string compare intrinsic improvements Reviewed-by: kvn ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/assembler_x86.hpp ! src/cpu/x86/vm/x86_32.ad ! src/cpu/x86/vm/x86_64.ad Changeset: 5841dc1964f0 Author: never Date: 2011-02-22 15:26 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/5841dc1964f0 7021531: lock ordering problems after fix for 6354181 Reviewed-by: kvn, jrose ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/utilities/ostream.cpp ! src/share/vm/utilities/ostream.hpp Changeset: a97fd181b813 Author: kvn Date: 2011-02-23 11:18 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/a97fd181b813 Merge - make/windows/platform_amd64 - make/windows/platform_i486 - make/windows/platform_ia64 - src/share/tools/ProjectCreator/Macro.java - src/share/tools/ProjectCreator/MacroDefinitions.java ! src/share/vm/oops/cpCacheOop.cpp ! src/share/vm/oops/methodDataOop.cpp ! src/share/vm/oops/methodDataOop.hpp ! src/share/vm/oops/methodOop.cpp ! src/share/vm/runtime/globals.hpp Changeset: 8bbefb9743ae Author: tonyp Date: 2011-02-25 10:58 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/8bbefb9743ae Merge From John.Coomes at oracle.com Sun Feb 27 09:13:48 2011 From: John.Coomes at oracle.com (John Coomes) Date: Sun, 27 Feb 2011 01:13:48 -0800 Subject: review request (S): 6962930 make the string table size configurable In-Reply-To: References: <19804.4627.94089.715688@oracle.com> <477077D3-343C-4B6B-9993-196E3FCB98AD@oracle.com> <4D5C179F.2080300@oracle.com> Message-ID: <19818.5580.989646.393278@oracle.com> Tom Rodriguez (tom.rodriguez at oracle.com) wrote: > Oops. That line should be deleted too, along with the declaration of stringTableSize in StringTable.java. Thanks. I fixed that and some other nits and updated the webrev at the same location: http://cr.openjdk.java.net/~jcoomes/6962930-str-tbl-sz/ -John > On Feb 16, 2011, at 10:29 AM, Paul Hohensee wrote: > > > It does. See agent/src/share/classes/sun/jvm/hotspot/memory/StringTable.java. > > > > stringTableSize = db.lookupIntConstant("StringTable::string_table_size").intValue(); > > > > Paul > > > > On 2/16/11 1:15 PM, Keith McGuigan wrote: > >> > >> Looks good. Nothing in the SA agent was calling getStringTableSize()? > >> > >> On Feb 16, 2011, at 1:06 PM, John Coomes wrote: > >> > >>> I'd appreciate reviews of a small change to allow the string table > >>> size to be set on the command line: > >>> > >>> http://cr.openjdk.java.net/~jcoomes/6962930-str-tbl-sz/ > >>> > >>> -John > >>> > >> > From John.Coomes at oracle.com Sun Feb 27 09:15:26 2011 From: John.Coomes at oracle.com (John Coomes) Date: Sun, 27 Feb 2011 01:15:26 -0800 Subject: review request (S): 6962930 make the string table size configurable In-Reply-To: <4D5C179F.2080300@oracle.com> References: <19804.4627.94089.715688@oracle.com> <477077D3-343C-4B6B-9993-196E3FCB98AD@oracle.com> <4D5C179F.2080300@oracle.com> Message-ID: <19818.5678.27677.298421@oracle.com> Paul Hohensee (paul.hohensee at oracle.com) wrote: > It does. See > agent/src/share/classes/sun/jvm/hotspot/memory/StringTable.java. > > stringTableSize = > db.lookupIntConstant("StringTable::string_table_size").intValue(); Thanks Keith and Paul. I updated the webrev at the same location. -John > On 2/16/11 1:15 PM, Keith McGuigan wrote: > > > > Looks good. Nothing in the SA agent was calling getStringTableSize()? > > > > On Feb 16, 2011, at 1:06 PM, John Coomes wrote: > > > >> I'd appreciate reviews of a small change to allow the string table > >> size to be set on the command line: > >> > >> http://cr.openjdk.java.net/~jcoomes/6962930-str-tbl-sz/ > >> > >> -John > >> > > From John.Coomes at oracle.com Sun Feb 27 09:17:41 2011 From: John.Coomes at oracle.com (John Coomes) Date: Sun, 27 Feb 2011 01:17:41 -0800 Subject: review request (S): 6962930 make the string table size configurable In-Reply-To: <4D5C74D1.1040902@oracle.com> References: <19804.4627.94089.715688@oracle.com> <4D5C74D1.1040902@oracle.com> Message-ID: <19818.5813.759794.703682@oracle.com> David Holmes (David.Holmes at oracle.com) wrote: > Can clarify in globals.hpp whether the size is in bytes, KB, MB. Thanks for taking a look. It's the number of buckets; I included that info in the doc string and updated the webrev (same location). -John > John Coomes said the following on 02/17/11 04:06: > > I'd appreciate reviews of a small change to allow the string table > > size to be set on the command line: > > > > http://cr.openjdk.java.net/~jcoomes/6962930-str-tbl-sz/ > > > > -John > > From bengt.rutisson at oracle.com Mon Feb 28 07:04:20 2011 From: bengt.rutisson at oracle.com (Bengt Rutisson) Date: Mon, 28 Feb 2011 08:04:20 +0100 Subject: RFR(XXS): 7022200 G1: optimized build broken In-Reply-To: <19816.11351.168274.988471@oracle.com> References: <4D68179D.8090404@oracle.com> <19816.11351.168274.988471@oracle.com> Message-ID: <4D6B48F4.1060907@oracle.com> Looks good to me too. Bengt On 2011-02-25 23:25, John Coomes wrote: > John Cuthbertson (john.cuthbertson at oracle.com) wrote: >> Hi Everyone, >> >> Can I have a couple of volunteers to review this small change? The >> webrev can be found at >> http://cr.openjdk.java.net/~johnc/7022200/webrev.0/ The function >> G1CollectedHeap::is_in_closed_subset was inadvertently placed in #ifdef >> ASSERT conditional compilation resulting in a link failure in the >> optimized build. > Looks good. > > -John > > >