CRR: 7045662: G1: OopsInHeapRegionClosure::set_region() should not be virtual (XS)

Tony Printezis tony.printezis at oracle.com
Wed Jun 1 11:40:21 UTC 2011


Hi,

(first of a series of code review requests for changes I've been 
recently working on)

Could I please have a couple of code reviews for this simple change?

http://cr.openjdk.java.net/~tonyp/7045662/webrev.0/

The main change is to make the set_region() method non-virtual and 
remove two closures that were the reason for that method being virtual 
but that are not used any more. This change shows a very small (~1%) but 
measurable improvement in GC times on some platforms.

I also piggy-backed a couple of extra minor fixes on this change: 
removal of a third unused closure and fixing two small typos in the 
copyright text on two files (I have no idea how that C become lowercase!).

Tony




More information about the hotspot-gc-dev mailing list