CRR: 6804436: G1: heap region indices should be size_t (S)

Bengt Rutisson bengt.rutisson at oracle.com
Thu Jun 9 11:51:21 UTC 2011


Tony,

>>>
>>> This is a good suggestion, Bengt, but I'll need to expose more 
>>> things from G1CH to the HeapRegionSeq to do that (i.e., the fields 
>>> needed in the HeapRegion constructor). And I just didn't want to 
>>> re-arrange things further. So, I think I'll leave it as is, i.e., 
>>> G1CH creating the regions and passing them on to HeapRegionSeq.
>>
>>
>> That's fine. Let's leave it as it is.
>
> Actually (and I should have thought of that earlier!) I think I can do 
> this by creating a factory method for HeapRegion instances in G1CH and 
> calling it from HRS. So HRS will only have a single expand() method 
> (opposite to shrink()) and will deal with the rest internally. Let me 
> have a stab at it and I'll get back to you.

Sounds like  a good plan. Looking forward to seeing it.

Bengt



More information about the hotspot-gc-dev mailing list