Request for review: 6941923: RFE: Handling large logfiles produced by long running Java Applications

[Rainer Jung]

When I looked at the published change

Changeset: 2a241e764894
Author:    minqi
Date:      2011-06-10 15:08 -0700
URL:
http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/2a241e764894

6941923: RFE: Handling large log files produced by long running Java
Applications
Summary: supply optinal flags to realize gc log rotation
Reviewed-by: ysr, jwilhelm


I noticed a flaw in a log message.

File src/share/vm/runtime/arguments.cpp contains the new block:

+       jio_fprintf(defaultStream::output_stream(),
+                   "To enable GC log rotation, use -Xloggc:<filename>
-XX:+UseGCLogRotaion -XX:NumberOfGCLogFiles=<num_of_files>
-XX:GCLogFileSize=<num_of_size>\n"
+                   "where num_of_file > 0 and num_of_size > 0\n"
+                   "GC log rotation is turned off\n");

Note that it says "-XX:+UseGCLogRotaion" instead of
"-XX:+UseGCLogFileRotation". The name of the switch contains a typo
*and* is wrong.

Sorry to not have seen this earlier (did not review the webrev).

Regards,

Rainer