Review request: 6918185 Remove unused code for lost card-marking optimization in BacktraceBuilder (S)

David Holmes David.Holmes at oracle.com
Mon Jun 13 22:51:05 UTC 2011


Hi Bengt,

Looks okay to me.

David

Bengt Rutisson said the following on 06/14/11 06:45:
> 
> Hi Runtime and GC teams,
> 
> Could I have a couple of reviews for this simple change to remove some 
> dead code?
> 
> I am sending this request to both the runtime and GC teams, since it is 
> a change in runtime code but I will be pushing it through hotspot-gc.
> 
> I discussed this with Ramki and Coleen. This is not an optimization that 
> will be implemented any time soon and Coleen was intending to close the 
> CR as WNF at some point. However, there is some dead code left from the 
> orginal fix, so I re-purposed the CR to remove this dead code.
> 
> Webrev:
> http://cr.openjdk.java.net/~brutisso/CR6918185-b/webrev.0/
> 
> CR:
> 6918185 Remove unused code for lost card-marking optimization in 
> BacktraceBuilder
> http://monaco.sfbay.sun.com/detail.jsf?cr=6918185
> 
> Thanks,
> Bengt
> 



More information about the hotspot-gc-dev mailing list