Review request: 6918185 Remove unused code for lost card-marking optimization in BacktraceBuilder (S)

Bengt Rutisson bengt.rutisson at oracle.com
Tue Jun 14 07:21:12 UTC 2011


David, Ramki and Coleen,

Thanks for your reviews. I'm all set to push this now.

Bengt

On 2011-06-14 01:51, Coleen Phillimore wrote:
> Looks good.  Thanks for doing this cleanup!
> Coleen
>
> On 6/13/2011 4:45 PM, Bengt Rutisson wrote:
>>
>> Hi Runtime and GC teams,
>>
>> Could I have a couple of reviews for this simple change to remove 
>> some dead code?
>>
>> I am sending this request to both the runtime and GC teams, since it 
>> is a change in runtime code but I will be pushing it through hotspot-gc.
>>
>> I discussed this with Ramki and Coleen. This is not an optimization 
>> that will be implemented any time soon and Coleen was intending to 
>> close the CR as WNF at some point. However, there is some dead code 
>> left from the orginal fix, so I re-purposed the CR to remove this 
>> dead code.
>>
>> Webrev:
>> http://cr.openjdk.java.net/~brutisso/CR6918185-b/webrev.0/
>>
>> CR:
>> 6918185 Remove unused code for lost card-marking optimization in 
>> BacktraceBuilder
>> http://monaco.sfbay.sun.com/detail.jsf?cr=6918185
>>
>> Thanks,
>> Bengt
>>




More information about the hotspot-gc-dev mailing list