CRR (S / cosmetic): 7055073: G1: code cleanup in the concurrentMark.* files
Tony Printezis
tony.printezis at oracle.com
Mon Jun 20 21:39:22 UTC 2011
(I already got a comment on this, so I'd better clarify...) The only
time I skip the curly brackets is if the if-body has a single return,
break, or continue statement:
if (foo) return true;
I feel the code highlighting makes the keyword stand-out. If folks hate
it I can put curly brackets on those too.
Tony
On 06/20/2011 05:22 PM, Tony Printezis wrote:
> Hi all,
>
> When I recently worked on the concurrentMark.* files I was a bit
> annoyed that the style in those files doesn't quite match what's done
> in the rest of G1. In particular, we have a lot of instances of:
>
> if (condition)
> statement
>
> (i.e. without curly brackets) which I found particularly irritating. I
> did a cleanup pass to try to bring the file a bit more in order with
> the rest. Here's the webrev:
>
> http://cr.openjdk.java.net/~tonyp/7055073/webrev.0/
>
> I'll only need one code review for this. Thanks.
>
> Tony
>
>
More information about the hotspot-gc-dev
mailing list