CRR (S / cosmetic): 7055073: G1: code cleanup in the concurrentMark.* files

Y. Srinivas Ramakrishna y.s.ramakrishna at oracle.com
Tue Jun 21 02:04:00 UTC 2011


Looks fine. (Cosmetic all right, but definitely not small :-) I am glad
you did this as a separate CR!)

-- ramki

On 6/20/2011 2:22 PM, Tony Printezis wrote:
> Hi all,
>
> When I recently worked on the concurrentMark.* files I was a bit annoyed that the style in those
> files doesn't quite match what's done in the rest of G1. In particular, we have a lot of instances of:
>
> if (condition)
> statement
>
> (i.e. without curly brackets) which I found particularly irritating. I did a cleanup pass to try to
> bring the file a bit more in order with the rest. Here's the webrev:
>
> http://cr.openjdk.java.net/~tonyp/7055073/webrev.0/
>
> I'll only need one code review for this. Thanks.
>
> Tony
>
>




More information about the hotspot-gc-dev mailing list