RFR(S): 7111795: G1: Various cleanups identified during walk through of changes for 6484965

[Tony Printezis]

John,

Thanks for doing the cleanup. It's fine, one minor issue:

1989   G1CMParKeepAliveAndDrainClosure(ConcurrentMark* cm, CMTask* task) :
1990     _cm(cm), _task(task),


1991     _ref_counter_limit(G1RefProcDrainInterval)
1992   {
1993     assert(_ref_counter_limit>  0, "sanity");
1994     _ref_counter = _ref_counter_limit;
1995   }


maybe:

1991     _ref_counter_limit(G1RefProcDrainInterval) {
1992     assert(_ref_counter_limit>  0, "sanity");
1993     _ref_counter = _ref_counter_limit;
1994   }


And one stylistic question: do you prefer this style for an empty 
constructor:

class A {
   int _a, _b, _c;
   A() : _a(0), _b(0), _c(0)
    { }
};

over this?

class A {
   int _a, _b, _c;
   A() : _a(0), _b(0), _c(0) { }
};

I would recommend the latter myself, given that it saves an extra line.

Tony

On 11/15/2011 12:45 PM, John Cuthbertson wrote:
> Hi Everyone,
>
> Can I have a couple of volunteers look over these changes? The webrev 
> can be found at: http://cr.openjdk.java.net/~johnc/7111795/webrev.0/
>
> Summary:
> During a code walkthrough of the original set of changes for 6484965 
> ("piggy-back liveness accounting on marking") a few loosely related 
> cleanups were identified. I have decided to send these out as a 
> separate set of changes.
>
> Testing: the GC test suite and KitchenSink on Solaris and Linux with a 
> low marking threshold (10%).
>
> Thanks,
>
> JohnC