hg: hsx/hotspot-gc/hotspot: 7110173: GCNotifier::pushNotification publishes stale data.

john.cuthbertson at oracle.com john.cuthbertson at oracle.com
Mon Nov 21 20:01:25 UTC 2011


Changeset: b5a5f30c483d
Author:    johnc
Date:      2011-11-21 09:24 -0800
URL:       http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/b5a5f30c483d

7110173: GCNotifier::pushNotification publishes stale data.
Summary: GCNotifier::pushNotification() references GCMemoryManager::_last_gc_stat but is called from GCMemoryManager::gc_end() before GCMemoryManager::_last_gc_stat is set up using the values in GCMemoryManager::_current_gc_stat. As a result the GC notification code accesses unitialized or stale data. Move the notification call after GCMemoryManager::_las_gc_stat is set, but inside the same if-block.
Reviewed-by: poonam, dholmes, fparain, mchung

! src/share/vm/services/memoryManager.cpp




More information about the hotspot-gc-dev mailing list