Request for review (xs) - 7112997

[Srinivas Ramakrishna]

Looks good. Didn't realize that mark_and_follow() had been dead for so
long! :-)

reviewed!
-- ramki (ysr)

On Mon, Nov 28, 2011 at 10:24 AM, Jon Masamitsu <jon.masamitsu at oracle.com>wrote:

> Bengt,
>
> Thanks for the review.  I've made your suggested changes and
> also removed some additional dead code (unused mark_and_follow()
> methods) suggested by another reviewer.  New webrev is at
>
> http://cr.openjdk.java.net/~**jmasa/7112997/webrev.01<http://cr.openjdk.java.net/%7Ejmasa/7112997/webrev.01>
>
> Jon
>
>
> On 11/27/11 23:38, Bengt Rutisson wrote:
>
>>
>> Jon,
>>
>> I think you removed the only calls to ParCompactionManager::should_**verify_only()
>> and ParCompactionManager::should_**reset_only(). Can you remove those
>> methods as well? That will propagate to removing the enum values
>> VerifyUpdate and ResetObjects in ParCompactionManager::Action.
>>
>> Other than that it looks good.
>>
>> Thanks for doing cleanups like this one!
>> Bengt
>>
>> On 2011-11-23 20:24, Jon Masamitsu wrote:
>>
>>> 7112997: Remove obsolete code ResetObjectsClosure and VerifyUpdateClosure
>>> Summary: Remove obsolete code.
>>>
>>> This was debugging code that used  the MarkSweep code to check
>>> the UseParallelOldGC  compaction.   It has been broken for sometime
>>> and there are no prospects for fixing it.
>>>
>>> http://cr.openjdk.java.net/~**jmasa/7112997/webrev.00/<http://cr.openjdk.java.net/%7Ejmasa/7112997/webrev.00/>
>>>
>>> Thanks.
>>>
>>>
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/hotspot-gc-dev/attachments/20111128/2439d3f1/attachment.htm>