Request for review (xs) - 7112997

[Jon Masamitsu]

On 11/28/2011 11:20 PM, Bengt Rutisson wrote:
>
> Jon,
>
> Looks good!
>
> Copyright year needs to be updated in psCompactionManager.cpp, 
> psCompactionManager.hpp, markSweep.hpp and markSweep.inline.hpp... :-)

Done.  Thanks again.

Jon
>
> Bengt
>
> On 2011-11-28 19:24, Jon Masamitsu wrote:
>> Bengt,
>>
>> Thanks for the review.  I've made your suggested changes and
>> also removed some additional dead code (unused mark_and_follow()
>> methods) suggested by another reviewer.  New webrev is at
>>
>> http://cr.openjdk.java.net/~jmasa/7112997/webrev.01
>>
>> Jon
>>
>> On 11/27/11 23:38, Bengt Rutisson wrote:
>>>
>>> Jon,
>>>
>>> I think you removed the only calls to 
>>> ParCompactionManager::should_verify_only() and 
>>> ParCompactionManager::should_reset_only(). Can you remove those 
>>> methods as well? That will propagate to removing the enum values 
>>> VerifyUpdate and ResetObjects in ParCompactionManager::Action.
>>>
>>> Other than that it looks good.
>>>
>>> Thanks for doing cleanups like this one!
>>> Bengt
>>>
>>> On 2011-11-23 20:24, Jon Masamitsu wrote:
>>>> 7112997: Remove obsolete code ResetObjectsClosure and 
>>>> VerifyUpdateClosure
>>>> Summary: Remove obsolete code.
>>>>
>>>> This was debugging code that used  the MarkSweep code to check
>>>> the UseParallelOldGC  compaction.   It has been broken for sometime
>>>> and there are no prospects for fixing it.
>>>>
>>>> http://cr.openjdk.java.net/~jmasa/7112997/webrev.00/
>>>>
>>>> Thanks.
>>>>
>>>
>