Request for review (L) - 6593758

Rainer Jung rainer.jung at kippdata.de
Thu Oct 27 09:09:56 UTC 2011


On 27.10.2011 01:11, Jon Masamitsu wrote:
> 6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
> 
> http://cr.openjdk.java.net/~jmasa/6593758/webrev.00/

Interesting feature. Trivial remark:

+  product(uintx, HeapSizePerGCThread, ScaleForWordSize(64*M),
     \
+          "Size of heap per GC thread used in calculating the "
     \
+          "numnber of GC threads")
     \

Typo: numnber -> number

Also: it might be nice to add, which units are used (size in MB or is it
in Bytes, does it support the usual scaling suffixes for memory sizes?)

Regards,

Rainer




More information about the hotspot-gc-dev mailing list