(resend) Re: Request for review (S): 7130974 G1: Remove G1ParCopyHelper
Bengt Rutisson
bengt.rutisson at oracle.com
Mon Apr 2 06:08:17 UTC 2012
Hi John,
Thanks for the review! All set to push this now.
Bengt
On 2012-03-30 18:31, John Cuthbertson wrote:
> Hi Bengt,
>
> Looks good to me. Ship it.
>
> JohnC
>
> On 03/30/12 06:22, Bengt Rutisson wrote:
>>
>> Hi all,
>>
>> Tony has reviewed this, but I still need one more a review. Any
>> takers? It's a pretty small change...
>>
>> Bengt
>>
>> On 2012-03-13 12:49, Bengt Rutisson wrote:
>>>
>>> Hi all,
>>>
>>> Could I have a couple of reviews of this small code clean up?
>>>
>>> http://cr.openjdk.java.net/~brutisso/7130974/webrev.00/
>>>
>>> Using templates it is possible to get rid of the extra inheritance
>>> level introduced by G1ParCopyHelper. This also removes a dependency
>>> between G1ParCopyHelper and G1ParCopyClosure regarding how the
>>> _scanner field is initialized.
>>>
>>> Bug report:
>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7130974
>>>
>>> Thanks,
>>> Bengt
>>
>
More information about the hotspot-gc-dev
mailing list