Request for review (S): 4988100: oop_verify_old_oop appears to be dead

[Alex Lam S.L.]

src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp

  can _allow_dirty in G1ParVerifyTask be removed?


Alex.



On Fri, Apr 13, 2012 at 5:53 PM, Bengt Rutisson
<bengt.rutisson at oracle.com> wrote:
>
> Jon,
>
> Thanks for the review! Anybody else feel like taking a look? You all heard
> Jon: with the Next link it is easy to review this :-)
>
> Bengt
>
>
> On 2012-04-13 18:31, Jon Masamitsu wrote:
>>
>> Bengt,
>>
>> This looks good and it's a nice clean up.  And thanks for redoing the
>> webrev.  Having the "Next" link on each page made it even more
>> convenient than I expected.
>>
>> Jon
>>
>> On 4/10/2012 6:13 PM, Bengt Rutisson wrote:
>>>
>>>
>>> Hi all,
>>>
>>> Could I have a couple of reviews for this small change (a lot of files,
>>> but very simple):
>>>
>>> http://cr.openjdk.java.net/~brutisso/4988100/webrev.00/
>>>
>>> While going through old CRs we found this one that stated that
>>> oop_verify_old_oop() was unused as well as the allow_dirty parameter that is
>>> being passed around. I'd like to fix it to be able to close the CR.
>>>
>>> Thanks,
>>> Bengt
>
>