Review request (XS) 7160613: VerifyRememberedSets doesn't work with CompressedOops

[Stefan Karlsson]

On 04/12/2012 01:58 AM, Bengt Rutisson wrote:
>
> Stefan,
>
> Looks good to me.
>
> One question, the non-compressed oop version of 
> oopDesc::load_decode_heap_oop_not_null() does not check that the oop 
> is not null. It will just get a nullpointer I guess:
>
> inline oop oopDesc::load_decode_heap_oop_not_null(oop* p)       { 
> return *p; }
>
> Would it be worth to add an assert that p != NULL just to be 
> consistent with the compressed oops version?

Maybe, but I'll not add that in this changeset.

thanks,
StefanK

>
> Bengt
>
> On 2012-04-11 17:57, Stefan Karlsson wrote:
>> http://cr.openjdk.java.net/~stefank/7160613/webrev/
>>
>> CheckForUnmarkedOops uses oopDesc::load_decode_heap_oop_not_null, 
>> which asserts because some oops are in fact pointing to NULL. I 
>> changed it to use oopDesc::load_decode_heap_oop instead.
>>
>> StefanK
>