Request for review (XXS): 7193157: G1: Make some develpflags available in product builds

[Bengt Rutisson]

Hi Vitaly,

Thanks for looking at this.

On 2012-08-22 14:27, Vitaly Davidovich wrote:
>
> Looks good.  One small typo:
>
> experimental(uintx, G1OldCSetRegionLiveThresholdPercent, 90,
>
> "Threshold for regions to be added to the collection set. "
>
> "Regions with more live bytes that this will not be collected.")
>
> The "that this" should be "than this".
>

Absolutely. Fixed.

Thanks,
Bengt

> Cheers
>
> Sent from my phone
>
> On Aug 22, 2012 3:50 AM, "Bengt Rutisson" <bengt.rutisson at oracle.com 
> <mailto:bengt.rutisson at oracle.com>> wrote:
>
>
>     Hi all,
>
>     Could I please have a couple of reviews for this really small fix?
>     http://cr.openjdk.java.net/~brutisso/7193157/webrev.00/
>     <http://cr.openjdk.java.net/%7Ebrutisso/7193157/webrev.00/>
>
>     We need to make some of the G1 develop flags available in product
>     builds to allow the performance team to tune G1 properly. We
>     decided to make the flags experimental to start with. After the
>     performance team has evaluated the flags we might make some of
>     them product flags. The current prime candidates for becoming
>     product flags are:
>
>     G1DefaultMinNewGenPercent
>     G1DefaultMaxNewGenPercent
>     G1OldCSetRegionLiveThresholdPercent
>
>     Thanks,
>     Bengt
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/hotspot-gc-dev/attachments/20120822/b89b1692/attachment.htm>