review request 7140866: assert(covered) failed: Card for end of new region not committed

[Srinivas Ramakrishna]

Looks good to me.

-- ramki (openjdk: ysr)

On Mon, Feb 13, 2012 at 2:09 PM, Dean Long <dean.long at oracle.com> wrote:

> http://bugs.sun.com/**bugdatabase/view_bug.do?bug_**id=7140866<http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7140866>
>
> http://cr.openjdk.java.net/~**dlong/7140866/webrev.00/<http://cr.openjdk.java.net/%7Edlong/7140866/webrev.00/>
>
> The problem happens when trying to use a shared archive.  If for some
> reason mapping the shared file fails,
> we call
>
>    _rs->resize_covered_region(**MemRegion(shared_bottom, shared_bottom));
>
> to undo the earlier call to
>
>    _rs->resize_covered_region(**MemRegion(readonly_bottom,
> readwrite_end));
>
> Unfortunately the resize code is not prepared to deal with a zero-sized
> region so an assert fails.
> Rather than touch the resize code, this fix changes the caller to only
> call resize_covered_region()
> once after the shared file is mapped.
>
> Tested fix on a particular linux arm platform where the mmap fails 100% of
> the time due to a different issue.
> Ran -Xshare:dump first then a few GC tests.
>
> dl
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/hotspot-gc-dev/attachments/20120214/124fc308/attachment.htm>