RFR(XXS): 7147806: G1: Crash in vm bootstrap when running with -XX:+UseG1GC -XX:-UsePerfData

[Bengt Rutisson]

Hi John,

On 2012-02-23 17:51, John Cuthbertson wrote:
> Hi Bengt,
>
> Thanks for looking at it. I'm not sure of the integration plan for 
> this but thought it would be better that it was ready (and low-risk 
> enough for hs23) in case we decide to include it.

I'm fine with it going into hs23. I was just wondering if it was worth 
the extra work of asking for release team approval since we have to do 
that now for hs23 stuff. Either way is fine with me.

Bengt

>
> JohnC
>
> On 2/22/2012 11:31 PM, Bengt Rutisson wrote:
>>
>> Looks good.
>>
>> What is the integration plan for this? The bug is a P4. Will you try 
>> to get it into hs23 or is it enough that this makes it into hs24?
>>
>> Bengt
>>
>> On 2012-02-22 21:10, John Cuthbertson wrote:
>>> Hi Everyone,
>>>
>>> Can I have a couple of volunteers to review the changes for this CR? 
>>> The webrev can be found at: 
>>> http://cr.openjdk.java.net/~johnc/7147806/webrev.0/
>>>
>>> The issues here was that some updates to the G1 performance counter 
>>> variables were not guarded. In the other collectors, the generation 
>>> and collector performance counters are allocated/initialized 
>>> unconditionally. The performance counter variables that these 
>>> counters contain, however, are allocated and updated only if 
>>> UsePerfData is enabled. In G1, some of these updates were not 
>>> suitably guarded and so we tried to update some unallocated 
>>> performance counter variables.
>>>
>>> Testing:
>>> * Small test case (gcbasher) with the offending command line flag 
>>> combination and with just G1.
>>>
>>> Thanks,
>>>
>>> JohnC
>>