Request for review (XXS): 7130334 G1: Change comments and error messages that refer to CMS in g1/concurrentMark.cpp/hpp

Bengt Rutisson bengt.rutisson at oracle.com
Mon Jan 16 10:36:44 UTC 2012


Hi all,

Can I have a couple of reviews for this really small and simple change:
http://cr.openjdk.java.net/~brutisso/7130334/webrev.01/

Background
Charlie Hunt got the following error message when he was running low on 
native memory while using G1: "failed: couldn't reseve backing store for 
CMS bit map". Kind of a strange to mention CMS  when you are using G1.

The error comes from concurrentMark.cpp and it turns out that there were 
a couple of error messages and some comments there that mention CMS. I 
removed some of the comments and updated others to say "concurren 
marking" which I think is more what was intended.

I have been searching the rest of the G1 code for references to CMS, but 
the other places I have found seem correct. So, this issue seems to only 
concern concurrentMark.cpp/hpp.

CR:
7130334 G1: Change comments and error messages that refer to CMS in 
g1/concurrentMark.cpp/hpp
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7130334
http://monaco.sfbay.sun.com/detail.jsf?cr=7130334

Bengt



More information about the hotspot-gc-dev mailing list