CRR (XXS): 7078465: G1: Don't use the undefined value (-1) for the G1 old memory pool max size

Tony Printezis tony.printezis at oracle.com
Tue Jan 17 20:47:26 UTC 2012


Bengt,

Good point, I'll add it to the change and do some more testing before 
publishing a new webrev. Thanks,

Tony

On 01/17/2012 07:28 AM, Bengt Rutisson wrote:
>
> Hi Tony,
>
> This looks good! :-)
>
> One question. The CR says "Similarly, we should consider setting the 
> old minimum capacity to the heap minimum capacity. This is only used 
> by jstat and currently we set the minimum capacity of all the spaces 
> to 0.". Do you want to do that as well?
>
> Bengt
>
> On 2012-01-12 16:51, Tony Printezis wrote:
>> Hi all,
>>
>> I'd like a couple of code reviews for this very small  change (one 
>> line!):
>>
>> http://cr.openjdk.java.net/~tonyp/7078465/webrev.0/
>>
>> Currently, all the G1 memory pools return "undefined" (-1) as their 
>> max size given that there are no hard boundaries between them. Jon 
>> Masamitsu suggested to at least return the heap max for the old 
>> memory pool so that the pool data is a little bit more informative.
>>
>> Tony
>>
>



More information about the hotspot-gc-dev mailing list