Review request (S): 7131791 G1: Asserts in nightly testing due to 6976060

Bengt Rutisson bengt.rutisson at oracle.com
Fri Jan 20 16:43:29 UTC 2012


Hi again,

Here is an updated webrev based on some comments from Tony. The code 
comments were updated and I pass false as the zap parameter to 
CollectedHeap::fill_with_object(result, word_size, false);

Thanks Tony for the review!
Bengt

On 2012-01-20 17:06, Bengt Rutisson wrote:
>
> Hi all,
>
> Can I have a couple of quick reviews for this small change:
> http://cr.openjdk.java.net/~brutisso/7131791/webrev.02
>
> This should hopefully fix the 500+ failures in the G1 nightlies. So, I 
> would like to get it in before the nightlies tonight.
>
> The issue is that we call collect() which will trigger a collection 
> without protecting the memory that we just allocated for a humongous 
> object. The fix (thanks Tony for helping me out!!!) is to fake an 
> object and create a handle to it before we call collect.
>
> Bengt




More information about the hotspot-gc-dev mailing list