RFR(XS): 7129514: time warp warnings after 7117303

[Srinivas Ramakrishna]

Looks good. (As in earlier review, I wish the duplication of comment and
code could be minimized via consolidation into a suitable new method
definition ...)

- ramki

On Wed, Jan 18, 2012 at 11:38 AM, John Cuthbertson <
john.cuthbertson at oracle.com> wrote:

> Hi Everyone,
>
> I forgot to include the webrev link: http://cr.openjdk.java.net/~**
> johnc/7129514/webrev.0/<http://cr.openjdk.java.net/%7Ejohnc/7129514/webrev.0/>
>
> Thanks to Ramki for pointing this out.
>
> JohnC
>
>
> On 1/18/2012 10:08 AM, John Cuthbertson wrote:
>
>> Hi Everyone,
>>
>> While making the changes for 711303, I missed a few calls to
>> os::javaTimeMillis() (specifically with updating the time since the last
>> GC). As a consequence we can still see the occasional time-warp warning.
>> The issue is that os::javaTimeMillis() returns values that are not
>> guaranteed to be monotonically non-decreasing and so they can go backwards.
>>  I've replaced these calls to an equivalent that uses os::javaTimeNanos(),
>> which will return values that are monotonically non-decreasing if the
>> underlying system time source supports such a mode.
>>
>> Many thanks to David Holmes for diagnosing the issue.
>>
>> Thanks,
>>
>> JohnC
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/hotspot-gc-dev/attachments/20120122/1da50cd8/attachment.htm>