RFR - 7154517: Build error in hotspot-gc without precompiled headers

[Nils Loodin]

Good question, I was wondering this myself.
I don't know enough about the gc workings, but I was guessing that those files perhaps weren't used on solaris?

I don't have a clue, but I guess that's the reason that the bug is still in the code. Normally it's the other way around, your code not compiling at all on solaris due to no pch..

/Nisse

On Mar 19, 2012, at 14:34 , Bengt Rutisson wrote:

> 
> Nils,
> 
> I think your change looks fine, but I have a question.
> 
> Even before your change this would build on Solaris, right? But it will not build if you turn precompiled headers off. Since Solaris is not using precompiled headers, how did it build on Solaris?
> 
> It seems to me like there is another bug lurking here. Can it be that some Solaris-specific files somehow has precompiled.hpp in the transitive set of its include files? Seems strange to me.
> 
> Bengt
> 
> 
> On 2012-03-16 16:25, Nils Loodin wrote:
>> Debugging a precompiled header on solaris issue by trying to build without precompiled headers locally from the gc repo. And it didn't work! :)
>> 
>> Here's a pretty easy fix!
>> 
>> http://cr.openjdk.java.net/~nloodin/7154517/webrev.00/
>> 
>> Regards
>> Nils Loodin
>