Request for review (M): 7172388: G1: _total_full_collections should not be incremented for concurrent cycles

Bengt Rutisson bengt.rutisson at oracle.com
Tue May 29 11:48:25 UTC 2012


Hi all,

Can I have a couple of reviews for this change?
http://cr.openjdk.java.net/~brutisso/7172388/webrev.00/

Background:
CollectedHeap::total_full_collections() should keep track of the number 
of full GCs. At least that is what all collectors except G1 does. G1 
also counts the concurrent marking cycles as full collections.

This change will make G1 behave like the other collectors with regards 
to CollectedHeap::total_full_collections().

Testing:
- JPRT
- UTE on a Linux x64 host using these test lists:
      nsk.monitoring.testlist
      vm.tmtools.testlist
      java/lang/management
      com/sun/management
      sun/management

Also, Matherey had written a Whitebox API test that used 
CollectedHeap::total_full_collections() to find out how many full GCs 
that were performed. This test always failed with G1. With my proposed 
change that test works fine with G1 as well.

Thanks,
Bengt



More information about the hotspot-gc-dev mailing list