Request for review (1 line) - 7186847

[Mikael Gerdin]

Jon,

On 2012-10-06 00:12, Jon Masamitsu wrote:
> 7186847: NPG: Use large pages for metadata allocations
>
> http://cr.openjdk.java.net/~jmasa/7186847/webrev.00/

The fix makes sense, but I wonder how many of the allocations coming in 
through the VirtualSpaceNode constructor are large enough to make use of 
 >4K pages?
Since medium chunks are 8K words it looks like only humongous 
allocations will cause large pages to be allocated. Are humongous 
metaspace allocations even common enough to warrant the increased 
"complexity" of the code?
I'm not saying that your fix is making the code itself more complex, but 
it may be misleading people reading it into thinking that large page 
size allocations are being used when actually they are not.

/Mikael

>
> Thanks.
>
> Jon

-- 
Mikael Gerdin
Java SE VM SQE Stockholm