Request for review (xs) - 8001584

[Jon Masamitsu]

Thanks, John.  You saved yourself and others from
hearing my whining about this.

Jon

On 10/25/12 11:28, John Cuthbertson wrote:
> Hi Jon,
>
> Looks good.
>
> JohnC
>
> On 10/25/2012 8:18 AM, Jon Masamitsu wrote:
>> 8001584: NPG: Incorrect assertion in BinaryTreeDictionary::get_chunk()
>>
>> The assertion
>>
>>      assert(dither != FreeBlockDictionary<Chunk_t>::exactly ||
>>            res->size() == size, "Not correct size");
>>
>> does not take into account that res may be NULL (as the assertion
>> above it does).
>>
>> http://cr.openjdk.java.net/~jmasa/8001584/webrev.00/
>>
>> or the diff
>>
>> --- a/src/share/vm/memory/binaryTreeDictionary.hpp
>>
>> +++ b/src/share/vm/memory/binaryTreeDictionary.hpp
>>
>> @@ -259,7 +259,7 @@
>>
>>      assert(res == NULL || res->is_free(),
>>
>>             "Should be returning a free chunk");
>>
>>      assert(dither != FreeBlockDictionary<Chunk_t>::exactly ||
>>
>> -           res->size() == size, "Not correct size");
>>
>> +           res == NULL || res->size() == size, "Not correct size");
>>
>>      return res;
>>
>>    }
>>
>> Thanks.
>>
>> Jon