Request for review (xs) - 8001584

[Srinivas Ramakrishna]

Looks good to me.

-- ramki

On Thu, Oct 25, 2012 at 8:18 AM, Jon Masamitsu <jon.masamitsu at oracle.com>wrote:

> 8001584: NPG: Incorrect assertion in BinaryTreeDictionary::get_**chunk()
>
> The assertion
>
>      assert(dither != FreeBlockDictionary<Chunk_t>::**exactly ||
>            res->size() == size, "Not correct size");
>
> does not take into account that res may be NULL (as the assertion
> above it does).
>
> http://cr.openjdk.java.net/~**jmasa/8001584/webrev.00/<http://cr.openjdk.java.net/%7Ejmasa/8001584/webrev.00/>
>
> or the diff
>
> --- a/src/share/vm/memory/**binaryTreeDictionary.hpp
>
> +++ b/src/share/vm/memory/**binaryTreeDictionary.hpp
>
> @@ -259,7 +259,7 @@
>
>      assert(res == NULL || res->is_free(),
>
>             "Should be returning a free chunk");
>
>      assert(dither != FreeBlockDictionary<Chunk_t>::**exactly ||
>
> -           res->size() == size, "Not correct size");
>
> +           res == NULL || res->size() == size, "Not correct size");
>
>      return res;
>
>    }
>
> Thanks.
>
> Jon
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/hotspot-gc-dev/attachments/20121025/5a3a37d9/attachment.htm>