RFR (S): 8001564: The load balancing function steal_1_random in taskqueue is not random

[Bengt Rutisson]

Erik,

Looks good!

Good to remove untested code that has already started to bit rot.

Bengt


On 2012-10-26 09:45, Erik Helin wrote:
> Hi everyone,
>
> the webrev can be found at:
>
> http://cr.openjdk.java.net/~brutisso/8001564/webrev.00/
>
> Summary:
> There are three different algorithms in taskqueue.hpp for stealing an 
> item from a taskqueue:
> - steal_best_of_2
> - steal_best_of_all
> - steal_1_random
>
> However only steal_best_of_2 is currently in use, steal_best_of_all 
> and steal_1_random are not used at all (not anywhere in the hotspot 
> source code).
>
> Furthermore the function steal_1_random has a bug in it, as explained 
> in 8001564.
>
> This change removes the functions steal_best_of_all and 
> steal_1_random, thereby preventing bit rot as in the case of 
> steal_1_random and also fixing bug 8001564.
>
> Testing:
> JPRT
>
> Thanks,
> Erik