RFR (S): 8012102: CollectedHeap::ensure_parsability is not always called during heap inspection

Mikael Gerdin mikael.gerdin at oracle.com
Mon Apr 15 08:30:32 UTC 2013


Erik,

On 2013-04-15 09:01, Erik Helin wrote:
> Hi all,
>
> this change fixes a bad refactoring. The method
> CollectedHeap::ensure_parsability must always be called prior to doing
> performing a heap inspection (to be able to traverse TLABs).
>
> A previous change refactored the code so that the method was only called
> if a full GC was requested before the heap inspection.
>
> Webrev:
> http://cr.openjdk.java.net/~ehelin/8012102/webrev.00/

This looks good,
can you please update the comment about calling ensure_parsability to 
mention that the call is also needed even if _full_gc is not set.
That will make the entire change self-explanatory.

I'm fine with you changing the comment and pushing without sending out a 
new webrev.

/Mikael

>
> Bug:
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8012102
>
> Thanks,
> Erik
>



More information about the hotspot-gc-dev mailing list