RFR (S): 8012102: CollectedHeap::ensure_parsability is not always called during heap inspection

[Erik Helin]

On 04/15/2013 12:47 PM, Stefan Karlsson wrote:
> On 04/15/2013 09:01 AM, Erik Helin wrote:
>> Hi all,
>>
>> this change fixes a bad refactoring. The method
>> CollectedHeap::ensure_parsability must always be called prior to doing
>> performing a heap inspection (to be able to traverse TLABs).
>>
>> A previous change refactored the code so that the method was only
>> called if a full GC was requested before the heap inspection.
>>
>> Webrev:
>> http://cr.openjdk.java.net/~ehelin/8012102/webrev.00/
>
> The revert looks good.

Thanks!

On 04/15/2013 12:47 PM, Stefan Karlsson wrote:
> I find it odd that we call ensure_parsability() before the full gc
> instead of directly before the heap_inspection. But that's what the code
> looked before your previous changes.

Agree, it would be good look into as part of a future change.

Thanks,
Erik

> thanks,
> StefanK
>
>> Bug:
>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8012102
>>
>> Thanks,
>> Erik
>>
>