Request for review (XS): 8012455: Missing time and date stamps for PrintGCApplicationConcurrentTime and PrintGCApplicationStoppedTime

[Bengt Rutisson]

Thanks, Leonid!

I updated the bug to have the noreg-hard tag.

Bengt

On 4/17/13 3:37 PM, Leonid Mesnik wrote:
> Bengt
>
> Thank you for tagging issue.
> I think noreg-sqe is not correct. The fix is not really covered by 
> existing tests.
> However noreg-hard could be used here. (Hard to develop stable test)
>
> Leonid
>
> On 04/17/2013 05:10 PM, Bengt Rutisson wrote:
>>
>> On 4/17/13 2:31 PM, Coleen Phillimore wrote:
>>>
>>> I think this is noreg-sqe ?   Do you have a pointer to this document?
>>> Here is the pointer to the description for labels for regression or no
>>> regression tests on fixed bugs:
>>>
>>> http://openjdk.java.net/guide/changePlanning.html#bug
>>>
>>> See Step #6
>>
>> Thanks, Coleen!
>>
>> I tagged the bug with noreg-sqe and added a comment.
>>
>> Bengt
>>
>>>
>>> Coleen
>>>
>>> On 4/17/2013 7:01 AM, Bengt Rutisson wrote:
>>>>
>>>> Leonid,
>>>>
>>>> Thanks for looking at this.
>>>>
>>>> On 4/17/13 12:16 PM, Leonid Mesnik wrote:
>>>>> Bengt
>>>>>
>>>>> Could you please add a unit test for this fix.
>>>>
>>>> I am not too keen on writing a test for this. I see your point, but 
>>>> the fix is very small and we already have lots of code that does 
>>>> the same thing without any tests. If we should add a test I think 
>>>> it should be for PrintGCTimeStamps and PrintGCDateStamps in 
>>>> general. However, I don't think our logging is parsable enough to 
>>>> make such a test stable. Timestamps can get mixed in in the middle 
>>>> of lines and unexpected messages can be logged at almost any point 
>>>> in time.
>>>>
>>>> Thanks,
>>>> Bengt
>>>>
>>>>
>>>>
>>>>>
>>>>> Leonid
>>>>> On 04/17/2013 12:47 PM, Bengt Rutisson wrote:
>>>>>>
>>>>>> Hi all,
>>>>>>
>>>>>> Can I have a couple of reviews for this very small change?
>>>>>>
>>>>>> http://cr.openjdk.java.net/~brutisso/8012455/webrev.00/
>>>>>>
>>>>>> Background
>>>>>>
>>>>>> A customer commented that it is hard to coordinate the 
>>>>>> information from PrintGCApplicationConcurrentTime and 
>>>>>> PrintGCApplicationStoppedTime with the information from PrintGC 
>>>>>> and PrintGCDetails in stable way since the former flags don't 
>>>>>> include timestamps.
>>>>>>
>>>>>> This patch adds time and date stamps to the output from 
>>>>>> PrintGCApplicationConcurrentTime and PrintGCApplicationStoppedTime.
>>>>>>
>>>>>> Thanks,
>>>>>> Bengt
>>>>>
>>>>>
>>>>
>>>
>>
>
>
> -- 
> Leonid Mesnik
> JVM SQE

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/hotspot-gc-dev/attachments/20130418/6133cc97/attachment.htm>