Request for review(s) - 8012111: Remove warning about CMS generation shrinking.

[Jon Masamitsu]

On 4/21/13 10:33 PM, Bengt Rutisson wrote:
>
> Hi Jon,
>
> Looks good!
>
> A few minor nits in the JTreg test:
>
> - I think the "@test" line should have the test name in it. So, "@test 
> GuardShrinkWarning".
Fixed.
>
> - I don't think you need the "Go" parameter on line 45.

Deleted.

>
> - Why do you need the loop in SystemGCCaller to do 50 System.gc() 
> calls? I think the warning is printed for every GC, so one System.gc() 
> call should be enough, right?

I had thought that the call to System.gc() would return before the 
concurrent
collection finished but that's not the case.  I've removed the loop



>
> - Do you need the "garbage" that you create in SystemGCCaller? I also 
> think you can drop the System.println(".") call.

and I've removed the allocation of the array.

Thanks.

Jon
>
> Thanks,
> Bengt
>
>
> On 4/19/13 8:41 PM, Jon Masamitsu wrote:
>> 8012111: Remove warning about CMS generation shrinking.
>>
>> The warning message
>>
>> "Java HotSpot(TM) Server VM warning: Shrinking of CMS not yet 
>> implemented"
>>
>> should not generally be emitted.  Guard it with PrintGCDetails and 
>> Verbose.
>>
>> http://cr.openjdk.java.net/~jmasa/8012111/webrev.00/
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/hotspot-gc-dev/attachments/20130422/9ee407e8/attachment.htm>