Review request: 8013132: Add a flag to turn off the output of the verbose verification code

[John Cuthbertson]

Hi Stefan,

Looks fine to me.

One minor point - this will affect the reg test I sent out for review 
yesterday which explicitly looks for "[Verifying..."

JohnC

On 4/24/2013 11:12 AM, Stefan Karlsson wrote:
> http://cr.openjdk.java.net/~stefank/8013132/webrev.00/
>
> This RFE adds a new flag named VerifySilently, which can be used to 
> turn off the verbose output that the verification code produces. The 
> proposed name has been chosen to match other Verify flags.
>
> From the Bug description:
> ---
> The HotSpot verification code is rather verbose and intrusive. I 
> propose that we add a flag that can be used to turn this output off.
>
> An example of the verification output:
> $ java -XX:+PrintGC -XX:+UnlockDiagnosticVMOptions 
> -XX:+VerifyBeforeExit -XX:+VerifyAfterGC -XX:+VerifyBeforeGC 
> -XX:+UseConcMarkSweepGC -XX:+ExplicitGCInvokesConcurrent -cp 
> /localhome/tests/ HelloSystemGC
>  VerifyBeforeGC:[Verifying threads heap concurrent mark-sweep 
> generation par new generation remset syms strs zone dict cldg 
> metaspace chunks hand C-heap code cache ]
> [GC (System.gc()) 672K->260K(121600K), 0.0060920 secs]
>  VerifyAfterGC:[Verifying threads heap concurrent mark-sweep 
> generation par new generation remset syms strs zone dict cldg 
> metaspace chunks hand C-heap code cache ]
> [Verifying threads heap concurrent mark-sweep generation par new 
> generation remset syms strs zone dict cldg metaspace chunks hand 
> C-heap code cache ]
> [GC (CMS Initial Mark) 260K(121600K), 0.0204040 secs]
> [Verifying threads heap concurrent mark-sweep generation par new 
> generation remset syms strs zone dict cldg metaspace chunks hand 
> C-heap code cache ]
> [Verifying threads heap concurrent mark-sweep generation par new 
> generation remset syms strs zone dict cldg metaspace chunks hand 
> C-heap code cache ]
> [GC (CMS Final Remark) [Verifying CMS Marking... done] 1604K(121600K), 
> 0.1008210 secs]
> [Verifying threads heap concurrent mark-sweep generation par new 
> generation remset syms strs zone dict cldg metaspace chunks hand 
> C-heap code cache ]
>
> And with the proposed flag turned on:
> [GC (System.gc()) 672K->269K(121600K), 0.0050710 secs]
> [GC (CMS Initial Mark) 269K(121600K), 0.0203380 secs]
> [GC (CMS Final Remark) 1613K(121600K), 0.1007210 secs]
> ---
>
> thanks,
> StefanK

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/hotspot-gc-dev/attachments/20130424/4f8cec24/attachment.htm>