Request for review - 8013184 CMS: Call reset_after_compaction() only if a compaction has been done

Mikael Gerdin mikael.gerdin at oracle.com
Mon Apr 29 15:05:32 UTC 2013


Jon,

On 2013-04-25 21:32, Jon Masamitsu wrote:
> 8013184: CMS: Call reset_after_compaction() only if a compaction has
> been done
>
> When a System.gc() is done with -XX:-UseCMSCompactAtFullCollection, a
> mark-sweep
> without compaction is done.  In that instance the call to
> reset_after_compaction() is
> not appropriate.
>
> This changeset is built on top of the changeset for 8013032
>
> http://cr.openjdk.java.net/~jmasa/8013184/webrev.00/

Could you change the name of the test to say something about using the 
"foreground" GC?
Maybe "SystemGCOnForegroundCollector"?
I don't think the "three times" is relevant enough to be included in the 
test name.

*_did_compact is only relevant for Full GCs, what would you say about 
changing it to "full_gc_did_compact" to make it obvious that the 
variable is only relevant for Full GCs?

/Mikael



More information about the hotspot-gc-dev mailing list