review request (M) - 8030646: track cset membership in one place

[Bengt Rutisson]

Hi John,

8030647-cset-rename-fast-test
8030648-cset-move-methods
8030649-cset-oop-in-cset
8030650-cset-rm-length

These all look good. No comments.

8030651-cset-unify-obj-in-cs

This is a nice cleanup. Thanks for fixing this!

I like the division between in_cset() and oop_in_cset(). Have you 
checked if there are more occurrences of in_cset() that could be 
replaced by oop_in_cset()? It looks to me like these in_cset() could be 
changed to oop_in_cset() in these two methods:

G1CollectedHeap::handle_evacuation_failure_par()
G1ParScanThreadState::verify_ref()

And I *think* G1STWIsAliveClosure::do_object_b() could also use 
oop_in_cset() too.

Thanks,
Bengt



On 2013-12-18 07:00, John Coomes wrote:
> Please review a set of changes to eliminate redundant cset membership
> tracking in g1:
>
> http://cr.openjdk.java.net/~jcoomes/8030646-cset-unify-all.html
>
> -John