RFR (S): JDK-8006432 - Ratio flags should be unsigned
Jesper Wilhelmsson
jesper.wilhelmsson at oracle.com
Thu Feb 7 12:38:55 UTC 2013
Thanks for looking at this. All set to push now :-)
/Jesper
On 6/2/13 12:41 AM, Tao Mao wrote:
> Looks good to me. I've manually checked all occurrences of the four
> flags. They are treated properly after the change.
> I'm not an official reviewer. But, as I understand, code reviewer needs
> at least one official reviewer. So, push it!
>
> Thanks.
> Tao
>
> On 1/25/2013 8:24 AM, Jesper Wilhelmsson wrote:
>> Hi John,
>>
>> Thanks for the review!
>> I have removed G1InitYoungSurvRatio and updated the webrev and the bug
>> to reflect this.
>> /Jesper
>>
>>
>> On 2013-01-25 01:27, John Cuthbertson wrote:
>>> Hi Jesper,
>>>
>>> Looks good to me.
>>>
>>> Can you also remove the unused G1InitYoungSurvRatio from g1_globals.hpp?
>>>
>>> Thanks,
>>>
>>> JohnC
>>>
>>> On 1/24/2013 1:45 PM, Jesper Wilhelmsson wrote:
>>>> Hi,
>>>>
>>>> I'm looking for a couple of reviews for this small change.
>>>>
>>>> Bug: JDK-8006432 - Ratio flags should be unsigned
>>>>
>>>> Webrev:
>>>> http://cr.openjdk.java.net/~jwilhelm/8006432/webrev/
>>>>
>>>> Summary:
>>>> Four flags whose contents are assumed to be unsigned were stored in
>>>> signed
>>>> variables. I have changed these to be unsigned instead.
>>>>
>>>> Testing:
>>>> Manual testing and JPRT.
>>>>
>>>> /Jesper
>>>
More information about the hotspot-gc-dev
mailing list