Request for review (S): 8006398: Add regression tests for deprectated GCs

[Bengt Rutisson]

Hi Leonid,

Thanks for noticing the java -X print out. I did not know about this.

If I understand this correctly java -X basically lists what is in this file:

jdk/src/share/classes/sun/launcher/resources/launcher.properties

This file seems to be internationalized, so there are several files for 
different languages.

At the moment I don't think we need to update all these files. The 
-Xincgc flag still works, it is just deprecated. But once we remove the 
flag we need to remember to remove it from all these files. Thanks for 
pointing this out.

Bengt

On 2/13/13 10:04 AM, Leonid Mesnik wrote:
> Hi
>
> During reviewing this I noticed that java -X was not updated. It shows:
> -->/java/re/jdk/8/promoted/all/b76/binaries/linux-amd64/bin/java -X
>     -Xmixed           mixed mode execution (default)
>     -Xint             interpreted mode execution only
>     -Xbootclasspath:<directories and zip/jar files separated by :>
>                       set search path for bootstrap classes and resources
>     -Xbootclasspath/a:<directories and zip/jar files separated by :>
>                       append to end of bootstrap class path
>     -Xbootclasspath/p:<directories and zip/jar files separated by :>
>                       prepend in front of bootstrap class path
>     -Xdiag            show additional diagnostic messages
>     -Xnoclassgc       disable class garbage collection
> *  -Xincgc           enable incremental garbage collection*
>     -Xloggc:<file>    log GC status to a file with time stamps
>     -Xbatch           disable background compilation
>     -Xms<size>        set initial Java heap size
>     -Xmx<size>        set maximum Java heap size
>     -Xss<size>        set java thread stack size
>     -Xprof            output cpu profiling data
>     -Xfuture          enable strictest checks, anticipating future default
>     -Xrs              reduce use of OS signals by Java/VM (see 
> documentation)
>     -Xcheck:jni       perform additional checks for JNI functions
>     -Xshare:off       do not attempt to use shared class data
>     -Xshare:auto      use shared class data if possible (default)
>     -Xshare:on        require using shared class data, otherwise fail.
>     -XshowSettings    show all settings and continue
>     -XshowSettings:all
>                       show all settings and continue
>     -XshowSettings:vm show all vm related settings and continue
>     -XshowSettings:properties
>                       show all property settings and continue
>     -XshowSettings:locale
>                       show all locale related settings and continue
>
> The -X options are non-standard and subject to change without notice. 
> However -Xincgc warn user about deprecation.
> Shouldn't we remove -Xincgc fron -X options or add warning there? 
> Could we find replacement for -Xincgc instead iCMS  in JDK 8?
>
> Leonid
>
> On 02/13/2013 12:11 PM, Bengt Rutisson wrote:
>>
>> Hi John,
>>
>> Thanks for looking at this!
>>
>> On 2/13/13 3:40 AM, Jon Masamitsu wrote:
>>> Bengt,
>>>
>>> Changes look good.
>>>
>>> You include tests for UseG1GC and UseParallelGC (should
>>> not print warnings) but not UseConcMarkSweepGC nor
>>> UseSerialGC.  Why the former but not the latter?
>>
>> The TestSerialGC.java is running with UseSerialGC. Am I missing 
>> something or is this the test you meant?
>>
>> For CMS I think you have a point. I was kind of thinking that the 
>> test TestParNewCMS was anyway testing that GC combination, but we 
>> should really have a separate CMS test as well. I just added 
>> TestCMS.java to test UseConcMarkSweepGC explicitly. Here is an 
>> updated webrev:
>>
>> http://cr.openjdk.java.net/~brutisso/8006398/webrev.01/
>>
>>>
>>> Do you want to test
>>>
>>> -XX:+UseConcMarkSweepGC -XX:-CMSIncrementalMode -version
>>>
>>> to check that no warning is emitted?
>>
>> Hm. I don't know. If we start combining all the flags we will get 
>> into an explosion of tests. I think this is a valid combination to 
>> test. But in that case so are things like "-XX:+UseConcMarkSweepGC 
>> -XX:-UseSerialGC". I like the way you think about this testing, I 
>> just think I would like to keep these tests to be smoke testing the 
>> more commonly used combinations.
>>
>> Make sense?
>>
>> Thanks again for looking at this!
>> Bengt
>>
>>>
>>> Jon
>>>
>>> On 2/12/2013 4:56 AM, Bengt Rutisson wrote:
>>>>
>>>> Hi again,
>>>>
>>>> Christian has pushed his test library change and it has propagated 
>>>> to the hotspot-gc repository. So, this change is ready to be 
>>>> pushed. Just need some reviews. Any takers? :)
>>>>
>>>> Thanks,
>>>> Bengt
>>>>
>>>> On 1/16/13 1:58 PM, Bengt Rutisson wrote:
>>>>>
>>>>> Hi all,
>>>>>
>>>>> Could I have a couple of reviews for this change?
>>>>> http://cr.openjdk.java.net/~brutisso/8006398/webrev.00/
>>>>>
>>>>> Recently we deprecated some GC combinations. Those should now 
>>>>> print a warning at startup. Other GC combinations should not print 
>>>>> any warnings.
>>>>>
>>>>> With the new process handling support that Christian Törnqvist is 
>>>>> adding to the JTREG tests for hotspot it is very easy to write 
>>>>> test that start a VM and checks the output.
>>>>>
>>>>> This changes makes use of Christian's testlibrary to verify that 
>>>>> warnings are printed as expected.
>>>>>
>>>>> I'm also adding the "gc" keyword to JTREG to make it possible to 
>>>>> filter out GC tests. We should probably use this for all test in 
>>>>> the the /gc folder, but I think that should be done as a separate 
>>>>> change.
>>>>>
>>>>> The webrev above is based on Christian's webrev to add the 
>>>>> testlibrary:
>>>>> http://cr.openjdk.java.net/~brutisso/8006413/webrev.00/
>>>>>
>>>>> Thanks,
>>>>> Bengt
>>>>>
>>>>
>>>>
>>>
>>
>
>
> -- 
> Leonid Mesnik
> JVM SQE

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/hotspot-gc-dev/attachments/20130213/f652d589/attachment.htm>