Request for review (S): 8005972: ParNew should not update the tenuring threshold when promotion failed has occurred

[Bengt Rutisson]

Hi John,

Thanks for looking at this!

On 1/10/13 7:10 PM, John Cuthbertson wrote:
> Hi Bengt,
>
> This looks good to me.
Great!

> We may want a CR to make G1 follow a similar model. Currently G1 
> updates its tenuring threshold in 
> G1CollectorPolicy:record_collection_pause_start() (via 
> update_survivors_policy()).

Right. The problem here is I guess that G1 does it at the start of the 
GC since it needs to know that it has the right number of survivor 
regions set up. So, we would have to remember that the previous GC got 
an evacuation failure and in that case not update the tenuring threshold 
based on the data in the age table. Or maybe, as suggested by Ramki, 
update it in a different way if the previous GC got an evacuation failure.

Thanks again for the review!
Bengt
>
> JohnC
>
> On 1/10/2013 1:30 AM, Bengt Rutisson wrote:
>>
>> Hi everyone,
>>
>> Could I have a couple of reviews for this small change to make DefNew 
>> and ParNew be more consistent in the way they treat the tenuring 
>> threshold:
>>
>> http://cr.openjdk.java.net/~brutisso/8005972/webrev.00/
>>
>> Thanks,
>> Bengt
>