Request for review (S): 8006398: Add regression tests for deprectated GCs

Erik Helin erik.helin at oracle.com
Wed Jan 16 13:56:11 UTC 2013


Hi Bengt,

looks good!

The test looks really nice with Christian's testlibrary, much more 
readable than using shell.

Erik

On 01/16/2013 01:58 PM, Bengt Rutisson wrote:
>
> Hi all,
>
> Could I have a couple of reviews for this change?
> http://cr.openjdk.java.net/~brutisso/8006398/webrev.00/
>
> Recently we deprecated some GC combinations. Those should now print a
> warning at startup. Other GC combinations should not print any warnings.
>
> With the new process handling support that Christian Törnqvist is adding
> to the JTREG tests for hotspot it is very easy to write test that start
> a VM and checks the output.
>
> This changes makes use of Christian's testlibrary to verify that
> warnings are printed as expected.
>
> I'm also adding the "gc" keyword to JTREG to make it possible to filter
> out GC tests. We should probably use this for all test in the the /gc
> folder, but I think that should be done as a separate change.
>
> The webrev above is based on Christian's webrev to add the testlibrary:
> http://cr.openjdk.java.net/~brutisso/8006413/webrev.00/
>
> Thanks,
> Bengt
>
>




More information about the hotspot-gc-dev mailing list