RFR(S): 8007036: G1: Too many old regions added to last mixed GC

[John Cuthbertson]

Hi Vitaly,

It's a good point and I don't know if it's an issue. The results of the 
duplicated calls should be dead code if PrintAdaptiveSizePolicy is not 
enabled.

I want consistency between determining whether to continue with mixed 
GCs and whether to continue to add old regions to the collection set. I 
also want the PrintAdaptiveSizePolicy output to display the correct and 
consistent information. I'll rework the code so that 
over_waste_threshold() takes the reclaimable space as a percentage as a 
parameter, hence removing the duplicated calls.

Thanks,

JohnC

On 1/28/2013 4:30 PM, Vitaly Davidovich wrote:
>
> In same file,
>
> 1829   // Is the amount of uncollected reclaimable space above 
> G1HeapWastePercent?
> 1830   size_t reclaimable_bytes = 
> cset_chooser->remaining_reclaimable_bytes();
> 1831   double reclaimable_perc = reclaimable_bytes_perc();
>
> 1832   double threshold = (double) G1HeapWastePercent;
> 1833   if (!over_waste_threshold()) {
>
> I think there's going to be some duplicate code running unless 
> compiler helps out:
> 1) cset_chooser->remaining_reclaimable_bytes() called above + by 
> reclaimable_bytes_perc()
> 2) reclaimable_bytes_perc() called above + by over_waste_threshold()
>
> Don't know if this is a concern or not but thought I'd mention it.
>
> Thanks
>
> Sent from my phone
>
>