RFR: 8017588: SA: jstack -l throws UnalignedAddressException while attaching to core file for java that was started with CMS GC

[Peter Allwin]

Erik, huge thanks for tracking this down and fixing it in SA!

Ship it!

/peter

-----Original Message-----
From: hotspot-runtime-dev-bounces at openjdk.java.net [mailto:hotspot-runtime-dev-bounces at openjdk.java.net] On Behalf Of Thomas Schatzl
Sent: Wednesday, July 3, 2013 10:49 AM
To: Erik Helin
Cc: hotspot-gc-dev at openjdk.java.net; hotspot-runtime-dev at openjdk.java.net
Subject: Re: RFR: 8017588: SA: jstack -l throws UnalignedAddressException while attaching to core file for java that was started with CMS GC

Hi,

On Wed, 2013-07-03 at 10:33 +0200, Erik Helin wrote:
> Hi all,
>
> this change fixes an issue where we could not run jstack -l -F on a 
> java process running with -XX:+UseConcMarkSweepGC.
>
> The problem originated from the following change in hotspot:
>  changeset:   3707:8bafad97cd26
>  parent:      3693:973046802b6f
>  7158552: The instanceKlsss::_host_klass is only needed for anonymous 
> class for JSR 292 support.
>
> [...]
>
> The corresponding code in the serviceability agent was not updated:
>
> [...]
>
> This fix updates the SA code to be like the hotspot code. I've also 
> introduced variables in the hotspot code and in the SA code to make it 
> easier to compare the two versions.

Looks good to me. Thanks for breaking out the calculation of the components into separate statements.

Thomas