RFR (XXS): 8020123 Test gc/g1/TestPrintRegionRememberedSetInfo.java fails with "test result: Error. No action after @build"

[Mikael Gerdin]

Thomas,

On 2013-07-10 11:20, Thomas Schatzl wrote:
> Hi all,
>
>    can I get a review for the the following tiny change?
>
> In this case, jtreg complained with a "test result: Error. No action
> after @build" message when trying to build/run it.
>
> The cause for this issue has been the use of jtreg 4.0 to develop and
> test it (where this error does not occur), but regression testing is
> running jtreg 4.1 (where this is an error).
>
> This has apparently been an error since the corresponding change has
> been committed, but this error has been shadowed by another jtreg
> problem.
>
> Another issue is that this test does not have a @run statement, so the
> test has never been run during regression testing.
>
> The fix consists of replacing the @build line with a @run line; a
> separate @build line is not needed as the test has no additional
> dependencies that need explicit building.
>
> I.e.
>
>    * @test TestPrintRegionRememberedSetInfo
>    * @key gc
>    * @bug 8014240
>    * @summary Test output of G1PrintRegionRememberedSetInfo
>    * @library /testlibrary
> - * @build TestPrintRegionRememberedSetInfo
> + * @run main TestPrintRegionRememberedSetInfo
>    * @author thomas.schatzl at oracle.com
>    */
>
>
> Webrev
> http://cr.openjdk.java.net/~tschatzl/8020123/webrev.00/

We don't usually keep "@author" tags to the sources since the 
information is readily available in the version control system.
However I'm fine with this change as-is if you don't want to re-spin the 
patch.

Ship it!

/Mikael

>
> Bugs.sun
> http://bugs.sun.com/view_bug.do?bug_id=8020123
>
> JBS:
> https://jbs.oracle.com/bugs/browse/JDK-8020123
>
> Testing:
> jprt with that regression test explicitly run
>
> Thanks,
>    Thomas
>