RFR (S): 8015972: Refactor the sending of the object count after GC event

Erik Helin erik.helin at oracle.com
Fri Jun 7 14:42:31 UTC 2013


On 2013-06-07, Mikael Gerdin wrote:
> Erik,
> 
> On 2013-06-07 15:42, Erik Helin wrote:
> >All,
> >
> >based on internal feedback, I've updated the change, please see new
> >webrev at:
> >
> >http://cr.openjdk.java.net/~ehelin/8015972/webrev.01/
> 
> Looks good to me.

Thanks!

Erik

> /Mikael
> 
> >
> >The changes from webrev.00 are:
> >- Using the typedef GCId instead of jlong
> >- Remove the #include "utilities/macro.hpp" from
> >   objectCountEventSender.hpp
> >- Use public inheritance from AllStatic
> >- Sort includes in objectCountEventSender.hpp
> >- Remove the "should_commit" check from ObjectCountEventSender::send,
> >   add an assert instead
> >- Use >= instead of > in ObjectCountEventSenderClosure::should_send_event
> >- Remove the "is_alive" variable from ObjectCountFilter::do_object_b
> >
> >Thanks,
> >Erik
> >
> >On 2013-06-05, Erik Helin wrote:
> >>Hi all,
> >>
> >>this small change refactors the way the object count after GC trace
> >>event is sent.
> >>
> >>Webrev:
> >>http://cr.openjdk.java.net/~ehelin/8015972/webrev.00/
> >>
> >>Bug:
> >>http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8015972
> >>
> >>Testing:
> >>JPRT
> >>
> >>Thanks,
> >>Erik



More information about the hotspot-gc-dev mailing list