Request for review (s) - 8015851 :UseAdaptiveGCBoundary is broken

[Jon Masamitsu]

On 6/7/2013 1:52 AM, Thomas Schatzl wrote:
> Hi,
>
> On Wed, 2013-06-05 at 17:25 -0700, Jon Masamitsu wrote:
>> Fixed the CR # in the subject.
>>
>> On 6/5/2013 1:27 PM, Jon Masamitsu wrote:
>>> A recent changeset effectively removed the initialization of
>>> performance counters used  by the option UseAdaptiveGCBoundary
>>>
>>> This changeset is built on top of the one for 8014546 and the
>>> webrev comes in two parts.
>>>
>>> The fix plus the test
>>>
>>> http://cr.openjdk.java.net/~jmasa/8015851/webrev.00/
> Looks good.
>
> About the test: is there a way to actually test performance counter
> initialization? So far it only checks whether the VM crashes, and not
> whether initialization is okay.

The call to System.gc() will cause the performance counters to be updated.
At least the performance counters that are explicitly updated after a GC.
There could be performance counters that are updated periodicially
instead.  Those latter won't necessarily be updated.   I think we would
need to use something external to the JVM like jstat to see if the
counters made sense.  I think that is more than a regression test.

>
>>> Some cleanups of the code
>>>
>>> http://cr.openjdk.java.net/~jmasa/8015851/webrev_refactor.00/
>>>
> Just to make sure what this cleanup is about: move the call to
> initialize_work() into the constructors of the generations, and clean up
> some unused constructors.

Yes.

Thanks.

Jon
>
> If so, looks okay.
>
> Hth,
> Thomas
>