RFR (S): 8015683: object_count_after_gc should have the same timestamp for all events

Stefan Karlsson stefan.karlsson at oracle.com
Wed Jun 12 11:17:38 UTC 2013


On 06/12/2013 11:27 AM, Erik Helin wrote:
> On 2013-06-12, Stefan Karlsson wrote:
>> On 06/09/2013 09:28 AM, Erik Helin wrote:
>>> Hi all,
>>>
>>> this small change ensures that all vm/gc/detailed/object_count_after_gc trace
>>> events that are sent during the same GC will have identical timestamps.
>>>
>>> Please note that this change is based upon another change that is out
>>> for review - "8015972: Refactor the sending of the object count after GC event".
>>>
>>> Webrev:
>>> http://cr.openjdk.java.net/~ehelin/8015683/webrev.00/
>> I think it would be better to convert this event into an Instant
>> event, then you wouldn't have to store two identical timestamps in
>> the event.
> Agree, I've updated the webrev to take this into account. Please see new
> webrev at:
>
> http://cr.openjdk.java.net/~ehelin/8015683/webrev.01/

Looks good.

StefanK

>
> Thanks,
> Erik
>
>> thanks,
>> StefanK
>>
>>> Testing:
>>> JPRT
>>>
>>> Thanks,
>>> Erik




More information about the hotspot-gc-dev mailing list