Request for review: 8015903: Format issue with -XX:+PrintAdaptiveSizePolicy on JDK8

Bengt Rutisson bengt.rutisson at oracle.com
Thu Jun 13 09:53:43 UTC 2013


Looks good.

Bengt

On 6/10/13 5:24 PM, Vladimir Kempik wrote:
> Hello.
>
> Thanks for comment.
>
> Here is updated webrev - 
> http://cr.openjdk.java.net/~mcherkas/vladimir/8015903/webrev.02/
>
> Vladimir.
>
> On 08.06.2013 15:07, Bengt Rutisson wrote:
>> Vladimir,
>>
>> I would prefer to remove the tty->cr() call you changed and instead 
>> use gclog_or_tty->print_cr() in the gclog_or_tty->print() statement 
>> before.
>>
>> Other than that it looks good.
>>
>> Bengt
>>
>> 7 jun 2013 kl. 18:23 skrev Jesper Wilhelmsson 
>> <jesper.wilhelmsson at oracle.com>:
>>
>>> Vladimir Kempik skrev 7/6/13 5:13 PM:
>>>> Thanks for comments
>>>>
>>>> Here is updated webrev -
>>>> http://cr.openjdk.java.net/~mcherkas/vladimir/8015903/webrev.01/
>>> Thanks for fixing this!
>>> Looks good, ship it (once the gc repo is open for pushes again).
>>> /Jesper
>>>
>>>
>>>> On 07.06.2013 18:37, Jesper Wilhelmsson wrote:
>>>>> Vladimir,
>>>>>
>>>>> Looks good,
>>>>>
>>>>> When I fixed the same thing yesterday I noticed that the method 
>>>>> above,
>>>>> PSAdaptiveSizePolicy::compute_survivor_space_size_and_threshold, 
>>>>> writes its
>>>>> cr() to tty instead of gclog_or_tty. Do you mind fixing that in 
>>>>> the same
>>>>> change since it is slightly related?
>>>>>
>>>>> And I don't know how to stress this enough, you are not the first 
>>>>> one who did
>>>>> it, never ever work on a bug without assigning it to yourself, or 
>>>>> talk to the
>>>>> assigned engineer first. Having two engineers working on the same 
>>>>> bug is not
>>>>> efficient use of our time.
>>>> Sorry about that.
>>>>
>>>> Vladimir.
>>>>> /Jesper
>>>>>
>>>>>
>>>>>
>>>>> Vladimir Kempik skrev 7/6/13 3:46 PM:
>>>>>> Hi all,
>>>>>>
>>>>>> Could I have a couple of reviews for this change?
>>>>>>
>>>>>> http://cr.openjdk.java.net/~mcherkas/vladimir/8015903/webrev.00/
>>>>>>
>>>>>> With next option -XX:+PrintAdapriveSizePolicy, java log looks 
>>>>>> like this:
>>>>>>
>>>>>> AdaptiveSizePolicy::update_averages: survived: 479272 promoted: 
>>>>>> 251648 overflow:
>>>>>> falseAdaptiveSizeStart: 4,136 collection: 16
>>>>>>    avg_survived_padded_avg: 2223544,750000 avg_promoted_padded_avg:
>>>>>> 1300947,750000 avg_pretenured_padded_avg: 286597,000000 
>>>>>> tenuring_thresh: 1
>>>>>> target_size: 1835008
>>>>>>
>>>>>> and there is no space between overflow: false and AdaptiveSizeStart:
>>>>>>
>>>>>> The patch adds line break after overflow: false.
>>>>>>
>>>>>> Thanks,
>>>>>> Vladimir
>




More information about the hotspot-gc-dev mailing list