RFR (XXS): 8016740 HS23/24: assert in GC_locker from PSOldGen::expand with -XX:+PrintGCDetails and Verbose (backport)

Tao Mao tao.mao at oracle.com
Thu Jun 20 18:03:57 UTC 2013


Looks good and this case should be considered a clean apply.

Thanks.
Tao

On 6/19/13 1:11 AM, Thomas Schatzl wrote:
> Hi all,
>
>    can I have quick reviews for this backport to hs24 of a hs25 fix?
>
> The change is about a wrong predicate in an assert.
>
> The original change (1 line change) applied cleanly except for slightly
> different line numbers.
>
> Webrev
> http://cr.openjdk.java.net/~tschatzl/8016740/webrev/
>
> Webrev of hs25 change:
> http://cr.openjdk.java.net/~tschatzl/8005857/webrev/
>
> JIRA
> https://jbs.oracle.com/bugs/browse/JDK-8016740
> (Original: https://jbs.oracle.com/bugs/browse/JDK-8005857 )
>
> Bugs.sun.com
> http://bugs.sun.com/view_bug.do?bug_id=8016740
>
> Testing:
> jprt, manual testing
>
> Note that the original change did not have a regression test, so I did
> not add one here. I opened CR 8016752 to add a test case that will
> eventually trickle down to hs24.
>
> Thanks,
> Thomas
>
>



More information about the hotspot-gc-dev mailing list