Request for review (s) - 8015851 :UseAdaptiveGCBoundary is broken
Jon Masamitsu
jon.masamitsu at oracle.com
Tue Jun 25 06:49:37 UTC 2013
The new version of the code cleanup is here
http://cr.openjdk.java.net/~jmasa/8015851/webrev_refactor.01/
I have changed the initialization of the generations done in
adjoiningGenerations.cpp
to use the same code for both UseAdaptiveGCBoundary "on" and "off" and
deleted the additional dead code.
The code for UseAdaptiveGCBoundary "off" was the code to create the
generations before UseAdaptiveGCBoundary was first implemented.
The code for UseAdaptiveGCBoundary "on" was the new path where
the virtual spaces for the young gen and the old gen were created
together. In the latter case the virtual space for the young gen and the
virtual space for the old gen can both span almost the entire heap
but are guaranteed not to overlap the same part of the heap at any
time. In the absence of boundary moving the generations initialized
in the "off" path and the "on" path serve the same role and were
initialized equivalently.
Jon
On 6/5/2013 1:27 PM, Jon Masamitsu wrote:
> A recent changeset effectively removed the initialization of
> performance counters used by the option UseAdaptiveGCBoundary
>
> This changeset is built on top of the one for 8014546 and the
> webrev comes in two parts.
>
> The fix plus the test
>
> http://cr.openjdk.java.net/~jmasa/8015851/webrev.00/
>
> Some cleanups of the code
>
> http://cr.openjdk.java.net/~jmasa/8015851/webrev_refactor.00/
>
> Thanks.
>
> Jon
More information about the hotspot-gc-dev
mailing list