RFR(xs): 8014022: G1: Non Java threads should lock the shared SATB queue lock without safepoint checks.

Thomas Schatzl thomas.schatzl at oracle.com
Thu Jun 27 13:19:44 UTC 2013


On Thu, 2013-06-27 at 15:00 +0200, Per Liden wrote:
> Hi,
> 
> Could I please have a couple of reviews on this small fix.
> 
> Summary: If a non-Java thread writes to an object field the G1 
> pre-barrier can potentially safepoint when acquiring the shared pointer 
> queue lock (Shared_SATB_Q_lock). This is problematic if e.g. the 
> non-Java thread has joined the STS. The solution is to grab the lock 
> without a safepoint check.

Looks good.

Thomas




More information about the hotspot-gc-dev mailing list